Give layers a draw port through the viewer they hold

The Cesium draw sets move out of the shared ports into their own module,
so they can be built over a viewer no renderer is bound to. findDraw and
drawOf find a viewer's draw port as findCamera finds its camera: the bound
renderer's, or one built over a caller's own viewer once the Cesium
adapter's draw module (exported as ./render/cesium/draw) has loaded. A
renderer bound later releases a built port: its sets keep drawing.
This commit is contained in:
Sameh Khamis committed 2026-11-06 19:15:01 -08:00
1 parent b3dfcddcde
commit 99ad51048f
8 files changed
+807 -489

No files matched your search

+70
View File
@@ -0,0 +1,70 @@
import assert from 'node:assert/strict';
import * as Cesium from 'cesium';
import test from 'node:test';
import { bindRenderer, drawOf, findDraw } from '../rendererOf.js';
import './draw.js';
/** A scene with what the draw port touches: primitives and its events. */
function fakeScene() {
const added = [];
const postRender = new Cesium.Event();
const preRender = new Cesium.Event();
return {
added,
postRender,
preRender,
camera: { positionWC: new Cesium.Cartesian3(2e7, 0, 0) },
primitives: {
add: (primitive) => (added.push(primitive), primitive),
remove: (primitive) => {
const at = added.indexOf(primitive);
if (at >= 0) added.splice(at, 1);
return at >= 0;
},
length: 0,
},
destroyed: false,
requestRender() {
if (this.destroyed) throw new Error('This object was destroyed');
},
isDestroyed() {
return this.destroyed;
},
};
}
test('a viewer of its own, with no renderer bound, draws through a built port', () => {
const scene = fakeScene();
const viewer = { scene, isDestroyed: () => destroyed };
let destroyed = false;
const draw = drawOf(viewer);
assert.equal(findDraw(viewer), draw, 'one per viewer');
const set = draw.points({ id: 'mine' });
set.set([{ id: 'a', pos: { lon: 0, lat: 0 }, pixelSize: 4, color: '#fff' }]);
assert.equal(scene.added.length, 1, 'drawn into the viewer’s scene');
assert.equal(scene.added[0].get(0).id.set, 'mine');
// A renderer bound later answers new callers; the sets keep drawing.
const unbind = bindRenderer(viewer, { draw: { id: 'renderer' } });
assert.equal(findDraw(viewer).id, 'renderer');
assert.equal(scene.added.length, 1);
set.dispose();
assert.equal(scene.added.length, 0);
unbind();
// Gone with its viewer, a built port lets go; a set its layer disposes
// after that has nothing left to do.
const again = drawOf(viewer);
assert.notEqual(again, draw);
const late = again.points({ id: 'left' });
late.set([]);
destroyed = true;
scene.destroyed = true;
assert.equal(findDraw(viewer), null);
late.dispose();
});
test('nothing to draw into, no port', () => {
assert.equal(findDraw({ scene: {} }), null);
assert.throws(() => drawOf({}), /no renderer to draw with/);
});