benmichael/gods-eye-view
1
0 Fork 0
mirror of https://github.com/bilawalsidhu/gods-eye-view.git synced 2026-11-12 06:12:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Request frames again while waiting for tiles and transitions

Browse Source 
A request-mode globe updates its tile state only on drawn frames, so tile
and UI readiness that never asked for one waited until something else
drew: imagery, weather and ground scenarios took several times longer.
The idle checks measure through their own passive observer and are not
affected.
This commit is contained in:
German Khokhlov committed 2026-11-10 21:25:08 +04:00
1 parent 555906da6b
commit 97e192ebce
2 files changed
+7 -4
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

scripts/qa/ready.mjs
+3
View File
@@ -210,6 +210,8 @@ export async function whenTilesLoaded(page, { timeoutMs = 30000 } = {}) {
() => { () => {
const engine = window.__godsEyeView?.engine; const engine = window.__godsEyeView?.engine;
if (!engine || engine.isDestroyed()) return false; if (!engine || engine.isDestroyed()) return false;
// A request-mode globe only updates tile state on drawn frames.
engine.render.request('qa-tile-readiness');
return engine.surface.tilesLoaded(); return engine.surface.tilesLoaded();
}, },
{ timeout: timeoutMs, polling: 100 }, { timeout: timeoutMs, polling: 100 },
@@ -221,6 +223,7 @@ export async function whenUiSettled(page) {
const handle = await page.waitForFunction( const handle = await page.waitForFunction(
() => { () => {
const app = window.__godsEyeView; const app = window.__godsEyeView;
app?.engine?.render.request('qa-ui-readiness');
return ( return (
!app?.styleManager?.transitions?.size && !app?.styleManager?.transitions?.size &&
document document
scripts/qa/ready.test.mjs
+4 -4
View File
@@ -287,7 +287,7 @@ test('camera readiness also waits for the startup cover to stop intercepting cli
}); });
}); });
test('tile and UI polling never request globe frames', async (t) => { test('tile and UI polling request frames so a request-mode globe progresses', async (t) => {
const { engine } = pageEngine(t); const { engine } = pageEngine(t);
const previous = globalThis.document; const previous = globalThis.document;
globalThis.document = { getAnimations: () => [] }; globalThis.document = { getAnimations: () => [] };
@@ -295,9 +295,8 @@ test('tile and UI polling never request globe frames', async (t) => {
if (previous === undefined) delete globalThis.document; if (previous === undefined) delete globalThis.document;
else globalThis.document = previous; else globalThis.document = previous;
}); });
t.mock.method(engine.render, 'request', () => { const reasons = [];
assert.fail('passive readiness requested a frame'); t.mock.method(engine.render, 'request', (reason) => reasons.push(reason));
});
const page = { const page = {
async waitForFunction(predicate) { async waitForFunction(predicate) {
assert.equal(predicate(), true); assert.equal(predicate(), true);
@@ -306,4 +305,5 @@ test('tile and UI polling never request globe frames', async (t) => {
}; };
await whenTilesLoaded(page); await whenTilesLoaded(page);
await whenUiSettled(page); await whenUiSettled(page);
assert.deepEqual(reasons, ['qa-tile-readiness', 'qa-ui-readiness']);
}); });