mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 16:22:20 +00:00
feat(panels): render each panel's state classes from the store
A panel's collapsed, dock-pinned, dock-pinned-top, layout-auto-collapsed
and accordion-collapsed classes are drawn by its root's v-panel-state from
the gev-panel-chrome store. PanelChrome, its restore, the layout
controller, both rails and the side accordion present each panel's state
there instead of writing its classes; the rails call onCollapse(panel,
{collapsed, auto}). The directive applies a change in a synchronous
watcher, since the rails measure a panel in the task that opens or closes
it.
Destroying the chrome inside Cockpit now puts back the panels Cockpit's
entry closed while it can still present them. Without a shell, the voice
tools' set_panel_open reports that there is no panel to open. QA scripts
present the states they set instead of writing the classes.
This commit is contained in:
1 parent
dd3a2c87f9
commit
95523e09cd
37 files changed
+404
-135
No files matched your search
@@ -9,7 +9,8 @@
|
||||
* @param {boolean} options.enabled Whether the one-panel rule applies.
|
||||
* @param {string} [options.preferredPanelId] Most recently opened panel.
|
||||
* @param {Document} [options.documentRef] Document supplying keyboard focus.
|
||||
* @param {Function} options.onCollapse Update a panel's disclosure chrome.
|
||||
* @param {Function} options.onCollapse Present a panel's collapse:
|
||||
* `(panel, {collapsed, auto})`.
|
||||
*/
|
||||
export function settleSideAccordion({
|
||||
panels,
|
||||
@@ -21,8 +22,7 @@ export function settleSideAccordion({
|
||||
if (!enabled) {
|
||||
for (const panel of panels) {
|
||||
if (!panel.classList.contains('accordion-collapsed')) continue;
|
||||
panel.classList.remove('collapsed', 'accordion-collapsed');
|
||||
onCollapse(panel);
|
||||
onCollapse(panel, { collapsed: false, auto: null });
|
||||
}
|
||||
return;
|
||||
}
|
||||
@@ -35,7 +35,6 @@ export function settleSideAccordion({
|
||||
expanded[0];
|
||||
for (const panel of expanded) {
|
||||
if (panel === owner) continue;
|
||||
panel.classList.add('collapsed', 'accordion-collapsed');
|
||||
onCollapse(panel);
|
||||
onCollapse(panel, { collapsed: true, auto: 'accordion' });
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user