mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-22 03:02:20 +00:00
refactor(cctv): isolate native rendering resources
Keep shared CCTV logic independent of Cesium, release the original renderer's resources, and guard retired initialization/media work. Preserve native marker, plane, volume, calibration and input behavior. Record keyless dev/preview validation and retain unresolved shell idle/terrain and photoreal acceptance gaps. Routine QA builds use empty Google and Cesium credentials and block paid maps before navigation.
This commit is contained in:
1 parent
f72bf6a774
commit
93c71ffc86
32 files changed
+1536
-740
No files matched your search
@@ -0,0 +1,122 @@
|
||||
import assert from 'node:assert/strict';
|
||||
import { test } from 'node:test';
|
||||
import { createLifecycle } from './lifecycle.js';
|
||||
import { createState } from './state.js';
|
||||
|
||||
function setup(t, { failMarkers = false } = {}) {
|
||||
const noop = () => {};
|
||||
const services = {
|
||||
overlays: {
|
||||
clearOverlaySource: noop,
|
||||
hitTestWorldOverlay: noop,
|
||||
setOverlayEntries: noop,
|
||||
setOverlaySourceVisible: noop,
|
||||
},
|
||||
activation: {},
|
||||
picking: { unregisterPickOwner: noop },
|
||||
focus: {},
|
||||
render: { releaseContinuousRender: noop },
|
||||
};
|
||||
const state = createState({ services });
|
||||
const pending = [];
|
||||
const renderers = [];
|
||||
const parts = {
|
||||
geometryQueue: { stopGeometryLoadQueue: noop },
|
||||
cards: { teardownAmbientCards: noop, handleVisibilityChange: noop },
|
||||
projection: { clearProjectionOverlay: noop, stopProjectionLoop: noop },
|
||||
geometry: { destroyCoverageEntities: noop },
|
||||
calibration: { loadCalibrationStore: () => new Map() },
|
||||
catalog: {
|
||||
loadCameraSources: () => new Promise((resolve) => pending.push(resolve)),
|
||||
},
|
||||
};
|
||||
const rendererFactory = () => {
|
||||
const renderer = {
|
||||
owner: null,
|
||||
released: false,
|
||||
releases: 0,
|
||||
hideCredit() {},
|
||||
attach(owner) {
|
||||
this.owner = owner;
|
||||
},
|
||||
createMarkers() {
|
||||
if (failMarkers) throw new Error('marker allocation failed');
|
||||
},
|
||||
destroy() {
|
||||
if (!this.released) {
|
||||
this.released = true;
|
||||
this.releases++;
|
||||
}
|
||||
},
|
||||
};
|
||||
renderers.push(renderer);
|
||||
return renderer;
|
||||
};
|
||||
const layer = createLifecycle({
|
||||
state,
|
||||
services,
|
||||
parts,
|
||||
rendererFactory,
|
||||
}).methods;
|
||||
t.after(() => layer.destroy());
|
||||
return { state, pending, parts, layer, renderers };
|
||||
}
|
||||
|
||||
test('repeated initialization rejects without replacing the current CCTV owner', async (t) => {
|
||||
const h = setup(t);
|
||||
const owner = {};
|
||||
const starting = h.layer.init(owner);
|
||||
const stopped = assert.rejects(starting, { name: 'AbortError' });
|
||||
await assert.rejects(h.layer.init({}), /already initialized/);
|
||||
assert.equal(h.renderers.length, 1);
|
||||
assert.equal(h.parts.renderer.owner, owner);
|
||||
assert.equal(h.parts.renderer.released, false);
|
||||
h.layer.destroy({});
|
||||
h.pending[0]([]);
|
||||
await stopped;
|
||||
assert.equal(h.renderers[0].releases, 1);
|
||||
});
|
||||
|
||||
test('a retired init rejection cannot destroy the newer CCTV owner', async (t) => {
|
||||
const h = setup(t);
|
||||
const first = assert.rejects(h.layer.init({}), { name: 'AbortError' });
|
||||
h.layer.destroy();
|
||||
const owner = {};
|
||||
const second = assert.rejects(h.layer.init(owner), { name: 'AbortError' });
|
||||
const current = h.parts.renderer;
|
||||
h.pending[0]([]);
|
||||
await first;
|
||||
assert.equal(h.parts.renderer, current);
|
||||
assert.equal(current.owner, owner);
|
||||
assert.equal(current.released, false);
|
||||
assert.equal(h.state._sourceAbort.signal.aborted, false);
|
||||
h.layer.destroy();
|
||||
h.pending[1]([]);
|
||||
await second;
|
||||
assert.deepEqual(
|
||||
h.renderers.map((renderer) => renderer.releases),
|
||||
[1, 1],
|
||||
);
|
||||
});
|
||||
|
||||
test('initial resource failure disposes its owner and leaves initialization retryable', async (t) => {
|
||||
const h = setup(t, { failMarkers: true });
|
||||
for (let i = 0; i < 2; i++) {
|
||||
await assert.rejects(h.layer.init({}), /marker allocation failed/);
|
||||
assert.equal(h.parts.renderer, null);
|
||||
assert.equal(h.state._sourceAbort.signal.aborted, true);
|
||||
}
|
||||
assert.deepEqual(
|
||||
h.renderers.map((renderer) => renderer.releases),
|
||||
[1, 1],
|
||||
);
|
||||
});
|
||||
|
||||
test('destroy releases focus-appearance callbacks even without prior disable', (t) => {
|
||||
const h = setup(t);
|
||||
let released = 0;
|
||||
h.state._removeFocusAppearListener = () => released++;
|
||||
h.layer.destroy();
|
||||
h.layer.destroy();
|
||||
assert.equal(released, 1);
|
||||
});
|
||||
Reference in new issue
Block a user