mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 16:22:20 +00:00
Keep the debug handle off window between engines and recover the page after a failed recovery
The application's debug handle is one object, present on window only while a globe is attached, so scripts reading __godsEyeView?.engine.kind see no null engine mid-switch. A detached application has no live components: settle no longer waits for a frame of a missing engine, and an engine that runs again after a failed recovery hides the loading screen the error showed.
This commit is contained in:
1 parent
a99b862580
commit
8e1a3bab3e
3 files changed
+104
-6
No files matched your search
+9
-4
@@ -91,10 +91,12 @@ function createApplication(kind, engineSwitch) {
|
||||
return application;
|
||||
}
|
||||
|
||||
// The running application while a globe is attached to it; null while the
|
||||
// page has no engine (between engines, or after a failed recovery).
|
||||
function liveComponents() {
|
||||
return application?.getState().status === 'ready'
|
||||
? application.getComponents()
|
||||
: null;
|
||||
if (application?.getState().status !== 'ready') return null;
|
||||
const components = application.getComponents();
|
||||
return components.scene?.engine ? components : null;
|
||||
}
|
||||
|
||||
// The page's application is created once; a switch detaches and attaches
|
||||
@@ -108,7 +110,7 @@ const legacySwitch =
|
||||
// parked for a later switch back.
|
||||
async function leave(from) {
|
||||
const components = liveComponents();
|
||||
const attached = Boolean(components?.scene.engine);
|
||||
const attached = Boolean(components);
|
||||
if (attached) {
|
||||
cover ??= keepGlobeFrame(components.scene.engine);
|
||||
cockpit = components.controls.styleManager.getCockpitState();
|
||||
@@ -206,6 +208,9 @@ async function settle() {
|
||||
layerSession.handoffLayers = null;
|
||||
cockpit = null;
|
||||
withdrawEngineRetry();
|
||||
// An engine runs again after a failed recovery showed its error: the
|
||||
// application, built once, does not start its loading chrome again.
|
||||
loading.classList.add('hidden');
|
||||
// The running engine owns the address again, including an entry visited
|
||||
// before its share link listened or while it was held.
|
||||
components.controls.styleManager.shareLinkManager?.resumeNavigation?.();
|
||||
|
||||
Reference in new issue
Block a user