mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-17 00:32:21 +00:00
Scenes: a revocation also covers the release a stopped run reaches later
A run or LOAD takes the release authority when it starts, so cleanup it reaches after revokeSceneRelease() turns no layer off.
This commit is contained in:
1 parent
a9990018ea
commit
87b6a4d0c8
3 files changed
+73
-7
No files matched your search
@@ -2074,6 +2074,40 @@ test('a revoked scene release turns no further layer off', async () => {
|
||||
} finally { await director.destroy(); restore(); }
|
||||
});
|
||||
|
||||
test('a revocation also covers the release a stopped run reaches later', async () => {
|
||||
const project = structuredClone(PROJECT_FIXTURE);
|
||||
project.scenes[0].releaseLayerIds = ['flights'];
|
||||
const { director, styleManager, dataManager, restore } = makeDirector({ project });
|
||||
try {
|
||||
// The run's visual phase hangs and ignores Stop, as a stuck teardown does.
|
||||
let settlePhase;
|
||||
styleManager.applyVisualState = () =>
|
||||
new Promise((resolve) => {
|
||||
settlePhase = resolve;
|
||||
});
|
||||
const run = director.startScene('scene-1', { single: true, preview: true });
|
||||
await settle();
|
||||
assert.ok(settlePhase, 'the run is waiting in its phase');
|
||||
director.stopScene();
|
||||
director.revokeSceneRelease();
|
||||
const after = dataManager.setEnabledCalls.length;
|
||||
settlePhase(true);
|
||||
await run;
|
||||
const late = dataManager.setEnabledCalls
|
||||
.slice(after)
|
||||
.filter(({ enabled, signal }) => !enabled && !signal?.aborted);
|
||||
assert.deepEqual(late, [], 'no layer is turned off after the revoke');
|
||||
// A run started afterwards releases its layers again.
|
||||
styleManager.applyVisualState = async () => true;
|
||||
await director.startScene('scene-1', { single: true, preview: true });
|
||||
assert.ok(
|
||||
dataManager.setEnabledCalls.some(
|
||||
({ id, enabled, signal }) => id === 'flights' && !enabled && !signal?.aborted,
|
||||
),
|
||||
);
|
||||
} finally { await director.destroy(); restore(); }
|
||||
});
|
||||
|
||||
/** Drive frame-by-frame camera motion headlessly for one test. */
|
||||
function installAnimationFrames() {
|
||||
const original = globalThis.requestAnimationFrame;
|
||||
|
||||
Reference in new issue
Block a user