From 8482daa37721187c266c20d911b0d4e38f74011c Mon Sep 17 00:00:00 2001
From: Said Turksever <asturksever@gmail.com>
Date: Mon, 5 Oct 2026 15:18:14 +0100
Subject: [PATCH] test(ui): the panel gate waits for the rail on a timer, and
 never fails on it

On the CI runner the CCTV box never held pixel-identical for ten animation
frames within 15 s, so settle() timed out and failed the gate although the
street-level gate before it passed. The wait now rounds the box to whole
pixels, polls every 100 ms for half a second of stillness, and only logs if
the rail keeps moving: the lift is checked against the box recorded at
pointerdown, so settling is only there to make that box the docked one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---
 scripts/qa-panel-resize.mjs | 43 ++++++++++++++++++++++++-------------
 1 file changed, 28 insertions(+), 15 deletions(-)

diff --git a/scripts/qa-panel-resize.mjs b/scripts/qa-panel-resize.mjs
index d3cb7af7f..93aada570 100644
--- a/scripts/qa-panel-resize.mjs
+++ b/scripts/qa-panel-resize.mjs
@@ -132,21 +132,34 @@ async function main() {
         };
       }, PANEL_ID);
     /** Wait until the CCTV box has held still for ten animation frames. */
-    const settle = () =>
-      page.waitForFunction(
-        (id) => {
-          const r = document.getElementById(id).getBoundingClientRect();
-          const box = `${r.left},${r.top},${r.width},${r.height}`;
-          if (window.__qaLastBox === box) window.__qaStill += 1;
-          else {
-            window.__qaLastBox = box;
-            window.__qaStill = 0;
-          }
-          return window.__qaStill >= 10;
-        },
-        { polling: 'raf', timeout: 15_000 },
-        PANEL_ID,
-      );
+    /**
+     * Best effort: wait until the CCTV box (to the whole pixel) has held still
+     * for half a second. The lift is checked against the box at pointerdown,
+     * so a rail that keeps nudging the panel only costs the wait, not the run.
+     */
+    const settle = async () => {
+      try {
+        await page.waitForFunction(
+          (id) => {
+            const r = document.getElementById(id).getBoundingClientRect();
+            const box = [r.left, r.top, r.width, r.height]
+              .map(Math.round)
+              .join(',');
+            const now = performance.now();
+            if (window.__qaLastBox !== box) {
+              window.__qaLastBox = box;
+              window.__qaSince = now;
+            }
+            return now - window.__qaSince >= 500;
+          },
+          { polling: 100, timeout: 20_000 },
+          PANEL_ID,
+        );
+      } catch (error) {
+        if (error?.name !== 'TimeoutError') throw error;
+        console.log('note: the CCTV panel was still moving; lifting anyway');
+      }
+    };
     const headerPoint = async () => {
       const rect = await page.evaluate((id) => {
         const title = document.querySelector(