Delete the billboard and model mirrors; models become layer-held records

Aircraft draw from GPU icon sets, so the billboard mirror, the billboard
treatment and the aircraft visual-state module had no callers left. 3D models
are now records the layer holds under the contact's id (modelRecord.js):
show and placement are written through showModel/placeModel and read back
from the record; renderer-measured values stay on record.model.

The tracked-model click check only matches when a tracked model exists, so
an id-only pick is never mistaken for a click on the tracked plane.
This commit is contained in:
Sameh Khamis committed 2026-11-03 22:36:27 -08:00
1 parent c9f1fcd425
commit 83ec9473b6
35 files changed
+391 -788

No files matched your search

+8 -8
View File
@@ -164,8 +164,8 @@ test('a conversion survives a poll refresh, in both the billboard and the tracke
_setTrackedFlightRefreshStateForTest({
icao24,
entity,
billboard,
billboardCollection: { show: false, remove() {} },
icon: billboard,
iconLayer: { show: false, remove() {} },
viewer,
meta: {
callsign: 'OLD1',
@@ -298,13 +298,13 @@ test('conversions are session-scoped and no lifecycle path clears them', async (
_setTrackedFlightRefreshStateForTest({
icao24,
entity: null,
billboard: {
icon: {
position: Cesium.Cartesian3.fromDegrees(-97.7, 30.2, 9_000),
color: Cesium.Color.WHITE,
image: aircraftIcon('tr3b'),
show: true,
},
billboardCollection: { show: false, remove() {} },
iconLayer: { show: false, remove() {} },
viewer,
tracked: false,
meta: { callsign: 'OLD1', altitude: 9_000, klass: 'airliner', rawLat: 30.2, rawLon: -97.7 },
@@ -462,12 +462,12 @@ test('cockpit class filter matches a converted contact end to end', async () =>
const seed = () => _setTrackedFlightRefreshStateForTest({
icao24,
entity: null,
billboard: {
icon: {
position: Cesium.Cartesian3.fromDegrees(-97.71, 30.21, 10_668),
color: Cesium.Color.WHITE,
show: true,
},
billboardCollection: { show: true, remove() {} },
iconLayer: { show: true, remove() {} },
viewer: { camera: { positionCartographic: null }, scene: {} },
tracked: false,
meta: { callsign: 'SWA696 ', altitude: 10_668, klass: 'airliner', onGround: false },
@@ -508,12 +508,12 @@ test('military records and detection cards agree with the conversion', () => {
const seed = () => _setTrackedMilitaryRefreshStateForTest({
icao24,
entity: null,
billboard: {
icon: {
position: Cesium.Cartesian3.fromDegrees(-97.71, 30.21, 10_668),
color: Cesium.Color.WHITE,
show: true,
},
billboardCollection: { show: true, remove() {} },
iconLayer: { show: true, remove() {} },
viewer: { camera: { positionCartographic: null }, scene: {} },
tracked: false,
meta: { callsign: 'RCH451', altitudeFt: 35_000, klass: 'quadjet', type: 'C-17A', onGround: false },