Delete the billboard and model mirrors; models become layer-held records

Aircraft draw from GPU icon sets, so the billboard mirror, the billboard
treatment and the aircraft visual-state module had no callers left. 3D models
are now records the layer holds under the contact's id (modelRecord.js):
show and placement are written through showModel/placeModel and read back
from the record; renderer-measured values stay on record.model.

The tracked-model click check only matches when a tracked model exists, so
an id-only pick is never mistaken for a click on the tracked plane.
This commit is contained in:
Sameh Khamis committed 2026-11-03 22:36:27 -08:00
1 parent c9f1fcd425
commit 83ec9473b6
35 files changed
+391 -788

No files matched your search

+16 -16
View File
@@ -889,8 +889,8 @@ test('Contacts activation adopts the production military tracked-subject descrip
_setTrackedMilitaryRefreshStateForTest({
icao24: id,
entity: null,
billboard: { position, show: true },
billboardCollection: { show: true, remove() {} },
icon: { position, show: true },
iconLayer: { show: true, remove() {} },
viewer: sourceViewer,
meta: {
callsign: 'RCH451 ',
@@ -971,8 +971,8 @@ test('Contacts activation adopts the production military tracked-subject descrip
_setTrackedMilitaryRefreshStateForTest({
icao24: id,
entity: null,
billboard: { position, show: true },
billboardCollection: { show: true, remove() {} },
icon: { position, show: true },
iconLayer: { show: true, remove() {} },
viewer: sourceViewer,
meta: {},
tracked: false,
@@ -998,8 +998,8 @@ test('production military tracked-subject label falls back to registration befor
_setTrackedMilitaryRefreshStateForTest({
icao24: id,
entity: null,
billboard: { position, show: true },
billboardCollection: { show: true, remove() {} },
icon: { position, show: true },
iconLayer: { show: true, remove() {} },
viewer: sourceViewer,
meta: {
callsign: ' ',
@@ -1051,8 +1051,8 @@ test('production military tracked-subject label falls back to registration befor
_setTrackedMilitaryRefreshStateForTest({
icao24: id,
entity: null,
billboard: { position, show: true },
billboardCollection: { show: true, remove() {} },
icon: { position, show: true },
iconLayer: { show: true, remove() {} },
viewer: sourceViewer,
meta: {},
tracked: false,
@@ -1097,8 +1097,8 @@ test('a cached Context subject re-reads its label when enrichment lands after se
_setTrackedFlightRefreshStateForTest({
icao24: id,
entity: null,
billboard: { position, color: Cesium.Color.WHITE, show: true },
billboardCollection: { show: true, remove() {} },
icon: { position, color: Cesium.Color.WHITE, show: true },
iconLayer: { show: true, remove() {} },
viewer: sourceViewer,
meta,
});
@@ -1185,8 +1185,8 @@ test('a cached Context subject re-reads its label when enrichment lands after se
_setTrackedFlightRefreshStateForTest({
icao24: id,
entity: null,
billboard: { position, show: true },
billboardCollection: { show: false, remove() {} },
icon: { position, show: true },
iconLayer: { show: false, remove() {} },
viewer: sourceViewer,
meta: {},
tracked: false,
@@ -1207,8 +1207,8 @@ test('Contacts activation adopts the production civilian tracked-subject descrip
_setTrackedFlightRefreshStateForTest({
icao24: id,
entity: null,
billboard: { position, show: true },
billboardCollection: { show: true, remove() {} },
icon: { position, show: true },
iconLayer: { show: true, remove() {} },
viewer: sourceViewer,
meta: {
callsign: 'DAL123 ',
@@ -1296,8 +1296,8 @@ test('Contacts activation adopts the production civilian tracked-subject descrip
_setTrackedFlightRefreshStateForTest({
icao24: id,
entity: null,
billboard: { position, show: true },
billboardCollection: { show: true, remove() {} },
icon: { position, show: true },
iconLayer: { show: true, remove() {} },
viewer: sourceViewer,
meta: {},
tracked: false,