mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 16:22:20 +00:00
refactor(credits): use the globe engine
Map credits (maps/credits.js) are shown through a credits capability (engine.credits.addStatic) instead of the scene's credit display; the shared map scene takes the engine's credits, so the Cesium engine's maps and its credits part share one owner. Data credits (registerDataCredits, registerDynamicCredit, show/hideOsmCredit) take the globe engine and keep accepting a viewer from layers that still hold one; the scene registers the data credits on its engine. The Cesium credits part reads Viewer.creditDisplay, else the scene frame state display it aliases.
This commit is contained in:
1 parent
be56144d75
commit
83c13f330d
11 files changed
+169
-59
No files matched your search
@@ -63,6 +63,7 @@ const dispose = (value) => {
|
||||
* tilesetRef?: { current: object | null } | (() => object | null),
|
||||
* requestRender?: (reason: string) => void,
|
||||
* createImageryLayer?: (provider: object) => object,
|
||||
* credits?: object,
|
||||
* loadPhotorealTileset?: (credentials: object) => Promise<{ tileset: object | null, errors: Error[] }>,
|
||||
* }} [options] `tilesetRef` names the startup Google tileset the app added.
|
||||
* @returns {{ maps: object, destroy: () => void }}
|
||||
@@ -73,12 +74,16 @@ export function createCesiumMaps(
|
||||
tilesetRef = null,
|
||||
requestRender = () => viewer.scene.requestRender?.(),
|
||||
createImageryLayer = (provider) => new Cesium.ImageryLayer(provider),
|
||||
credits,
|
||||
loadPhotorealTileset = (credentials) =>
|
||||
loadPhotorealisticTileset(Cesium, credentials),
|
||||
} = {},
|
||||
) {
|
||||
const abort = new AbortController();
|
||||
const mapScene = createMapScene(viewer, { createImageryLayer });
|
||||
const mapScene = createMapScene(viewer, {
|
||||
createImageryLayer,
|
||||
...(credits && { credits }),
|
||||
});
|
||||
const providers = new Map();
|
||||
let ownedTileset = null;
|
||||
let shownTileset = null;
|
||||
|
||||
Reference in new issue
Block a user