From 811eb7835d2fccb1a30f2fefa333d1f2d25a298b Mon Sep 17 00:00:00 2001
From: Said Turksever <asturksever@gmail.com>
Date: Wed, 28 Oct 2026 14:08:49 +0000
Subject: [PATCH] test(director): cover observer failures in session activate
 and clear

---
 .../interactions/interactions.test.mjs        | 31 +++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/src/director/interactions/interactions.test.mjs b/src/director/interactions/interactions.test.mjs
index 496616516..6c13cecef 100644
--- a/src/director/interactions/interactions.test.mjs
+++ b/src/director/interactions/interactions.test.mjs
@@ -233,6 +233,37 @@ test('a throwing changed observer does not break session dispatch, activation, o
   }
 });
 
+test('an observer that always throws cannot stop activate or clear', () => {
+  const warnings = [];
+  const origWarn = console.warn;
+  console.warn = (...args) => warnings.push(args);
+  try {
+    const session = createInteractionSession({
+      execute: () => true,
+      changed: () => {
+        throw new Error('observer failed');
+      },
+    });
+    session.activate([{ id: 'a' }, { id: 'b' }]);
+    assert.deepEqual(session.getState(), {
+      active: true,
+      busy: false,
+      selected: null,
+      count: 2,
+    });
+    session.clear();
+    assert.deepEqual(session.getState(), {
+      active: false,
+      busy: false,
+      selected: null,
+      count: 0,
+    });
+    assert.equal(warnings.length, 3);
+  } finally {
+    console.warn = origWarn;
+  }
+});
+
 test('settled pack shots cannot take the same-shot seek shortcut after Stop released geometry', async () => {
   const { SceneDirector } = await import('../../scenes/director.js');
   const shot = { id: 'shot', dataPackIds: ['pack'] };