From 805c9b5ccda381573a206639cbf4776b7cb345ab Mon Sep 17 00:00:00 2001 From: Sameh Khamis Date: Sat, 14 Nov 2026 01:47:20 -0800 Subject: [PATCH] fix(voice): point-and-ask over a Street Level coverage line names its sequence again The coverage lines were one primitive per sequence, picked as the sequence's id. Drawn in parts, a part after the first carries its own #n id, which point-and-ask passed on. A hit whose item names the id its parts pick as (meta.pick) resolves as that id, as the line's click already does. --- src/data/pickedContext.js | 6 +++++- src/data/pickedContext.test.mjs | 10 ++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/src/data/pickedContext.js b/src/data/pickedContext.js index 82a3e4f77..8957c5a24 100644 --- a/src/data/pickedContext.js +++ b/src/data/pickedContext.js @@ -97,7 +97,11 @@ export function resolvePickedContext(picked, { dataManager = null } = {}) { const record = contextCarrierRecord(picked, dataManager); if (record) return fromRecord(record); - const pickId = resolvePickId(picked); + // An item drawn in parts names the id its parts pick as (`meta.pick`: + // a Street Level sequence), as the one primitive they were picked as. + const pickId = + (typeof picked.meta?.pick === 'string' && picked.meta.pick) || + resolvePickId(picked); if (!pickId) return null; const layerId = findPickOwner(pickId); if (!layerId || IGNORED_OWNERS.has(layerId)) return null; diff --git a/src/data/pickedContext.test.mjs b/src/data/pickedContext.test.mjs index 5ca2becb4..4b452e0ca 100644 --- a/src/data/pickedContext.test.mjs +++ b/src/data/pickedContext.test.mjs @@ -76,6 +76,16 @@ test('something drawn outside the draw port resolves through its pick owner', () unregisterPickOwner('flights'); }); +test('a part of an item drawn in parts resolves as the id its parts pick as', () => { + registerPickOwner('flights', (id) => String(id).startsWith('seq:')); + const out = resolvePickedContext( + { set: 'lines:1', id: 'seq:42#2', meta: { pick: 'seq:42' }, surface: false }, + { dataManager: manager() }, + ); + assert.equal(out?.id, 'seq:42', 'never the part’s own #n id'); + unregisterPickOwner('flights'); +}); + test('disabled layers, trails and empty picks never resolve', () => { registerPickOwner('military', (id) => id === 'm1'); const hit = (id) => ({ set: 'x:1', id, surface: false });