fix(maps): settle failed recovery and update registry QA

scripts/package-boundaries.json

@@ -10,47 +10,27 @@
       "src/data/localGeojsonCore.js",
       "src/data/localGeojsonLod.js"
     ],
-    "external": [
+    "external": ["cesium"]
-      "cesium"
-    ]
   },
   "application": {
-    "exports": [
+    "exports": ["./application"],
-      "./application"
+    "modules": ["src/app/application.js"],
-    ],
-    "modules": [
-      "src/app/application.js"
-    ],
     "external": []
   },
   "viewer": {
-    "exports": [
+    "exports": ["./application/viewer"],
-      "./application/viewer"
+    "modules": ["src/app/viewer.js"],
-    ],
+    "external": ["cesium"]
-    "modules": [
-      "src/app/viewer.js"
-    ],
-    "external": [
-      "cesium"
-    ]
   },
   "vite-build": {
     "runtime": "node",
-    "exports": [
+    "exports": ["./build/vite"],
-      "./build/vite"
+    "modules": ["build/vite.js"],
-    ],
+    "external": ["vite-plugin-cesium"]
-    "modules": [
-      "build/vite.js"
-    ],
-    "external": [
-      "vite-plugin-cesium"
-    ]
   },
   "live-providers": {
     "runtime": "node",
-    "exports": [
+    "exports": ["./server/providers/live"],
-      "./server/providers/live"
-    ],
     "modules": [
       "server/providers/live.js",
       "server/providers/common/http.js",
@@ -65,24 +45,16 @@
       "src/data/aisStreamAdapter.js",
       "src/data/aisWatchdog.js"
     ],
-    "external": [
+    "external": ["ws"]
-      "ws"
-    ]
   },
   "adsb-lol-source": {
-    "exports": [
+    "exports": ["./sources/adsb-lol"],
-      "./sources/adsb-lol"
+    "modules": ["src/data/adsbLolFallback.js"],
-    ],
-    "modules": [
-      "src/data/adsbLolFallback.js"
-    ],
     "external": []
   },
   "place-providers": {
     "runtime": "node",
-    "exports": [
+    "exports": ["./server/providers/places"],
-      "./server/providers/places"
-    ],
     "modules": [
       "server/providers/places.js",
       "server/providers/places/google.js",
@@ -97,19 +69,13 @@
     "external": []
   },
   "place-payloads": {
-    "exports": [
+    "exports": ["./sources/places"],
-      "./sources/places"
+    "modules": ["src/data/placeProviderPayloads.js"],
-    ],
-    "modules": [
-      "src/data/placeProviderPayloads.js"
-    ],
     "external": []
   },
   "space-providers": {
     "runtime": "node",
-    "exports": [
+    "exports": ["./server/providers/space"],
-      "./server/providers/space"
-    ],
     "modules": [
       "server/providers/space.js",
       "server/providers/space/celestrak.js",
@@ -120,19 +86,13 @@
     "external": []
   },
   "space-requests": {
-    "exports": [
+    "exports": ["./sources/space"],
-      "./sources/space"
+    "modules": ["src/data/spaceProviderRequests.js"],
-    ],
-    "modules": [
-      "src/data/spaceProviderRequests.js"
-    ],
     "external": []
   },
   "terrain-provider": {
     "runtime": "node",
-    "exports": [
+    "exports": ["./server/providers/terrain"],
-      "./server/providers/terrain"
-    ],
     "modules": [
       "server/providers/terrain.js",
       "src/data/terrainHeightsProxy.js"
@@ -140,50 +100,30 @@
     "external": []
   },
   "terrain-source": {
-    "exports": [
+    "exports": ["./sources/terrain"],
-      "./sources/terrain"
+    "modules": ["src/data/terrainHeightsProxy.js"],
-    ],
-    "modules": [
-      "src/data/terrainHeightsProxy.js"
-    ],
     "external": []
   },
   "traffic-provider": {
     "runtime": "node",
-    "exports": [
+    "exports": ["./server/providers/traffic"],
-      "./server/providers/traffic"
+    "modules": ["server/providers/traffic.js", "src/data/tomtomTiles.js"],
-    ],
-    "modules": [
-      "server/providers/traffic.js",
-      "src/data/tomtomTiles.js"
-    ],
     "external": []
   },
   "traffic-source": {
-    "exports": [
+    "exports": ["./sources/traffic"],
-      "./sources/traffic"
+    "modules": ["src/data/tomtomTiles.js"],
-    ],
-    "modules": [
-      "src/data/tomtomTiles.js"
-    ],
     "external": []
   },
   "firms-provider": {
     "runtime": "node",
-    "exports": [
+    "exports": ["./server/providers/firms"],
-      "./server/providers/firms"
+    "modules": ["server/providers/firms.js", "src/data/firmsCsv.js"],
-    ],
-    "modules": [
-      "server/providers/firms.js",
-      "src/data/firmsCsv.js"
-    ],
     "external": []
   },
   "gbfs-provider": {
     "runtime": "node",
-    "exports": [
+    "exports": ["./server/providers/gbfs"],
-      "./server/providers/gbfs"
-    ],
     "modules": [
       "server/providers/gbfs.js",
       "server/providers/common/http.js",
@@ -192,19 +132,13 @@
     "external": []
   },
   "gbfs-source": {
-    "exports": [
+    "exports": ["./sources/gbfs"],
-      "./sources/gbfs"
+    "modules": ["src/data/gbfsSource.js"],
-    ],
-    "modules": [
-      "src/data/gbfsSource.js"
-    ],
     "external": []
   },
   "cctv-provider": {
     "runtime": "node",
-    "exports": [
+    "exports": ["./server/providers/cctv"],
-      "./server/providers/cctv"
-    ],
     "modules": [
       "server/providers/cctv.js",
       "server/providers/cctv/catalog.js",
@@ -221,9 +155,7 @@
   },
   "radio-provider": {
     "runtime": "node",
-    "exports": [
+    "exports": ["./server/providers/radio"],
-      "./server/providers/radio"
-    ],
     "modules": [
       "server/providers/radio.js",
       "server/providers/radio/catalog.js",
@@ -237,9 +169,7 @@
   },
   "overpass-provider": {
     "runtime": "node",
-    "exports": [
+    "exports": ["./server/providers/overpass"],
-      "./server/providers/overpass"
-    ],
     "modules": [
       "server/providers/common/geo.js",
       "server/providers/common/http.js",
@@ -258,9 +188,7 @@
   },
   "military-installations-provider": {
     "runtime": "node",
-    "exports": [
+    "exports": ["./server/providers/military-installations"],
-      "./server/providers/military-installations"
-    ],
     "modules": [
       "server/providers/common/http.js",
       "server/providers/common/query.js",
@@ -277,9 +205,7 @@
   },
   "regional-provider": {
     "runtime": "node",
-    "exports": [
+    "exports": ["./server/providers/regional"],
-      "./server/providers/regional"
-    ],
     "modules": [
       "server/providers/common/http.js",
       "server/providers/common/query.js",
@@ -298,9 +224,7 @@
   },
   "openai-provider": {
     "runtime": "node",
-    "exports": [
+    "exports": ["./server/providers/openai"],
-      "./server/providers/openai"
-    ],
     "modules": [
       "server/providers/common/rate-limit.js",
       "server/providers/common/request.js",
@@ -320,9 +244,7 @@
   },
   "standalone-key-setup": {
     "runtime": "node",
-    "exports": [
+    "exports": ["./server/standalone/key-setup"],
-      "./server/standalone/key-setup"
-    ],
     "modules": [
       "scripts/pinokio-environment.mjs",
       "server/providers/common/source-root.js",
@@ -333,9 +255,7 @@
     "external": []
   },
   "place-search": {
-    "exports": [
+    "exports": ["./search"],
-      "./search"
-    ],
     "modules": [
       "src/search/index.js",
       "src/search/placeSearch.js",
@@ -345,27 +265,17 @@
     "external": []
   },
   "panel-disclosure": {
-    "exports": [
+    "exports": ["./ui/panels"],
-      "./ui/panels"
+    "modules": ["src/ui/panelDisclosure.js"],
-    ],
-    "modules": [
-      "src/ui/panelDisclosure.js"
-    ],
     "external": []
   },
   "surface-keyboard": {
-    "exports": [
+    "exports": ["./ui/surfaces"],
-      "./ui/surfaces"
+    "modules": ["src/ui/surfaceKeyboard.js"],
-    ],
-    "modules": [
-      "src/ui/surfaceKeyboard.js"
-    ],
     "external": []
   },
   "panel-rail-layout": {
-    "exports": [
+    "exports": ["./ui/layout"],
-      "./ui/layout"
-    ],
     "modules": [
       "src/ui/panelRails.js",
       "src/ui/leftPanelRail.js",
@@ -377,9 +287,7 @@
     "external": []
   },
   "visual-input": {
-    "exports": [
+    "exports": ["./ui/input"],
-      "./ui/input"
-    ],
     "modules": [
       "src/ui/visualInput.js",
       "src/ui/applicationShortcuts.js",
@@ -388,19 +296,12 @@
     "external": []
   },
   "display-controls": {
-    "exports": [
+    "exports": ["./ui/display"],
-      "./ui/display"
+    "modules": ["src/ui/displayControls.js"],
-    ],
-    "modules": [
-      "src/ui/displayControls.js"
-    ],
     "external": []
   },
   "visual-effects": {
-    "exports": [
+    "exports": ["./ui/effects", "./ui/effects/bloom"],
-      "./ui/effects",
-      "./ui/effects/bloom"
-    ],
     "modules": [
       "src/ui/effects.js",
       "src/ui/visualEffects.js",
@@ -413,14 +314,10 @@
       "src/styles/noir.js",
       "src/styles/snow.js"
     ],
-    "external": [
+    "external": ["cesium"]
-      "cesium"
-    ]
   },
   "map-source-controls": {
-    "exports": [
+    "exports": ["./ui/maps"],
-      "./ui/maps"
-    ],
     "modules": [
       "src/ui/mapSource.js",
       "src/ui/mapSourceControls.js",
@@ -430,10 +327,7 @@
     "external": []
   },
   "layer-panel": {
-    "exports": [
+    "exports": ["./ui/layers", "./ui/layers/feedback"],
-      "./ui/layers",
-      "./ui/layers/feedback"
-    ],
     "modules": [
       "src/ui/layers.js",
       "src/ui/layerPanel.js",
@@ -444,9 +338,7 @@
     "external": []
   },
   "location-controls": {
-    "exports": [
+    "exports": ["./ui/location"],
-      "./ui/location"
-    ],
     "modules": [
       "src/ui/location.js",
       "src/ui/locationControls.js",
@@ -457,9 +349,7 @@
     "external": []
   },
   "radio-controls": {
-    "exports": [
+    "exports": ["./ui/radio"],
-      "./ui/radio"
-    ],
     "modules": [
       "src/ui/radio.js",
       "src/ui/radioControls.js",
@@ -470,9 +360,7 @@
     "external": []
   },
   "cctv-controls": {
-    "exports": [
+    "exports": ["./ui/cctv"],
-      "./ui/cctv"
-    ],
     "modules": [
       "src/ui/cctv.js",
       "src/ui/cctvBindings.js",
@@ -484,10 +372,7 @@
     "external": []
   },
   "context-controls": {
-    "exports": [
+    "exports": ["./ui/context", "./ui/context/policy"],
-      "./ui/context",
-      "./ui/context/policy"
-    ],
     "modules": [
       "src/ui/context.js",
       "src/ui/contextActions.js",
@@ -529,14 +414,10 @@
       "src/cockpitVisionPolicy.js",
       "src/ui/panelRailGeometry.js"
     ],
-    "external": [
+    "external": ["cesium"]
-      "cesium"
-    ]
   },
   "scene-controls": {
-    "exports": [
+    "exports": ["./ui/scenes"],
-      "./ui/scenes"
-    ],
     "modules": [
       "src/ui/scenes.js",
       "src/ui/sceneControls.js",
@@ -545,9 +426,7 @@
     "external": []
   },
   "ui-shell": {
-    "exports": [
+    "exports": ["./ui/shell"],
-      "./ui/shell"
-    ],
     "modules": [
       "src/bloom.js",
       "src/cctvFocusPolicy.js",
@@ -644,14 +523,10 @@
       "src/app/stateChannel.js",
       "src/ui/frameRateMonitor.js"
     ],
-    "external": [
+    "external": ["cesium"]
-      "cesium"
-    ]
   },
   "ui-styles": {
-    "exports": [
+    "exports": ["./ui/styles"],
-      "./ui/styles"
-    ],
     "modules": [
       "src/ui/styles.js",
       "style.css",
@@ -678,9 +553,7 @@
     "external": []
   },
   "scenes": {
-    "exports": [
+    "exports": ["./scenes"],
-      "./scenes"
-    ],
     "modules": [
       "src/scenes/director.js",
       "src/scenes/recipes.js",
@@ -692,14 +565,10 @@
       "src/ui/scenePresentation.js",
       "src/contextModePolicy.js"
     ],
-    "external": [
+    "external": ["cesium"]
-      "cesium"
-    ]
   },
   "live-observations": {
-    "exports": [
+    "exports": ["./sources/live"],
-      "./sources/live"
-    ],
     "modules": [
       "src/sources/live/aircraft.js",
       "src/sources/live/contract.js",
@@ -710,9 +579,7 @@
     "external": []
   },
   "civil-flights": {
-    "exports": [
+    "exports": ["./layers/flights"],
-      "./layers/flights"
-    ],
     "modules": [
       "src/data/aircraftClass.js",
       "src/data/aircraftIcons.js",
@@ -743,14 +610,10 @@
       "src/layers/flights/testing.js",
       "src/layers/flights/tracking.js"
     ],
-    "external": [
+    "external": ["cesium"]
-      "cesium"
-    ]
   },
   "military-flights": {
-    "exports": [
+    "exports": ["./layers/military"],
-      "./layers/military"
-    ],
     "modules": [
       "src/data/aircraftClass.js",
       "src/data/aircraftIcons.js",
@@ -778,14 +641,10 @@
       "src/layers/military/testing.js",
       "src/layers/military/tracking.js"
     ],
-    "external": [
+    "external": ["cesium"]
-      "cesium"
-    ]
   },
   "aircraft-mechanics": {
-    "exports": [
+    "exports": ["./aircraft"],
-      "./aircraft"
-    ],
     "modules": [
       "src/data/aircraftClass.js",
       "src/data/aircraftIcons.js",
@@ -805,14 +664,10 @@
       "src/layers/aircraft/classification.js",
       "src/layers/aircraft/index.js"
     ],
-    "external": [
+    "external": ["cesium"]
-      "cesium"
-    ]
   },
   "vessel-layer": {
-    "exports": [
+    "exports": ["./layers/vessels"],
-      "./layers/vessels"
-    ],
     "modules": [
       "src/layers/vessels/cards.js",
       "src/layers/vessels/evidence.js",
@@ -830,27 +685,19 @@
       "src/data/iconOrientation.js",
       "src/data/vesselLabels.js"
     ],
-    "external": [
+    "external": ["cesium"]
-      "cesium"
-    ]
   },
   "earthquakes": {
-    "exports": [
+    "exports": ["./layers/earthquakes"],
-      "./layers/earthquakes"
-    ],
     "modules": [
       "src/layers/earthquakes/index.js",
       "src/layers/earthquakes/model.js",
       "src/layers/earthquakes/source.js"
     ],
-    "external": [
+    "external": ["cesium"]
-      "cesium"
-    ]
   },
   "fire-layer": {
-    "exports": [
+    "exports": ["./layers/firms"],
-      "./layers/firms"
-    ],
     "modules": [
       "src/data/firmsAdapt.js",
       "src/data/firmsLabels.js",
@@ -869,14 +716,10 @@
       "src/layers/firms/state.js",
       "src/layers/firms/viewport.js"
     ],
-    "external": [
+    "external": ["cesium"]
-      "cesium"
-    ]
   },
   "satellites-layer": {
-    "exports": [
+    "exports": ["./layers/satellites"],
-      "./layers/satellites"
-    ],
     "modules": [
       "src/data/issPass.js",
       "src/data/satelliteClass.js",
@@ -895,15 +738,10 @@
       "src/layers/satellites/testing.js",
       "src/layers/satellites/tracking.js"
     ],
-    "external": [
+    "external": ["cesium", "satellite.js"]
-      "cesium",
-      "satellite.js"
-    ]
   },
   "launches-layer": {
-    "exports": [
+    "exports": ["./layers/launches"],
-      "./layers/launches"
-    ],
     "modules": [
       "src/layers/launches/camera.js",
       "src/layers/launches/controls.js",
@@ -925,14 +763,10 @@
       "src/layers/launches/state.js",
       "src/layers/launches/testing.js"
     ],
-    "external": [
+    "external": ["cesium"]
-      "cesium"
-    ]
   },
   "installations-layer": {
-    "exports": [
+    "exports": ["./layers/installations"],
-      "./layers/installations"
-    ],
     "modules": [
       "src/data/installationFeedback.js",
       "src/data/militaryInstallationData.js",
@@ -948,14 +782,10 @@
       "src/layers/installations/state.js",
       "src/layers/installations/viewport.js"
     ],
-    "external": [
+    "external": ["cesium"]
-      "cesium"
-    ]
   },
   "awareness-layer": {
-    "exports": [
+    "exports": ["./layers/awareness"],
-      "./layers/awareness"
-    ],
     "modules": [
       "src/cockpitMath.js",
       "src/data/iconOrientation.js",
@@ -978,14 +808,10 @@
       "src/layers/awareness/testing.js",
       "src/ui/panelRailGeometry.js"
     ],
-    "external": [
+    "external": ["cesium"]
-      "cesium"
-    ]
   },
   "traffic-layer": {
-    "exports": [
+    "exports": ["./layers/traffic"],
-      "./layers/traffic"
-    ],
     "modules": [
       "src/data/flowMatch.js",
       "src/data/tomtomTiles.js",
@@ -1010,16 +836,10 @@
       "src/layers/traffic/timing.js",
       "src/layers/traffic/viewport.js"
     ],
-    "external": [
+    "external": ["cesium", "pbf", "@mapbox/vector-tile"]
-      "cesium",
-      "pbf",
-      "@mapbox/vector-tile"
-    ]
   },
   "bikeshare-layer": {
-    "exports": [
+    "exports": ["./layers/bikeshare"],
-      "./layers/bikeshare"
-    ],
     "modules": [
       "src/layers/bikeshare/controls.js",
       "src/layers/bikeshare/index.js",
@@ -1036,14 +856,10 @@
       "src/layers/bikeshare/testing.js",
       "src/layers/bikeshare/viewport.js"
     ],
-    "external": [
+    "external": ["cesium"]
-      "cesium"
-    ]
   },
   "cctv-layer": {
-    "exports": [
+    "exports": ["./layers/cctv"],
-      "./layers/cctv"
-    ],
     "modules": [
       "src/data/cctvCards.js",
       "src/data/cctvGizmo.js",
@@ -1076,14 +892,10 @@
       "src/layers/cctv/testing.js",
       "src/overlays/worldOverlayTokens.js"
     ],
-    "external": [
+    "external": ["cesium"]
-      "cesium"
-    ]
   },
   "radio-layer": {
-    "exports": [
+    "exports": ["./layers/radio"],
-      "./layers/radio"
-    ],
     "modules": [
       "src/data/iconOrientation.js",
       "src/data/layerState.js",
@@ -1112,14 +924,10 @@
       "src/layers/radio/volume.js",
       "src/ui/radioTunerModel.js"
     ],
-    "external": [
+    "external": ["cesium"]
-      "cesium"
-    ]
   },
   "submarine-cables": {
-    "exports": [
+    "exports": ["./layers/submarine-cables"],
-      "./layers/submarine-cables"
-    ],
     "modules": [
       "src/layers/submarineCables/geometry.js",
       "src/layers/submarineCables/index.js",
@@ -1132,14 +940,10 @@
       "src/layers/submarineCables/state.js",
       "src/layers/submarineCables/surface.js"
     ],
-    "external": [
+    "external": ["cesium"]
-      "cesium"
-    ]
   },
   "bundled-cables": {
-    "exports": [
+    "exports": ["./sources/bundled-cables"],
-      "./sources/bundled-cables"
-    ],
     "modules": [
       "src/layers/submarineCables/bundledSource.js",
       "src/data/local_data/telegeography_submarine_cables/cable-geo.json",
@@ -1148,10 +952,7 @@
     "external": []
   },
   "geography": {
-    "exports": [
+    "exports": ["./geography/natural-earth", "./geography/neighborhoods"],
-      "./geography/natural-earth",
-      "./geography/neighborhoods"
-    ],
     "modules": [
       "src/data/naturalEarthRegions.js",
       "src/data/neighborhoodPolygons.js",
@@ -1183,8 +984,6 @@
       "src/maps/terrain.js",
       "src/keySetupCore.mjs"
     ],
-    "external": [
+    "external": ["cesium"]
-      "cesium"
-    ]
   }
 }

scripts/qa-map-source-tray.mjs

@@ -714,6 +714,14 @@ try {
       if (controller.googleTileset) controller.googleTileset.show = false;
       controller.googleTileset = null;
       controller.cesiumToken = '';
+      // Availability is now composed in the source registry. Override only
+      // this fixture's choices, as the previous token-field seam did.
+      for (const source of controller._sources.values()) {
+        if (source.descriptor.requiresIon || source.descriptor.kind === 'photoreal') {
+          source.available = false;
+        }
+      }
+      controller._registry.state.hasCesiumIonToken = false;
       await styleManager._setMapStack('osm', { syncShare: false });
       styleManager._initMapStackControl();
     });

src/maps/controller.js

@@ -124,9 +124,15 @@ export class MapSourceController {
         recovery.id !== stack.id &&
         this.isStackAvailable(recovery.id)
       ) {
-        await this._activate(recovery, gen);
+        try {
-        if (gen !== this._switchGen) return this.getState();
+          const activation = await this._activate(recovery, gen);
-        this._activeId = recovery.id;
+          if (gen !== this._switchGen) return this.getState();
+          this._activeId = activation?.effectiveStackId || recovery.id;
+        } catch (recoveryError) {
+          if (gen !== this._switchGen) return this.getState();
+          this._lastError = recoveryError?.message || String(recoveryError);
+          this._onError?.(this._lastError, recovery);
+        }
       }
       if (!silent) this._emitChange('error');
     } finally {

src/maps/controller.test.mjs

@@ -349,3 +349,35 @@ for (const reactivate of [false, true]) {
     assert.equal(destroyed, 1);
   });
 }
+
+test('a failed recovery reports its error and leaves switching settled', async () => {
+  const errors = [];
+  const env = fixture(
+    {
+      defaultId: 'first',
+      recoveryId: 'recovery',
+      sources: [
+        {
+          descriptor: descriptor('first'),
+          imagery: async () => {
+            throw new Error('first offline');
+          },
+        },
+        {
+          descriptor: descriptor('recovery'),
+          imagery: async () => {
+            throw new Error('recovery offline');
+          },
+        },
+      ],
+    },
+    { onError: (message) => errors.push(message) },
+  );
+  const result = await env.controller.setStack('first');
+  assert.equal(result.status, 'ready');
+  assert.equal(result.lastError, 'recovery offline');
+  assert.deepEqual(errors, ['first offline', 'recovery offline']);
+  assert.equal(env.changes.at(-1).status, 'error');
+  assert.equal(env.imagery.length, 0);
+  env.controller.destroy();
+});