mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-15 15:52:21 +00:00
Check that an engine switch draws what a cold start from the share link draws
qa-switch-equals-cold-start switches engines in both directions with each layer on deterministic fixtures, then opens the share link of the same state in a new page on the target engine, and compares the draw ledgers and the probe's view of the layer. It runs as 19 acceptance groups covering all 38 layers. State a layer keeps through a switch but the share link does not carry is declared as sessionState (the directions route, Radio's selected station and audio state, the wind reading, local ADS-B's and OSM Places' local toggles and results); a test checks each declaration against what the layer really retains, so a declaration cannot hide a regression.
This commit is contained in:
German Khokhlov committed
1 parent
59ff0b38a2
commit
7c5ebf4814
12 files changed
+2020
No files matched your search
@@ -0,0 +1,293 @@
|
||||
import { createQaProbe, createSettledState } from '../../src/app/qaProbe.js';
|
||||
import { compareLedgers, drawLedger } from './ledger.mjs';
|
||||
|
||||
// Each group needs four page starts and two picker switches within 300 seconds.
|
||||
export const COLD_START_GROUPS = {
|
||||
aircraft: {
|
||||
layers: ['flights', 'military'],
|
||||
view: [40.2539, -125.5779, 21130],
|
||||
},
|
||||
local: {
|
||||
layers: ['local-adsb', 'local-dams', 'local-datacenters'],
|
||||
view: [41.534, -90.507, 20000],
|
||||
},
|
||||
ground: {
|
||||
layers: [
|
||||
'ais-live-vessels',
|
||||
'air-quality',
|
||||
'gnss-integrity',
|
||||
'fire-perimeters',
|
||||
],
|
||||
view: [43.65, -79.38, 46000],
|
||||
},
|
||||
contacts: {
|
||||
layers: ['military-awareness', 'military-installations'],
|
||||
view: [43.65, -79.38, 46000],
|
||||
},
|
||||
open: {
|
||||
layers: ['drone-airspace', 'osm-places', 'sea-marks', 'ski-pistes'],
|
||||
view: [38.9, -77.03, 30000],
|
||||
},
|
||||
weather: {
|
||||
layers: [
|
||||
'weather-radar',
|
||||
'weather-satellite',
|
||||
'weather-lightning',
|
||||
'weather-cyclones',
|
||||
],
|
||||
view: [43.65, -79.38, 46000],
|
||||
},
|
||||
wind: { layers: ['wind'], view: [43.65, -79.38, 2000000] },
|
||||
ghostmaps: { layers: ['s2-ghostmaps'], view: [43.65, -79.38, 46000] },
|
||||
wildlife: { layers: ['wildlife-sightings'], view: [48.4, -123.1, 200000] },
|
||||
urban: {
|
||||
layers: ['bikeshare', 'transit', 'earthquakes'],
|
||||
view: [42.3554, -71.0605, 6000],
|
||||
},
|
||||
cameras: { layers: ['cctv', 'alpr-cameras'], view: [30.262, -97.7431, 5500] },
|
||||
radio: { layers: ['radio'], view: [30.27, -97.74, 12000] },
|
||||
space: { layers: ['satellites', 'rocket-launches'], view: [5, 5, 18000000] },
|
||||
traffic: { layers: ['traffic'], view: [30.267, -97.744, 1800] },
|
||||
street: { layers: ['street-level'], view: [38.5831, -121.504, 850] },
|
||||
imagery: { layers: ['recent-imagery'], view: [30.27, -97.74, 12000] },
|
||||
nepal: {
|
||||
layers: ['bhote-koshi-locator', 'bhote-koshi-2026'],
|
||||
view: [28.3326, 85.4848, 18000],
|
||||
},
|
||||
cables: {
|
||||
layers: ['telegeography-submarine-cables', 'directions'],
|
||||
view: [55.3241, 10.7995, 25000],
|
||||
},
|
||||
fires: { layers: ['local-firms'], view: [37.77, -122.42, 100000] },
|
||||
};
|
||||
|
||||
/** Change only the engine query of the address written by the application. */
|
||||
export function coldStartUrl(href, engine) {
|
||||
const url = new URL(href);
|
||||
url.searchParams.set('engine', engine);
|
||||
return url.href;
|
||||
}
|
||||
|
||||
// Share addresses round the camera to 0.0001 degrees and whole metres/degrees.
|
||||
// World positions must still match within a metre; projected positions allow
|
||||
// two CSS pixels for that camera quantization. Counts and identities are exact.
|
||||
export function numericTolerance(field) {
|
||||
if (/(?:^|\.)screen\.[xy]$/.test(field)) return 2;
|
||||
if (/(?:^|\.)position\.[xyz]$/.test(field)) return 1;
|
||||
return 1e-6;
|
||||
}
|
||||
|
||||
/** Compare JSON without losing absent fields, nulls or identities in arrays. */
|
||||
export function compareProbe(before, after, { skip = [], field = '' } = {}) {
|
||||
const differences = [];
|
||||
const visit = (left, right, path) => {
|
||||
if (skip.includes(path)) return;
|
||||
if (Object.is(left, right)) return;
|
||||
if (typeof left === 'number' && typeof right === 'number') {
|
||||
const tolerance = /(?:count|capacity|length|id)$/.test(path)
|
||||
? 0
|
||||
: numericTolerance(path);
|
||||
if (
|
||||
Number.isFinite(left) &&
|
||||
Number.isFinite(right) &&
|
||||
Math.abs(left - right) <= tolerance
|
||||
)
|
||||
return;
|
||||
} else if (
|
||||
left &&
|
||||
right &&
|
||||
typeof left === 'object' &&
|
||||
typeof right === 'object' &&
|
||||
Array.isArray(left) === Array.isArray(right)
|
||||
) {
|
||||
if (Array.isArray(left)) {
|
||||
if (left.length !== right.length)
|
||||
visit(left.length, right.length, `${path}.length`);
|
||||
const identified = [...left, ...right].every(
|
||||
(row) => row && typeof row === 'object' && row.id !== undefined,
|
||||
);
|
||||
if (identified) {
|
||||
const a = new Map(left.map((row) => [String(row.id), row]));
|
||||
const b = new Map(right.map((row) => [String(row.id), row]));
|
||||
if (a.size !== left.length || b.size !== right.length)
|
||||
differences.push({
|
||||
field: path,
|
||||
switchValue: left,
|
||||
coldStartValue: right,
|
||||
error: 'duplicate ids',
|
||||
});
|
||||
for (const id of new Set([...a.keys(), ...b.keys()]))
|
||||
visit(a.get(id), b.get(id), `${path}[${JSON.stringify(id)}]`);
|
||||
} else
|
||||
for (let i = 0; i < Math.max(left.length, right.length); i++)
|
||||
visit(left[i], right[i], `${path}[${i}]`);
|
||||
} else
|
||||
for (const key of new Set([
|
||||
...Object.keys(left),
|
||||
...Object.keys(right),
|
||||
]))
|
||||
visit(left[key], right[key], path ? `${path}.${key}` : key);
|
||||
return;
|
||||
}
|
||||
differences.push({
|
||||
field: path,
|
||||
switchValue: left === undefined ? '<absent>' : left,
|
||||
coldStartValue: right === undefined ? '<absent>' : right,
|
||||
});
|
||||
};
|
||||
visit(before, after, field);
|
||||
return differences;
|
||||
}
|
||||
|
||||
/** The production build drops its dev probe; inject the same implementation. */
|
||||
export async function probeSnapshot(page, layers) {
|
||||
const probe = await page.evaluate(`(() => {
|
||||
const plain = (p) => p ? { x: p.x, y: p.y, z: p.z } : null;
|
||||
const createSettledState = ${createSettledState};
|
||||
const probe = (${createQaProbe})(window.__godsEyeView);
|
||||
const layers = ${JSON.stringify(layers)};
|
||||
try {
|
||||
return {
|
||||
layers: Object.fromEntries(layers.map((id) => {
|
||||
const module = window.__godsEyeView.dataManager.layers.get(id).module;
|
||||
const session = id === 'radio'
|
||||
? { selected: module.getUIState().selected, audioState: module.getUIState().audioState }
|
||||
: id === 'wind' ? { reading: module.getRowControls().summary.reading }
|
||||
: id === 'osm-places' ? { results: module.getAnalystRecords(1000000) }
|
||||
: id === 'directions' ? { route: module.getRowControls().list } : {};
|
||||
return [id, {
|
||||
enabled: window.__godsEyeView.dataManager.layers.get(id).enabled,
|
||||
objects: probe.objects(id, 1000000), selected: probe.selected(id),
|
||||
session, sessionState: module.sessionState ?? [],
|
||||
}];
|
||||
})),
|
||||
following: probe.following(), movers: probe.movers(),
|
||||
};
|
||||
} finally { probe.destroy(); }
|
||||
})()`);
|
||||
return { ...probe, ledger: await drawLedger(page) };
|
||||
}
|
||||
|
||||
/** Keep raw samples and declared exclusions beside the complete difference list. */
|
||||
export function compareColdStart(
|
||||
switched,
|
||||
cold,
|
||||
{ direction, owners = {}, allow = [], sessionState = true },
|
||||
) {
|
||||
const differences = [],
|
||||
skipped = [];
|
||||
const add = (layer, family, id, rows) =>
|
||||
differences.push(
|
||||
...rows.map((row) => ({ layer, direction, family, id, ...row })),
|
||||
);
|
||||
const layerOf = (family, id) => owners[`${family}:${id}`] ?? '[page]';
|
||||
const ledger = compareLedgers(switched.ledger, cold.ledger, allow);
|
||||
for (const [side, rows] of [
|
||||
['switch', ledger.onlyBefore],
|
||||
['cold', ledger.onlyAfter],
|
||||
])
|
||||
for (const { family, id } of rows)
|
||||
add(layerOf(family, id), family, id, [
|
||||
{
|
||||
field: 'present',
|
||||
switchValue: side === 'switch',
|
||||
coldStartValue: side === 'cold',
|
||||
},
|
||||
]);
|
||||
for (const { family, id, before, after } of ledger.shown)
|
||||
add(layerOf(family, id), family, id, [
|
||||
{ field: 'shown', switchValue: before, coldStartValue: after },
|
||||
]);
|
||||
for (const row of switched.ledger) {
|
||||
const next = cold.ledger.find(
|
||||
(other) => other.family === row.family && other.id === row.id,
|
||||
);
|
||||
if (next)
|
||||
add(
|
||||
layerOf(row.family, row.id),
|
||||
row.family,
|
||||
row.id,
|
||||
compareProbe(
|
||||
{ kind: row.kind, count: row.count },
|
||||
{ kind: next.kind, count: next.count },
|
||||
),
|
||||
);
|
||||
}
|
||||
for (const layer of new Set([
|
||||
...Object.keys(switched.layers),
|
||||
...Object.keys(cold.layers),
|
||||
])) {
|
||||
const before = switched.layers[layer],
|
||||
after = cold.layers[layer];
|
||||
for (const row of compareProbe(before, after)) {
|
||||
const id = /^objects\[("(?:[^"\\]|\\.)*")\]/.exec(row.field)?.[1];
|
||||
add(layer, 'probe', id ? JSON.parse(id) : layer, [row]);
|
||||
}
|
||||
}
|
||||
add(
|
||||
'[page]',
|
||||
'probe',
|
||||
'following',
|
||||
compareProbe(switched.following, cold.following, { field: 'following' }),
|
||||
);
|
||||
// Keep all mover registry fields, including capacity, beyond the draw ledger.
|
||||
const a = new Map(switched.movers.map((row) => [String(row.id), row]));
|
||||
const b = new Map(cold.movers.map((row) => [String(row.id), row]));
|
||||
for (const id of new Set([...a.keys(), ...b.keys()]))
|
||||
add(
|
||||
layerOf('movers', id),
|
||||
'probe-movers',
|
||||
id,
|
||||
compareProbe(a.get(id), b.get(id)),
|
||||
);
|
||||
return {
|
||||
differences: differences.filter((row) => {
|
||||
const field = sessionState && sessionExclusion(row, switched);
|
||||
if (!field) return true;
|
||||
skipped.push({ ...row, sessionState: field });
|
||||
return false;
|
||||
}),
|
||||
skipped,
|
||||
ledger,
|
||||
};
|
||||
}
|
||||
|
||||
/** Only declared fields and their drawn derivatives can differ from a link. */
|
||||
export function sessionExclusion(row, snapshot) {
|
||||
const declared = snapshot.layers[row.layer]?.sessionState ?? [];
|
||||
for (const field of declared) {
|
||||
if (
|
||||
row.family === 'probe' &&
|
||||
(row.field === `session.${field}` ||
|
||||
row.field.startsWith(`session.${field}.`) ||
|
||||
row.field.startsWith(`session.${field}[`))
|
||||
)
|
||||
return field;
|
||||
// Session-only layers are absent from the link. Their drawing must still
|
||||
// survive the switch; the scenario checks these same rows against S first.
|
||||
if (
|
||||
field === 'enabled' &&
|
||||
(row.family !== 'probe' ||
|
||||
/^(enabled|objects|selected)(\.|\[|$)/.test(row.field))
|
||||
)
|
||||
return field;
|
||||
if (
|
||||
row.layer === 'radio' &&
|
||||
field === 'selected' &&
|
||||
['radio-selected', 'radio-bracket'].includes(row.id)
|
||||
)
|
||||
return field;
|
||||
if (
|
||||
row.layer === 'directions' &&
|
||||
field === 'route' &&
|
||||
[
|
||||
'directions-route',
|
||||
'directions-steps',
|
||||
'directions-markers',
|
||||
'directions-marker-letters',
|
||||
].includes(row.id)
|
||||
)
|
||||
return field;
|
||||
}
|
||||
return null;
|
||||
}
|
||||
Reference in new issue
Block a user