From be9d772b4d53f141656936528cc6f7395d93512d Mon Sep 17 00:00:00 2001 From: Sameh Khamis Date: Thu, 19 Nov 2026 02:29:52 -0800 Subject: [PATCH 1/9] Vue kit: the Omnibar's mic and strip chips are UiButtons and its glyphs UiIcons The mic is a ghost UiButton pressed with the active class, and the suggestion strip's chips are ghost UiButtons that keep their option role and aria-current. The search, row and chip glyphs are UiIcons sized by the Omnibar's own rules. The mic and chat row glyphs stay inline SVG, since no loaded Material symbol draws them. A guard test pins it. Co-authored-by: Manjunath Paparaju --- docs/VUE-MIGRATION.md | 8 +++++++ scripts/format-scope.json | 1 + src/ui/kit/omnibarControls.test.mjs | 34 +++++++++++++++++++++++++++++ src/ui/views/panels/Omnibar.vue | 17 ++++++++------- 4 files changed, 52 insertions(+), 8 deletions(-) create mode 100644 src/ui/kit/omnibarControls.test.mjs diff --git a/docs/VUE-MIGRATION.md b/docs/VUE-MIGRATION.md index b7c030dc10..e67cf663b1 100644 --- a/docs/VUE-MIGRATION.md +++ b/docs/VUE-MIGRATION.md @@ -89,6 +89,14 @@ tilt-map button, whose owners still write their state into the DOM. Core's pressable chips and pills (rail card chips, map sources, cities and places) are `UiButton`s too; `UiChip` is a non-interactive label chip, used by the voice card. +The Omnibar's mic (a pressed toggle with `active`) and its suggestion +strip's chips (options, so `aria-current` rather than `pressed`) are +ghost `UiButton`s, and its search, row and chip glyphs are `UiIcon`s with +`:size="null"`, so its own rules still size them +(`src/ui/kit/omnibarControls.test.mjs` pins it). The mic's and the chat +row's glyphs stay inline SVG, since no Material symbol the page loads +draws them, and its field is its own combobox rather than a +`UiSearchField`. `UiSelect` renders the bare native select (Core's labels sit outside it or come as an `aria-label`) with `v-model`, `options` and `disabled`; options that carry their own attributes come through the slot, a caller's diff --git a/scripts/format-scope.json b/scripts/format-scope.json index 76004da995..d473ffd33f 100644 --- a/scripts/format-scope.json +++ b/scripts/format-scope.json @@ -1343,6 +1343,7 @@ "src/ui/kit/UiDialog.vue", "src/ui/kit/UiDialog.test.mjs", "src/ui/kit/dialogs.test.mjs", + "src/ui/kit/omnibarControls.test.mjs", "src/ui/styles/chip.css", "src/ui/styles/empty-state.css", "src/ui/rail/RailChips.vue", diff --git a/src/ui/kit/omnibarControls.test.mjs b/src/ui/kit/omnibarControls.test.mjs new file mode 100644 index 0000000000..033412d0a0 --- /dev/null +++ b/src/ui/kit/omnibarControls.test.mjs @@ -0,0 +1,34 @@ +// The Omnibar's buttons and Material glyphs are the kit's: its template +// hand-writes no +
@@ -1065,11 +1067,10 @@ watch(
  • - + {{ item.label }} {{ item.hint }} From 7dd27d4ff78ada3c2c630d8fb9df79408b46a257 Mon Sep 17 00:00:00 2001 From: Sameh Khamis Date: Thu, 19 Nov 2026 02:33:39 -0800 Subject: [PATCH 2/9] The Omnibar guard test pins its glyphs' own sizing Co-authored-by: Manjunath Paparaju --- src/ui/kit/omnibarControls.test.mjs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/ui/kit/omnibarControls.test.mjs b/src/ui/kit/omnibarControls.test.mjs index 033412d0a0..ee20355c45 100644 --- a/src/ui/kit/omnibarControls.test.mjs +++ b/src/ui/kit/omnibarControls.test.mjs @@ -20,7 +20,10 @@ test('the Omnibar hand-writes no button; each is a UiButton', () => { test('the Omnibar hand-writes no Material glyph; each is a UiIcon', () => { assert.deepEqual(template.match(/material-symbols-outlined/g) ?? [], []); - assert.equal(template.match(/]*>/g) ?? []; + assert.equal(icons.length, 3); + // Without it the kit writes an 18px size that beats the Omnibar's own rules. + for (const icon of icons) assert.match(icon, /:size="null"/); }); test('the only inline SVG glyphs are the mic and the chat row bubble', () => { From 5301a0af8dbbf30a6294f9bc935edcc43e2d5673 Mon Sep 17 00:00:00 2001 From: Sameh Khamis Date: Thu, 19 Nov 2026 02:45:21 -0800 Subject: [PATCH 3/9] Vue kit: the welcome card's buttons are UiButtons and its glyphs UiIcons SKIP, the three start tiles, BROWSE STORIES, BACK and the main NEXT / ENTER GOD MODE action are ghost UiButtons; the start tiles are pressed toggles, and the others keep aria-disabled so they stay focusable while the card is busy. The tile, tip, Stories and arrow glyphs are UiIcons sized by first-run.css. God mode's preview globe and callouts stay inline SVG drawings. A guard test pins it, the dismiss markup pin allows the kit classes, and the first-run mutation anchors follow the new tile markup. Co-authored-by: Manjunath Paparaju --- docs/VUE-MIGRATION.md | 8 ++++++ scripts/format-scope.json | 1 + scripts/qa-firstrun-mutations.mjs | 8 +++--- src/firstRunExperience.test.mjs | 2 +- src/ui/kit/welcomeControls.test.mjs | 37 +++++++++++++++++++++++++ src/ui/views/WelcomeView.vue | 42 +++++++++++++++-------------- 6 files changed, 73 insertions(+), 25 deletions(-) create mode 100644 src/ui/kit/welcomeControls.test.mjs diff --git a/docs/VUE-MIGRATION.md b/docs/VUE-MIGRATION.md index 35d0deffc9..9dfee07595 100644 --- a/docs/VUE-MIGRATION.md +++ b/docs/VUE-MIGRATION.md @@ -89,6 +89,14 @@ tilt-map button, whose owners still write their state into the DOM. Core's pressable chips and pills (rail card chips, map sources, cities and places) are `UiButton`s too; `UiChip` is a non-interactive label chip, used by the voice card. +The welcome card's buttons (SKIP, the three start tiles, BROWSE STORIES, +BACK and the main NEXT / ENTER GOD MODE action) are ghost `UiButton`s: +the start tiles are pressed toggles, and all but SKIP keep `aria-disabled` +rather than `disabled`, so they stay focusable while the card is busy. Its +tile, tip, Stories and arrow glyphs are `UiIcon`s with `:size="null"`, so +first-run.css still sizes them (`src/ui/kit/welcomeControls.test.mjs` pins +it). God mode's preview globe and callouts stay inline SVG drawings, and +its outbound links stay links. `UiSelect` renders the bare native select (Core's labels sit outside it or come as an `aria-label`) with `v-model`, `options` and `disabled`; options that carry their own attributes come through the slot, a caller's diff --git a/scripts/format-scope.json b/scripts/format-scope.json index 7dc54bc407..abc77b56d7 100644 --- a/scripts/format-scope.json +++ b/scripts/format-scope.json @@ -1343,6 +1343,7 @@ "src/ui/kit/UiDialog.vue", "src/ui/kit/UiDialog.test.mjs", "src/ui/kit/dialogs.test.mjs", + "src/ui/kit/welcomeControls.test.mjs", "src/ui/styles/chip.css", "src/ui/styles/empty-state.css", "src/ui/rail/RailChips.vue", diff --git a/scripts/qa-firstrun-mutations.mjs b/scripts/qa-firstrun-mutations.mjs index 7177daceee..9bce1d3fd6 100644 --- a/scripts/qa-firstrun-mutations.mjs +++ b/scripts/qa-firstrun-mutations.mjs @@ -444,14 +444,14 @@ const MUTATIONS = [ { defect: 'a mission tile is dropped from the menu', file: 'html', - from: ' +

    {{ t(TITLES[step - 1]) }}

    {{ t(TITLES[step - 1]) }}

    @@ -207,22 +209,22 @@ function onSuppress(event) {

    {{ t('Start with') }}

    - - - +
    @@ -230,17 +232,17 @@ function onSuppress(event) {
    • - + {{ t('Turn on layers') }} {{ t('Turn layers on to see flights, ships, cameras, weather and more.') }}
    • - + {{ t('Click anything') }} {{ t('Select a map item to see its details.') }}
    • @@ -248,12 +250,12 @@ function onSuppress(event) {

      {{ t('Go deeper') }}

      @@ -304,10 +306,10 @@ function onSuppress(event) {

      {{ launcher?.status ?? '' }}

      - - + {{ t('BACK') }} + + {{ step < STEPS ? t('NEXT') : t('ENTER GOD MODE') }} +
    From 1393a025b473b1d4ff5757853cc95a638764ece2 Mon Sep 17 00:00:00 2001 From: Sameh Khamis Date: Thu, 19 Nov 2026 02:55:03 -0800 Subject: [PATCH 4/9] Vue kit: the Visual panel's buttons are UiButtons and its glyphs UiIcons HUD, Clean UI, Bloom, Sharpen and Reset to default are ghost UiButtons; HUD, Bloom and Sharpen are pressed toggles with the active class, as Sonar, 3D and Celestial already were. The Scope, Celestial, sky, application-row and Reset glyphs are UiIcons sized by the panel's own rules. The toggles' text glyphs stay plain spans, since they are characters rather than Material symbols. A guard test pins it, and the initial-markup test allows the kit classes beside the toggle's own. The migration notes no longer claim every pressed toggle is a UiButton. Co-authored-by: Manjunath Paparaju --- docs/VUE-MIGRATION.md | 18 ++++++++-- scripts/format-scope.json | 1 + src/ui/displayPanel.test.mjs | 6 +++- src/ui/kit/visualControls.test.mjs | 53 ++++++++++++++++++++++++++++ src/ui/views/panels/DisplayPanel.vue | 31 ++++++++-------- 5 files changed, 90 insertions(+), 19 deletions(-) create mode 100644 src/ui/kit/visualControls.test.mjs diff --git a/docs/VUE-MIGRATION.md b/docs/VUE-MIGRATION.md index 35d0deffc9..b022fea3e4 100644 --- a/docs/VUE-MIGRATION.md +++ b/docs/VUE-MIGRATION.md @@ -83,12 +83,24 @@ segmented group in Core is a `UiSegmented`; the old `segmentedControl.js` adapter is gone. `UiButton` adds `pressedClass`, Core's class on a pressed toggle (most use `active`); its pressed classes toggle through `classList`, so a class other -code adds (a voice highlight) survives a press. Every pressed toggle in the -views is a `UiButton` except Bhote Koshi's cinematic button and the -tilt-map button, whose owners still write their state into the DOM. Core's +code adds (a voice highlight) survives a press. Not every pressed toggle in +the views is one yet: the entity card, the context view, the Layer Finder, +the Stories screens and a few panel buttons still hand-write theirs, and +Bhote Koshi's cinematic button and the tilt-map button have owners that +write their state into the DOM. Core's pressable chips and pills (rail card chips, map sources, cities and places) are `UiButton`s too; `UiChip` is a non-interactive label chip, used by the voice card. +The Visual panel's buttons (its presets and map sources, HUD, Sonar, +Detection, 3D, Clean UI, Celestial, Bloom, Sharpen and Reset to default) are +ghost `UiButton`s. HUD, Sonar, 3D, Celestial, Bloom and Sharpen are +pressed toggles with `active` as their pressed class; Detection sets its own +`active` and `panoptic` classes, and Clean UI is not a pressed toggle (its +owner marks it `active`). The panel's Scope, Celestial, +sky, application-row and Reset glyphs are `UiIcon`s with `:size="null"`, so +the panel's rules still size them (`src/ui/kit/visualControls.test.mjs` pins +it). The toggles' other glyphs (◎ ▣ ✈ □ ✨ 🔍) and the presets' style glyphs +are text characters, not Material symbols, and stay plain spans. `UiSelect` renders the bare native select (Core's labels sit outside it or come as an `aria-label`) with `v-model`, `options` and `disabled`; options that carry their own attributes come through the slot, a caller's diff --git a/scripts/format-scope.json b/scripts/format-scope.json index 7dc54bc407..c4c9e5ce3f 100644 --- a/scripts/format-scope.json +++ b/scripts/format-scope.json @@ -1343,6 +1343,7 @@ "src/ui/kit/UiDialog.vue", "src/ui/kit/UiDialog.test.mjs", "src/ui/kit/dialogs.test.mjs", + "src/ui/kit/visualControls.test.mjs", "src/ui/styles/chip.css", "src/ui/styles/empty-state.css", "src/ui/rail/RailChips.vue", diff --git a/src/ui/displayPanel.test.mjs b/src/ui/displayPanel.test.mjs index 2928b10487..045d8e9504 100644 --- a/src/ui/displayPanel.test.mjs +++ b/src/ui/displayPanel.test.mjs @@ -72,7 +72,11 @@ function settings(store) { test('before VisualSettings renders, the panel shows its initial markup', (t) => { const { $ } = fixture(t); - assert.equal($('bloom-toggle').className, 'pp-toggle-btn'); + // Beside the kit's ui-* classes, the toggle carries only its own. + assert.deepEqual( + [...$('bloom-toggle').classList].filter((name) => !name.startsWith('ui-')), + ['pp-toggle-btn'], + ); assert.equal($('bloom-slider-row').className, 'pp-slider-row'); assert.equal($('bloom-intensity-slider').value, '0'); assert.equal($('bloom-intensity-value').textContent, '0%'); diff --git a/src/ui/kit/visualControls.test.mjs b/src/ui/kit/visualControls.test.mjs new file mode 100644 index 0000000000..026639fc87 --- /dev/null +++ b/src/ui/kit/visualControls.test.mjs @@ -0,0 +1,53 @@ +// The Visual panel's buttons and Material glyphs are the kit's: neither its +// template nor the presets it renders hand-writes a +
    {{ t('Layout') }} @@ -184,7 +185,7 @@ const allocationOptions = computed(() => [
    - + {{ t('Scope') }}
    @@ -198,21 +199,21 @@ const allocationOptions = computed(() => [ {{ pct(scopeOpacity) }}
    - +

    {{ t('Effects') }}

    - + {{ t('Celestial') }}
    - + {{ row.label }}
    @@ -225,7 +226,7 @@ const allocationOptions = computed(() => [
    - +
    {{ pct(view?.bloom.intensity ?? 0) }}
    - +
    {{ pct(view?.sharpen.intensity ?? 49) }}
    - + + {{ t('Reset to default') }} +
    From bd944ecd0448cab731506c493166058489139b49 Mon Sep 17 00:00:00 2001 From: Sameh Khamis Date: Thu, 19 Nov 2026 03:05:09 -0800 Subject: [PATCH 5/9] Vue kit: the entity card's buttons are UiButtons and its glyphs UiIcons The four preview buttons (Photos, Route, 3D, Cockpit view) are pressed toggles with the active class, and Follow is one with its own on class, in place of hand-written aria-pressed. The cockpit entry, Fly to, Ask GEV, the camera preview's bigger-view and More info buttons and the nearby lists' rows are ghost UiButtons. Every Material glyph on the card, in the camera preview and in the nearby lists is a UiIcon sized by the card's own rules. Ask GEV's chat bubble stays inline SVG, since no Material symbol the page loads draws it. A guard test pins it, and the migration notes say so. Co-authored-by: Manjunath Paparaju --- docs/VUE-MIGRATION.md | 9 +++ scripts/format-scope.json | 1 + src/ui/kit/entityCardControls.test.mjs | 84 ++++++++++++++++++++++++++ src/ui/views/panels/CctvPreview.vue | 16 ++--- src/ui/views/panels/EntityCard.vue | 43 +++++++------ src/ui/views/panels/SpotConditions.vue | 38 ++++++------ 6 files changed, 146 insertions(+), 45 deletions(-) create mode 100644 src/ui/kit/entityCardControls.test.mjs diff --git a/docs/VUE-MIGRATION.md b/docs/VUE-MIGRATION.md index a64d55e0c9..30434445d3 100644 --- a/docs/VUE-MIGRATION.md +++ b/docs/VUE-MIGRATION.md @@ -89,6 +89,15 @@ tilt-map button, whose owners still write their state into the DOM. Core's pressable chips and pills (rail card chips, map sources, cities and places) are `UiButton`s too; `UiChip` is a non-interactive label chip, used by the voice card. +The entity card's buttons are ghost `UiButton`s: its four preview buttons +(Photos, Route, 3D, Cockpit view) are pressed toggles with `active`, Follow +is one with `entity-card__action--on`, and the cockpit entry, Fly to and +Ask GEV are plain buttons; so are the camera preview's bigger-view and More +info buttons and the nearby lists' rows (`SpotConditions`, which the +context view shows too). Their glyphs are `UiIcon`s with `:size="null"`, +so entity-card.css and spot-conditions.css still size them +(`src/ui/kit/entityCardControls.test.mjs` pins it). Ask GEV's chat bubble +stays inline SVG, since no Material symbol the page loads draws it. `UiSelect` renders the bare native select (Core's labels sit outside it or come as an `aria-label`) with `v-model`, `options` and `disabled`; options that carry their own attributes come through the slot, a caller's diff --git a/scripts/format-scope.json b/scripts/format-scope.json index 7dc54bc407..c0f72c687c 100644 --- a/scripts/format-scope.json +++ b/scripts/format-scope.json @@ -1343,6 +1343,7 @@ "src/ui/kit/UiDialog.vue", "src/ui/kit/UiDialog.test.mjs", "src/ui/kit/dialogs.test.mjs", + "src/ui/kit/entityCardControls.test.mjs", "src/ui/styles/chip.css", "src/ui/styles/empty-state.css", "src/ui/rail/RailChips.vue", diff --git a/src/ui/kit/entityCardControls.test.mjs b/src/ui/kit/entityCardControls.test.mjs new file mode 100644 index 0000000000..5dd3f24587 --- /dev/null +++ b/src/ui/kit/entityCardControls.test.mjs @@ -0,0 +1,84 @@ +// The entity card's buttons and Material glyphs are the kit's: neither its +// template nor the camera preview and nearby lists it renders hand-writes a +// + + +
    - + + {{ t('More info') }} + diff --git a/src/ui/views/panels/EntityCard.vue b/src/ui/views/panels/EntityCard.vue index 77ae67c486..fd787d97fc 100644 --- a/src/ui/views/panels/EntityCard.vue +++ b/src/ui/views/panels/EntityCard.vue @@ -10,7 +10,9 @@ import AltitudeGraph from './AltitudeGraph.vue'; import { contextNeedle, contextSearchText, matchesContextSearch } from '../../contextSearch.js'; import RouteGlobe from './RouteGlobe.vue'; import CctvPreview from './CctvPreview.vue'; +import UiButton from '../../kit/UiButton.vue'; import UiCloseButton from '../../kit/UiCloseButton.vue'; +import UiIcon from '../../kit/UiIcon.vue'; import { useCctvStore } from '../../stores/cctv.js'; import SpotConditions from './SpotConditions.vue'; import { shownLayerName } from '../../layerNames.js'; @@ -365,10 +367,10 @@ watch(
    - - - - + + + {{ t('3D') }} +
    @@ -379,7 +381,7 @@ watch(
    - +
    {{ factFigure(fact).number }}{{ factFigure(fact).unit }} @@ -391,7 +393,7 @@ watch(
    - +
    {{ kindLine }}

    {{ shownTitle }}

    @@ -406,14 +408,14 @@ watch(
    {{ card.route.from }} {{ card.route.to }}
    @@ -435,7 +437,7 @@ watch( class="entity-card__route-note" :title="t('The scheduled route for this flight number does not match where the plane is; it may be another leg of the same flight.')" > - {{ t('Scheduled · unverified: does not match where the plane is') }} + {{ t('Scheduled · unverified: does not match where the plane is') }}

    @@ -462,20 +464,21 @@ watch(
    - + + {{ card.layerId === 'satellites' ? t('Enter orbital view') : t('Enter Cockpit') }} +
    - - + + {{ t('Fly to') }} + + + {{ store.isFollowing() ? t('Following') : t('Follow') }} +
    - +
    diff --git a/src/ui/views/panels/SpotConditions.vue b/src/ui/views/panels/SpotConditions.vue index 225279625c..9b2b92dce8 100644 --- a/src/ui/views/panels/SpotConditions.vue +++ b/src/ui/views/panels/SpotConditions.vue @@ -5,6 +5,8 @@ import { compassName, hazardsNear, regionalBrief, weatherLook } from '../../spot import { distanceKm } from '../../../data/entityContext.js'; import { CONTEXT_RADIUS_STEPS, contextRadiusKm, setContextRadiusKm } from '../../contextRadius.js'; import { contextNeedle, matchesContextSearch } from '../../contextSearch.js'; +import UiButton from '../../kit/UiButton.vue'; +import UiIcon from '../../kit/UiIcon.vue'; import UiSlider from '../../kit/UiSlider.js'; import { sayWords, useEntityCardStore } from '../../stores/entityCard.js'; import { useOmnibarStore } from '../../stores/omnibar.js'; @@ -265,7 +267,7 @@ const sources = computed(() => {