mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 16:22:20 +00:00
Add layer and map credits through the renderer's credits port
The street-level provider credits, the map source credit, the shared inline OpenStreetMap and OpenMapTiles credits and the ALPR provider credit go through the renderer's credits port instead of Cesium's credit display. Their markup has one link each and is read as the port's plain data; the ALPR credit is built as plain data, which the port escapes. src/maps/credits.js and src/layers/streetLevel/credits.js no longer reach Cesium and leave the allow-list. findCredits finds the port as findCamera finds the camera: a Cesium viewer of a caller's own, with no renderer bound, gets a credits port over its own credit display, so the public entries keep their attribution. A port built that way is released, not disposed, when a renderer binds later, and a credit let go after its viewer is destroyed leaves the display alone. The per-layer data credits and the transit and event credits stay on Cesium's display: their markup carries several links each, which the contract's credit cannot hold.
This commit is contained in:
1 parent
979e2213b9
commit
765a0db094
26 files changed
+418
-142
No files matched your search
+15
-13
@@ -1,22 +1,24 @@
|
||||
import * as Cesium from 'cesium';
|
||||
import { creditFromMarkup } from '../render/creditMarkup.js';
|
||||
import { findCredits } from '../render/rendererOf.js';
|
||||
|
||||
/** Static credits follow the source actually on screen, including fallback. */
|
||||
/**
|
||||
* The on-map credit of the source actually on screen, including fallback,
|
||||
* through the renderer's credits port. A source's credit is markup with one
|
||||
* link, read as the port's plain data.
|
||||
*/
|
||||
export function createMapCredits(viewer) {
|
||||
let active = null;
|
||||
let off = null;
|
||||
let markup = null;
|
||||
return {
|
||||
show(html) {
|
||||
if (html === markup) return;
|
||||
const display = viewer?.scene?.frameState?.creditDisplay;
|
||||
if (!display) return;
|
||||
try {
|
||||
if (active) display.removeStaticCredit(active);
|
||||
active = html ? new Cesium.Credit(html, true) : null;
|
||||
markup = html;
|
||||
if (active) display.addStaticCredit(active);
|
||||
} catch {
|
||||
/* Switching remains usable on older credit displays. */
|
||||
}
|
||||
const credits = findCredits(viewer);
|
||||
if (!credits) return;
|
||||
off?.();
|
||||
off = html
|
||||
? credits.addStatic({ ...creditFromMarkup(html), inline: true })
|
||||
: null;
|
||||
markup = html;
|
||||
},
|
||||
destroy() {
|
||||
this.show(null);
|
||||
|
||||
Reference in new issue
Block a user