From 75e345aa07a2a919815613c81ddb23210936497f Mon Sep 17 00:00:00 2001 From: Sameh Khamis Date: Wed, 18 Nov 2026 22:44:36 -0800 Subject: [PATCH] fix(places): small places stop at 500 km even in tiles that reach past it Co-authored-by: Manjunath Paparaju --- src/data/wikidataCities.js | 9 ++++++++- src/data/wikidataCities.test.mjs | 8 ++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/src/data/wikidataCities.js b/src/data/wikidataCities.js index c36dd89c3a..e106d2bc4c 100644 --- a/src/data/wikidataCities.js +++ b/src/data/wikidataCities.js @@ -339,7 +339,14 @@ export async function placesNear( const found = [ ...cities.filter((city) => city.distanceKm <= radius), ...detail - .flatMap((source) => citiesWithin(source, latitude, longitude, radius)) + .flatMap((source) => + citiesWithin( + source, + latitude, + longitude, + Math.min(radius, PLACE_TILE_KM), + ), + ) .filter((place) => !twinOfCity(place)), ]; const seen = new Set(); diff --git a/src/data/wikidataCities.test.mjs b/src/data/wikidataCities.test.mjs index 6e6f742007..84c5a8c112 100644 --- a/src/data/wikidataCities.test.mjs +++ b/src/data/wikidataCities.test.mjs @@ -315,6 +315,14 @@ test('a lookup asked for the whole globe reads only the tiles near its centre', fetchPack, ); assert.ok(far.some((place) => place.wikidata === 'Q90')); + // Places from the tiles it read stop at 500 km too: Tahoka, Texas + // (Q982084), a town of about 2,500, is 500.6 km away. + assert.ok(!far.some((place) => place.wikidata === 'Q982084')); + assert.ok( + far + .filter((place) => place.distanceKm > PLACE_TILE_KM) + .every((place) => place.population >= 15000), + ); assert.equal( fetched.filter((name) => /^-?\d+_-?\d+\.json$/.test(name)).length, tileReads.length,