From 243e84150c50fa68d30cddd17169c6d9a2a81d18 Mon Sep 17 00:00:00 2001 From: wasif Date: Sat, 17 Oct 2026 19:53:02 +0400 Subject: [PATCH 1/2] docs: list every npm alias for the qa gates CONTRIBUTING.md said "Only a couple (`qa:map-source-tray`, `qa:transit`) have an `npm run` alias". package.json defines five: `qa:map-source-tray`, `qa:panel-resize`, `qa:street-level`, `qa:street-level:fixtures` and `qa:transit`. The two missing names are not incidental -- .github/workflows/ci.yml already invokes `npm run qa:street-level:fixtures` and `npm run qa:panel-resize`, so a contributor reading the guide is told to reach for `node scripts/.mjs` for gates the project itself runs through npm. Verified against package.json scripts and .github/workflows/ci.yml on main (1df2a27). --- CONTRIBUTING.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6d6b968db..01a9ac374 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -54,8 +54,9 @@ head -40 scripts/qa-radio.mjs # what this runnable gate proves and how to run i Runnable gate entrypoints document what they assert and how to invoke them. Most need a dev server; some also need a specific provider key or port. Follow the entrypoint's header rather than assuming every matching file accepts the -same arguments. Only a couple (`qa:map-source-tray`, `qa:transit`) have an -`npm run` alias. +same arguments. Five have an `npm run` alias: `qa:map-source-tray`, +`qa:panel-resize`, `qa:street-level`, `qa:street-level:fixtures` and +`qa:transit`. If you aren't sure which gate covers your change, search `docs/CURRENT-STATE.md` for the feature: it names the gate for many of them, and it's the authoritative From 7828f6903852c370d1d0cf37af56157fdfa9aa74 Mon Sep 17 00:00:00 2001 From: Sameh Khamis Date: Sat, 17 Oct 2026 11:30:38 -0700 Subject: [PATCH 2/2] Name the two QA gates CI runs The CI callout said no qa-*.mjs gate runs in CI; the workflow runs the Street Level fixtures and panel-resize gates against the built preview. --- CONTRIBUTING.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 01a9ac374..ba0d38768 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -64,12 +64,13 @@ runtime reference either way. `scripts/qa-l9-matrix.mjs` aggregates the broader release-candidate checks and selected harnesses; it does not replace the focused gate for the feature you changed. -> **CI does not cover this for you.** The workflow runs the setup policy +> **CI covers only two of these for you.** The workflow runs the setup policy > checks, the formatting and package-boundary checks, the unit suite and the -> production build, plus a Windows onboarding job. It runs neither -> `npm run test:track` nor any `qa-*.mjs` gate — both need a live dev server -> and a browser. Include the applicable local run in your PR's validation -> evidence. +> production build, plus a Windows onboarding job, and against the built preview +> it runs `qa:street-level:fixtures` and `qa:panel-resize`. It does not run +> `npm run test:track` or any other `qa-*.mjs` gate — those need a live dev +> server and a browser. Include the applicable local run in your PR's +> validation evidence. ## Share-link layer tokens