docs(cyclones): document the early-advisory window and pin its bounds

Maintainer follow-up for #741, no runtime change.

- CURRENT-STATE: advisory issue and position times up to and including
  90 minutes ahead of the server clock are accepted because NHC can release
  advisories before their nominal time; 90 minutes is the app's tolerance,
  not an NHC limit. Later, non-canonical and over-12-hour-old times still
  reject the snapshot.
- Tests: pin exact 90-minute acceptance and +1 ms rejection, and exact
  12-hour acceptance and +1 ms rejection, for issuance and lastUpdate
  independently; the early-publication test now asserts
  invalid_cyclone_data.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
Mazeyar Moeini FeizabadiandClaude Opus 5.5 committed 2026-10-16 02:03:16 +02:00
1 parent ef8a98fe0b
commit 6d6ce364c6
2 files changed
+37 -3

No files matched your search

+31 -2
View File
@@ -166,11 +166,40 @@ test('advisories published before their nominal time are accepted, far-future on
// NHC wrote the 03:00Z advisory at 02:34Z.
const early = Date.UTC(2026, 8, 16, 2, 34);
assert.equal(parseCycloneStatus(status(), early)[0].issuedAt, TIME);
assert.throws(() =>
parseCycloneStatus(status(), Date.UTC(2026, 8, 16, 1, 25)),
assert.throws(
() => parseCycloneStatus(status(), Date.UTC(2026, 8, 16, 1, 25)),
/invalid_cyclone_data/,
);
});
test('advisory and position times are bounded at 90 minutes ahead and 12 hours old', () => {
const MINUTE = 60_000;
const at = (offsetMs) => new Date(NOW + offsetMs).toISOString();
const fields = {
issuedAt: (value) =>
status({
forecastAdvisory: {
advNum: '010',
issuance: value,
url: 'https://www.nhc.noaa.gov/text/MIATCMEP5.shtml',
},
}),
positionAt: (value) => status({ lastUpdate: value }),
};
for (const [field, payload] of Object.entries(fields)) {
for (const offset of [90 * MINUTE, -12 * 60 * MINUTE]) {
const [storm] = parseCycloneStatus(payload(at(offset)), NOW);
assert.equal(storm[field], at(offset), `${field} ${offset}`);
}
for (const offset of [90 * MINUTE + 1, -12 * 60 * MINUTE - 1])
assert.throws(
() => parseCycloneStatus(payload(at(offset)), NOW),
/invalid_cyclone_data/,
`${field} ${offset}`,
);
}
});
test('coherent geometry is retained with holes/dateline while older advisory geometry is omitted', () => {
const storms = parseCycloneStatus(status(), NOW);
const parts = collections();