mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-18 17:22:19 +00:00
i18n: follow-up to the review of the plural and context fixes
- The street-level plan step names its place the way show_street_level reads its arguments: a pointed or numbered thing has no place yet, and "this spot" needs both coordinates. - The view-centre error message is removed: the Street Level layer always gives its own translated text for an empty search, so it never showed. "the view centre" is one exported constant for both voice modules. - The orbital site status uses the word of the FOCUS card in es, fr, it, pt and he, and the Wildlife chip agrees with "avistamientos" and "avvistamenti". - CURRENTLY OVER is the noun for an overflight in de, uk, it and pt, shorter than before, so the place name keeps its room on a phone. - The glossaries record the new terms; I18N.md words two rules more exactly.
This commit is contained in:
1 parent
3953421aad
commit
69fa1bf222
30 files changed
+80
-75
No files matched your search
+26
-25
@@ -7,6 +7,7 @@ import {
|
||||
progressLine,
|
||||
progressStepLabel,
|
||||
spokenLabel,
|
||||
VIEW_CENTRE_LABEL,
|
||||
} from './speech.js';
|
||||
import { presentResult } from './resultDisplay.js';
|
||||
import { countWords, findHedges } from './speechLint.js';
|
||||
@@ -795,35 +796,35 @@ test('the street-level card words "the view centre" and "this spot" as phrases,
|
||||
planStepLabel('show_street_level', { query: 'Alexanderplatz', provider: 'kartaview' }),
|
||||
'KartaView: Alexanderplatz',
|
||||
);
|
||||
const empty = envelope('show_street_level', {
|
||||
ok: false,
|
||||
stage: 'imagery',
|
||||
noImagery: true,
|
||||
atViewCentre: true,
|
||||
label: 'the view centre',
|
||||
providerName: 'Mapillary',
|
||||
error: 'No Mapillary imagery near the view centre',
|
||||
});
|
||||
assert.deepEqual(empty.display.lines, [
|
||||
'Keine Bilder von Mapillary in der Nähe der Bildmitte',
|
||||
]);
|
||||
assert.equal(empty.say, 'No Mapillary imagery near the view centre.');
|
||||
const named = envelope('show_street_level', {
|
||||
ok: false,
|
||||
stage: 'imagery',
|
||||
noImagery: true,
|
||||
label: 'Alexanderplatz',
|
||||
providerName: 'Mapillary',
|
||||
error: 'No Mapillary imagery near Alexanderplatz',
|
||||
});
|
||||
assert.deepEqual(named.display.lines, [
|
||||
'Keine Bilder von Mapillary in der Nähe von Alexanderplatz',
|
||||
]);
|
||||
assert.equal(
|
||||
progressStepLabel('imagery', 'the view centre'),
|
||||
progressStepLabel('imagery', VIEW_CENTRE_LABEL),
|
||||
`${t('Opening imagery')}: die Bildmitte`,
|
||||
);
|
||||
} finally {
|
||||
setLocale('en');
|
||||
}
|
||||
});
|
||||
|
||||
test('the street-level plan step names the place as show_street_level finds it', () => {
|
||||
// A pointed or numbered thing is located later, by deixis.
|
||||
assert.equal(planStepLabel('show_street_level', { referent: 2 }), 'Street Level');
|
||||
assert.equal(
|
||||
planStepLabel('show_street_level', { referent: 2, provider: 'mapillary' }),
|
||||
'Mapillary',
|
||||
);
|
||||
assert.equal(planStepLabel('show_street_level', { query: ' Pointer ' }), 'Street Level');
|
||||
// One coordinate alone is no spot: the action looks at the view centre.
|
||||
assert.equal(
|
||||
planStepLabel('show_street_level', { latitude: 10 }),
|
||||
'Street level at the view centre',
|
||||
);
|
||||
setLocale('de');
|
||||
try {
|
||||
assert.equal(
|
||||
planStepLabel('show_street_level', { referent: 1 }),
|
||||
'Straßenebene',
|
||||
);
|
||||
} finally {
|
||||
setLocale('en');
|
||||
}
|
||||
});
|
||||
Reference in new issue
Block a user