From 67d675c5d9d94c0240625e7df47f89f7183f0a6b Mon Sep 17 00:00:00 2001 From: Sameh Khamis Date: Wed, 18 Nov 2026 13:44:15 -0800 Subject: [PATCH] Keep the Space Missions panel out of the Cockpit and its controls out of teardown From review: - Voice "open the Space Missions panel" under the Cockpit opened it and wrote its preference; it is refused there now, as the layer's own reveal is. On a phone the panel's Missions sheet shows too. - A voice "context off" switches Space Missions off only when no Context mode is on, entering or starting (Contacts), and it also reaches Space Missions while the layer is still starting. - While the layer is going off (its Satellites restore may still run) a roster click, focus or replay does nothing. - Stepping missions from the Data Layers row opens the panel, as a globe pick does. - SHARE-LINK-FORMAT lists panel 11, space-missions-panel (token n). Co-authored-by: Manjunath Paparaju --- docs/SHARE-LINK-FORMAT.md | 1 + src/layers/launches/controls.js | 12 + src/layers/launches/replay.js | 2 + src/layers/launches/selection.js | 7 +- src/voice/gevActions.js | 36 +- src/voice/gevActions.test.mjs | 1529 ++++++++++++++++++++++++------ 6 files changed, 1275 insertions(+), 312 deletions(-) diff --git a/docs/SHARE-LINK-FORMAT.md b/docs/SHARE-LINK-FORMAT.md index 4ebbbc343a..888c3a91e3 100644 --- a/docs/SHARE-LINK-FORMAT.md +++ b/docs/SHARE-LINK-FORMAT.md @@ -282,6 +282,7 @@ reserved: a decoder ignores that entry, as for collapsed 0. | 8 | `global-context-panel` | `g` | collapsed | | 9 | `pp-toggles` | `p` | collapsed | | 10 | `param-slider-panel` | `m` | expanded | +| 11 | `space-missions-panel` | `n` | collapsed | ### Style parameters (field 27) diff --git a/src/layers/launches/controls.js b/src/layers/launches/controls.js index 8e93a7f8b3..955f61bf4c 100644 --- a/src/layers/launches/controls.js +++ b/src/layers/launches/controls.js @@ -16,6 +16,18 @@ export function createControls({ state: layerState, services, parts, source }) { : entries.length - 1 : (index + step + entries.length) % entries.length; parts.panel.selectMissionAt(entries[next].index); + // Stepped from the Data Layers row: the panel opens, as for a globe pick. + const id = layerState._selectedLaunchId; + for (const listener of [...(layerState._globePickListeners || [])]) { + try { + listener(id); + } catch (error) { + console.warn( + '[Data:RocketLaunches] mission step listener failed', + error, + ); + } + } } const methods = { diff --git a/src/layers/launches/replay.js b/src/layers/launches/replay.js index cb5bebc79c..1e879230c3 100644 --- a/src/layers/launches/replay.js +++ b/src/layers/launches/replay.js @@ -336,6 +336,8 @@ export function createReplay({ state: layerState, services, parts, source }) { // The chase camera moves on the frame loop; without one, no replay. const frame = findFrame(layerState._viewer); if (!layerState._viewer || !launch || !track || !frame) return false; + // Not while the layer is going off. + if (!layerState._enabled) return false; if (layerState._replayCameraLaunchId === launchId) { stopMissionReplay(); return false; diff --git a/src/layers/launches/selection.js b/src/layers/launches/selection.js index 407443fb81..0f35eb28dc 100644 --- a/src/layers/launches/selection.js +++ b/src/layers/launches/selection.js @@ -66,6 +66,9 @@ export function createSelection({ } function setSelectedMission(launchId, isolate = true) { + // Once the layer is going off (its Satellites restore may still be + // running) a roster click selects nothing and moves no camera. + if (launchId && !layerState._enabled) return; if (launchId) parts.panel.clearMissionRosterHover(); if ( layerState._replayCameraLaunchId && @@ -118,7 +121,7 @@ export function createSelection({ } function focusMission(launch) { - if (!layerState._viewer || !launch) return; + if (!layerState._viewer || !launch || !layerState._enabled) return; stopMissionZoomAnchor(); parts.rendering.selectLaunchEntity(launch.id); const camera = cameraOf(layerState._viewer); @@ -163,7 +166,7 @@ export function createSelection({ } function focusLaunchSite(launch) { - if (!layerState._viewer || !launch) return; + if (!layerState._viewer || !launch || !layerState._enabled) return; parts.replay.stopMissionReplay(); stopMissionZoomAnchor(); parts.rendering.selectLaunchEntity(launch.id); diff --git a/src/voice/gevActions.js b/src/voice/gevActions.js index 1e90c34c73..8f27790b0e 100644 --- a/src/voice/gevActions.js +++ b/src/voice/gevActions.js @@ -1012,6 +1012,26 @@ export function createGevActionRunner({ error: say, }; } + // The Cockpit owns the screen and hides the right rail: the panel is + // not opened (or its preference written) under it. + if ( + open && + panelId === 'space-missions-panel' && + styleManager?.getCockpitState?.()?.active + ) { + const say = + 'The Space Missions panel opens once you leave the cockpit.'; + return { + ok: false, + action: 'set_panel_open', + panelId, + open, + applied: false, + unavailable: true, + say, + error: say, + }; + } if (!setPanelOpen(styleManager, panelId, open)) { const say = 'There is no panel to open here.'; return { @@ -1023,6 +1043,9 @@ export function createGevActionRunner({ error: say, }; } + // A phone shows the right rail only as tab sheets: show this one's. + if (open && panelId === 'space-missions-panel') + styleManager?.revealPanel?.(panelId); return { ok: true, action: 'set_panel_open', panelId, open }; } @@ -1077,6 +1100,7 @@ export function createGevActionRunner({ !styleManager?.getCockpitState?.()?.active ) { setPanelOpen(styleManager, 'space-missions-panel', true); + styleManager?.revealPanel?.('space-missions-panel'); } return { ...result, @@ -1084,13 +1108,19 @@ export function createGevActionRunner({ mode: 'space-missions', }; } + const contextState = styleManager.getContextModeState?.() || {}; if ( mode === 'off' && - !styleManager.getContextModeState?.()?.mode && - dataManager.isEnabled?.('rocket-launches') + !contextState.mode && + !contextState.changing && + !contextState.entering && + !dataManager.isEffectivelyEnabled?.('military-awareness') && + (dataManager.isEffectivelyEnabled?.('rocket-launches') ?? + dataManager.isEnabled?.('rocket-launches')) ) { // "Exit Space Missions" still arrives as context off. With no Context - // mode on, Space Missions is what is being left: switch its layer off. + // mode on, entering or starting (Contacts), Space Missions, on or + // still starting, is what is being left: switch its layer off. const result = await runGevAction( 'set_layer_visibility', { layerId: 'rocket-launches', enabled: false }, diff --git a/src/voice/gevActions.test.mjs b/src/voice/gevActions.test.mjs index 65224d15ec..d2ccb6deec 100644 --- a/src/voice/gevActions.test.mjs +++ b/src/voice/gevActions.test.mjs @@ -340,7 +340,9 @@ test('opening Stories only admits current requests and can stop its own session' assert.equal(admitted, 1); let finishLoading; - loaded = new Promise((resolve) => { finishLoading = resolve; }); + loaded = new Promise((resolve) => { + finishLoading = resolve; + }); const second = new AbortController(); const pending = runner('open_stories', {}, { signal: second.signal }); assert.equal(admitted, 2); @@ -395,7 +397,11 @@ test('dependent voice navigation waits for the destination viewport to arrive', // Run at once, the tilt's navigation cancelled the flight; with a geocoded // place, the late flight replaced the tilt. function tiltAfterFlightHarness() { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; const harness = createVoiceNavigationHarness(); const { viewer, styleManager } = harness; const flights = []; @@ -403,15 +409,16 @@ function tiltAfterFlightHarness() { harness.order.push('fly'); flights.push(options); }; - styleManager.runImmediateLocationNavigation = (navigate) => ( - styleManager.runImmediateNavigation('location', navigate) - ); + styleManager.runImmediateLocationNavigation = (navigate) => + styleManager.runImmediateNavigation('location', navigate); return { ...harness, flights }; } const settledYet = (promise) => { let settled = false; - promise.then(() => { settled = true; }); + promise.then(() => { + settled = true; + }); return () => settled; }; @@ -447,12 +454,13 @@ test('a tilt waits through a geocoded fly-to search, then for its flight', async viewer, styleManager, dataManager: { layers: new Map(), getAll: () => [] }, - searchNavigation: (_viewer, query, options) => new Promise((resolve) => { - finishSearch = () => { - landFlight = options.onComplete; - resolve({ label: query, navigationMode: 'city-overview' }); - }; - }), + searchNavigation: (_viewer, query, options) => + new Promise((resolve) => { + finishSearch = () => { + landFlight = options.onComplete; + resolve({ label: query, navigationMode: 'city-overview' }); + }; + }), }); const fly = runner('fly_to_location', { query: 'Somewhere Far' }); const tilt = runner('move_camera', { motion: 'tilt', pitchDeg: -45 }); @@ -498,7 +506,10 @@ test('a tilt beside a fly-to that found nothing is not run', async () => { assert.equal(result.ok, false); assert.match(result.error, /did not arrive/); // A later, separate tilt is not held by the failed lookup. - assert.equal((await runner('move_camera', { motion: 'tilt', pitchDeg: -45 })).ok, true); + assert.equal( + (await runner('move_camera', { motion: 'tilt', pitchDeg: -45 })).ok, + true, + ); }); test('a tilt with no voice flight pending runs at once', async () => { @@ -529,11 +540,18 @@ for (const motion of [ styleManager, dataManager: { layers: new Map(), getAll: () => [] }, }); - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); const moved = runner('move_camera', motion); const movedDone = settledYet(moved); await new Promise((resolve) => setTimeout(resolve, 0)); - assert.equal(movedDone(), false, `the ${motion.motion} must wait while the camera flies`); + assert.equal( + movedDone(), + false, + `the ${motion.motion} must wait while the camera flies`, + ); assert.equal( order.slice(order.indexOf('fly')).includes('cancel'), false, @@ -554,23 +572,36 @@ for (const motion of [ viewer, styleManager, dataManager: { layers: new Map(), getAll: () => [] }, - searchNavigation: (_viewer, query, options) => new Promise((resolve) => { - finishSearch = () => { - landFlight = options.onComplete; - resolve({ label: query, navigationMode: 'city-overview' }); - }; - }), + searchNavigation: (_viewer, query, options) => + new Promise((resolve) => { + finishSearch = () => { + landFlight = options.onComplete; + resolve({ label: query, navigationMode: 'city-overview' }); + }; + }), }); const fly = runner('fly_to_location', { query: 'Somewhere Far' }); const moved = runner('move_camera', motion); const movedDone = settledYet(moved); await new Promise((resolve) => setTimeout(resolve, 0)); - assert.equal(movedDone(), false, `the ${motion.motion} must wait for the place lookup`); - assert.equal(getActiveCameraMotion(), null, 'nothing moves before the flight'); + assert.equal( + movedDone(), + false, + `the ${motion.motion} must wait for the place lookup`, + ); + assert.equal( + getActiveCameraMotion(), + null, + 'nothing moves before the flight', + ); finishSearch(); assert.equal((await fly).ok, true); await new Promise((resolve) => setTimeout(resolve, 0)); - assert.equal(movedDone(), false, `the ${motion.motion} must wait for the flight too`); + assert.equal( + movedDone(), + false, + `the ${motion.motion} must wait for the flight too`, + ); landFlight(); assert.equal((await moved).ok, true); assert.equal(getActiveCameraMotion()?.kind, motion.motion); @@ -589,17 +620,17 @@ for (const motion of [ const result = await moved; assert.equal(result.ok, false); assert.equal(result.motion, motion.motion); - assert.match(result.error, new RegExp(`this ${motion.motion} was waiting for did not arrive`)); + assert.match( + result.error, + new RegExp(`this ${motion.motion} was waiting for did not arrive`), + ); assert.equal(getActiveCameraMotion(), null); }); } // Cesium lands a flight even when the user grabs the globe mid-flight, so the // motion queued behind it must not then take the camera back. -for (const motion of [ - { motion: 'orbit' }, - { motion: 'tilt', pitchDeg: -45 }, -]) { +for (const motion of [{ motion: 'orbit' }, { motion: 'tilt', pitchDeg: -45 }]) { test(`${motion.motion} queued behind a fly-to is dropped when the user drags mid-flight`, async () => { const { viewer, styleManager, flights } = tiltAfterFlightHarness(); const canvasListeners = new Map(); @@ -611,7 +642,10 @@ for (const motion of [ styleManager, dataManager: { layers: new Map(), getAll: () => [] }, }); - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); const moved = runner('move_camera', motion); canvasListeners.get('pointerdown')(); flights[0].complete(); @@ -634,9 +668,15 @@ test('a drag during the first of two chained fly-tos still drops the queued moti styleManager, dataManager: { layers: new Map(), getAll: () => [] }, }); - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); canvasListeners.get('touchstart')(); - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); const moved = runner('move_camera', { motion: 'orbit' }); flights.at(-1).complete(); const result = await moved; @@ -657,7 +697,10 @@ test('input before a fly-to does not drop the motion queued behind it', async (t dataManager: { layers: new Map(), getAll: () => [] }, }); canvasListeners.get('wheel')(); - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); const moved = runner('move_camera', { motion: 'orbit' }); flights[0].complete(); assert.equal((await moved).ok, true); @@ -671,10 +714,16 @@ test('a motion follows a later fly-to in the same reply that cancels its flight' styleManager, dataManager: { layers: new Map(), getAll: () => [] }, }); - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); const moved = runner('move_camera', { motion: 'orbit' }); const movedDone = settledYet(moved); - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); // The second flight supersedes the first, as Cesium's flyTo does. flights[0].cancel(); await new Promise((resolve) => setTimeout(resolve, 0)); @@ -693,9 +742,10 @@ test('a motion follows a later fly-to whose start cancels its geocode', async (t viewer, styleManager, dataManager: { layers: new Map(), getAll: () => [] }, - searchNavigation: (_viewer, query, options) => new Promise((resolve) => { - searches.push({ query, options, resolve }); - }), + searchNavigation: (_viewer, query, options) => + new Promise((resolve) => { + searches.push({ query, options, resolve }); + }), }); const flyA = runner('fly_to_location', { query: 'Place A' }); const moved = runner('move_camera', { motion: 'orbit' }); @@ -723,11 +773,15 @@ test('a motion does not run at a flight that lands while the next place is looke viewer, styleManager, dataManager: { layers: new Map(), getAll: () => [] }, - searchNavigation: (_viewer, query, options) => new Promise((resolve) => { - searches.push({ query, options, resolve }); - }), + searchNavigation: (_viewer, query, options) => + new Promise((resolve) => { + searches.push({ query, options, resolve }); + }), }); - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); const moved = runner('move_camera', { motion: 'tilt', pitchDeg: -45 }); const movedDone = settledYet(moved); const flyB = runner('fly_to_location', { query: 'Place B' }); @@ -762,11 +816,15 @@ for (const order of ['lands first', 'not found first']) { viewer, styleManager, dataManager: { layers: new Map(), getAll: () => [] }, - searchNavigation: (_viewer, query, options) => new Promise((resolve) => { - searches.push({ query, options, resolve }); - }), + searchNavigation: (_viewer, query, options) => + new Promise((resolve) => { + searches.push({ query, options, resolve }); + }), }); - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); const moved = runner('move_camera', { motion: 'tilt', pitchDeg: -45 }); const flyB = runner('fly_to_location', { query: 'Nowhere' }); await new Promise((resolve) => setTimeout(resolve, 0)); @@ -780,19 +838,23 @@ for (const order of ['lands first', 'not found first']) { }); } -test('a motion beside a fly-to that finds nothing never acts at an earlier reply\'s flight', async () => { +test("a motion beside a fly-to that finds nothing never acts at an earlier reply's flight", async () => { const { viewer, styleManager, flights } = tiltAfterFlightHarness(); const searches = []; const runner = createGevActionRunner({ viewer, styleManager, dataManager: { layers: new Map(), getAll: () => [] }, - searchNavigation: (_viewer, query, options) => new Promise((resolve) => { - searches.push({ query, options, resolve }); - }), + searchNavigation: (_viewer, query, options) => + new Promise((resolve) => { + searches.push({ query, options, resolve }); + }), }); // Reply 1: "fly to Austin", still flying. - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); // Reply 2: "fly to Nowhere and tilt". const flyB = runner('fly_to_location', { query: 'Nowhere' }); const moved = runner('move_camera', { motion: 'tilt', pitchDeg: -45 }); @@ -816,11 +878,15 @@ for (const first of [0, 1]) { viewer, styleManager, dataManager: { layers: new Map(), getAll: () => [] }, - searchNavigation: (_viewer, query, options) => new Promise((resolve) => { - searches.push({ query, options, resolve }); - }), + searchNavigation: (_viewer, query, options) => + new Promise((resolve) => { + searches.push({ query, options, resolve }); + }), }); - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); const moved = runner('move_camera', { motion: 'orbit' }); const flyB = runner('fly_to_location', { query: 'Nowhere B' }); const flyC = runner('fly_to_location', { query: 'Nowhere C' }); @@ -843,11 +909,15 @@ test('a lookup cancelled by a newer one that finds nothing does not hide the fli viewer, styleManager, dataManager: { layers: new Map(), getAll: () => [] }, - searchNavigation: (_viewer, query, options) => new Promise((resolve) => { - searches.push({ query, options, resolve }); - }), + searchNavigation: (_viewer, query, options) => + new Promise((resolve) => { + searches.push({ query, options, resolve }); + }), }); - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); const moved = runner('move_camera', { motion: 'tilt', pitchDeg: -45 }); const flyB = runner('fly_to_location', { query: 'Place B' }); const flyC = runner('fly_to_location', { query: 'Nowhere C' }); @@ -872,8 +942,14 @@ test('a motion sent after a fly-to that found nothing still waits for the flight dataManager: { layers: new Map(), getAll: () => [] }, searchNavigation: async () => null, }); - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); - assert.equal((await runner('fly_to_location', { query: 'Nowhere' })).ok, false); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); + assert.equal( + (await runner('fly_to_location', { query: 'Nowhere' })).ok, + false, + ); const before = order.length; const moved = runner('move_camera', { motion: 'tilt', pitchDeg: -45 }); const movedDone = settledYet(moved); @@ -893,9 +969,18 @@ test('two lookups that found nothing in a row still leave the motion waiting for dataManager: { layers: new Map(), getAll: () => [] }, searchNavigation: async () => null, }); - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); - assert.equal((await runner('fly_to_location', { query: 'Nowhere' })).ok, false); - assert.equal((await runner('fly_to_location', { query: 'Nowhere 2' })).ok, false); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); + assert.equal( + (await runner('fly_to_location', { query: 'Nowhere' })).ok, + false, + ); + assert.equal( + (await runner('fly_to_location', { query: 'Nowhere 2' })).ok, + false, + ); const before = order.length; const moved = runner('move_camera', { motion: 'orbit' }); const movedDone = settledYet(moved); @@ -915,13 +1000,17 @@ test('a motion acts at a landed flight that a later failed lookup replaced', asy viewer, styleManager, dataManager: { layers: new Map(), getAll: () => [] }, - searchNavigation: (_viewer, query, options) => new Promise((resolve) => { - searches.push({ query, options, resolve }); - }), + searchNavigation: (_viewer, query, options) => + new Promise((resolve) => { + searches.push({ query, options, resolve }); + }), }); const flyA = runner('fly_to_location', { query: 'Slow A' }); const moved = runner('move_camera', { motion: 'orbit' }); - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); flights[0].complete(); const flyC = runner('fly_to_location', { query: 'Nowhere C' }); await new Promise((resolve) => setTimeout(resolve, 0)); @@ -941,18 +1030,25 @@ test('a motion refuses when the flight a later failed lookup replaced was cancel viewer, styleManager, dataManager: { layers: new Map(), getAll: () => [] }, - searchNavigation: (_viewer, query, options) => new Promise((resolve) => { - searches.push({ query, options, resolve }); - }), + searchNavigation: (_viewer, query, options) => + new Promise((resolve) => { + searches.push({ query, options, resolve }); + }), }); - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); const moved = runner('move_camera', { motion: 'orbit' }); const flyA = runner('fly_to_location', { query: 'Slow A' }); await new Promise((resolve) => setTimeout(resolve, 0)); // The motion sees Austin land, then follows A's lookup. flights[0].complete(); await new Promise((resolve) => setTimeout(resolve, 0)); - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); flights[1].cancel(); const flyC = runner('fly_to_location', { query: 'Nowhere C' }); await new Promise((resolve) => setTimeout(resolve, 0)); @@ -965,7 +1061,7 @@ test('a motion refuses when the flight a later failed lookup replaced was cancel assert.match(result.error, /did not arrive/); }); -test('a stale motion does not follow a newer reply\'s fly-to', async () => { +test("a stale motion does not follow a newer reply's fly-to", async () => { const { viewer, styleManager, flights } = tiltAfterFlightHarness(); const runner = createGevActionRunner({ viewer, @@ -973,11 +1069,21 @@ test('a stale motion does not follow a newer reply\'s fly-to', async () => { dataManager: { layers: new Map(), getAll: () => [] }, }); let live = true; - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); - const moved = runner('move_camera', { motion: 'orbit' }, { isCurrent: () => live }); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); + const moved = runner( + 'move_camera', + { motion: 'orbit' }, + { isCurrent: () => live }, + ); // A newer reply takes over and flies elsewhere; this reply is stale. live = false; - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); flights[0].cancel(); // The newer flight never lands here: following it would hold this answer. const result = await Promise.race([ @@ -996,7 +1102,10 @@ test('a motion gives up on a flight that has not landed in 15 s', async (t) => { styleManager, dataManager: { layers: new Map(), getAll: () => [] }, }); - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); t.mock.timers.enable({ apis: ['setTimeout', 'Date'] }); const moved = runner('move_camera', { motion: 'orbit' }); const movedDone = settledYet(moved); @@ -1024,10 +1133,17 @@ test('a motion follows a newer fly-to that lands while its own lookup stalls', a runner('fly_to_location', { query: 'Place A' }); const moved = runner('move_camera', { motion: 'orbit' }); const movedDone = settledYet(moved); - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); t.mock.timers.tick(2_000); await Promise.resolve(); - assert.equal(movedDone(), false, 'the orbit must wait for the newer flight to land'); + assert.equal( + movedDone(), + false, + 'the orbit must wait for the newer flight to land', + ); flights[0].complete(); for (let i = 0; i < 5 && !movedDone(); i += 1) await Promise.resolve(); assert.equal(movedDone(), true, 'the orbit must not wait out A'); @@ -1043,7 +1159,7 @@ test('a motion follows a newer fly-to that lands while its own lookup stalls', a // Gemini runs one reply's calls one after another: by the time "pan left" // runs, "fly to Xyzzyville" has already found nothing, so there is no flight // to wait on, and the pan moved the old view with ok: true. -test('a motion run after its reply\'s fly-to found nothing is not run', async (t) => { +test("a motion run after its reply's fly-to found nothing is not run", async (t) => { t.after(() => interruptCameraMotion('test-cleanup')); const { viewer, styleManager } = tiltAfterFlightHarness(); const runner = createGevActionRunner({ @@ -1053,7 +1169,11 @@ test('a motion run after its reply\'s fly-to found nothing is not run', async (t searchNavigation: async () => null, }); const reply = { turn: 1 }; - const fly = await runner('fly_to_location', { query: 'Xyzzyville' }, { reply }); + const fly = await runner( + 'fly_to_location', + { query: 'Xyzzyville' }, + { reply }, + ); assert.equal(fly.ok, false); const pan = await runner( 'move_camera', @@ -1065,7 +1185,11 @@ test('a motion run after its reply\'s fly-to found nothing is not run', async (t assert.equal(getActiveCameraMotion(), null); // The same holds for OpenAI's reply identity. const group = 'response-1'; - await runner('fly_to_location', { query: 'Xyzzyville' }, { authorityGroup: group }); + await runner( + 'fly_to_location', + { query: 'Xyzzyville' }, + { authorityGroup: group }, + ); const tilt = await runner( 'move_camera', { motion: 'tilt', pitchDeg: -45 }, @@ -1084,7 +1208,11 @@ test('a motion in a later reply runs after a fly-to that found nothing', async ( dataManager: { layers: new Map(), getAll: () => [] }, searchNavigation: async () => null, }); - await runner('fly_to_location', { query: 'Xyzzyville' }, { reply: { turn: 1 } }); + await runner( + 'fly_to_location', + { query: 'Xyzzyville' }, + { reply: { turn: 1 } }, + ); const pan = await runner( 'move_camera', { motion: 'pan', direction: 'left' }, @@ -1104,7 +1232,10 @@ test('a motion runs at a flight of its reply that landed after another lookup fo }); const reply = { turn: 1 }; await runner('fly_to_location', { query: 'Xyzzyville' }, { reply }); - assert.equal((await runner('fly_to_location', { locationId: 'austin' }, { reply })).ok, true); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' }, { reply })).ok, + true, + ); flights[0].complete(); const pan = await runner( 'move_camera', @@ -1123,7 +1254,10 @@ test('a motion queued behind a fly-to yields to a search started during the flig styleManager, dataManager: { layers: new Map(), getAll: () => [] }, }); - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); const moved = runner('move_camera', { motion: 'orbit' }); await new Promise((resolve) => setTimeout(resolve, 0)); const search = panelSearch(); @@ -1143,9 +1277,10 @@ test('a motion behind a geocoded fly-to yields to a search started while it flie viewer, styleManager, dataManager: { layers: new Map(), getAll: () => [] }, - searchNavigation: (_viewer, query, options) => new Promise((resolve) => { - searches.push({ query, options, resolve }); - }), + searchNavigation: (_viewer, query, options) => + new Promise((resolve) => { + searches.push({ query, options, resolve }); + }), }); const fly = runner('fly_to_location', { query: 'Place A' }); const moved = runner('move_camera', { motion: 'orbit' }); @@ -1162,14 +1297,18 @@ test('a motion behind a geocoded fly-to yields to a search started while it flie test('a search before the fly-to does not drop the motion queued behind it', async (t) => { t.after(() => interruptCameraMotion('test-cleanup')); - const { viewer, styleManager, flights, panelSearch } = tiltAfterFlightHarness(); + const { viewer, styleManager, flights, panelSearch } = + tiltAfterFlightHarness(); const runner = createGevActionRunner({ viewer, styleManager, dataManager: { layers: new Map(), getAll: () => [] }, }); panelSearch(); - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); const moved = runner('move_camera', { motion: 'tilt', pitchDeg: -45 }); await new Promise((resolve) => setTimeout(resolve, 0)); flights[0].complete(); @@ -1187,7 +1326,10 @@ test('a fly-to that stops a running motion says so', async (t) => { dataManager: { layers: new Map(), getAll: () => [] }, }); // The model sent the orbit first, so it ran at once. - const orbit = await runner('move_camera', { motion: 'orbit', mode: 'continuous' }); + const orbit = await runner('move_camera', { + motion: 'orbit', + mode: 'continuous', + }); assert.equal(orbit.ok, true); const fly = await runner('fly_to_location', { locationId: 'austin' }); assert.equal(fly.ok, true); @@ -1203,7 +1345,10 @@ test('bad move_camera arguments are refused without waiting for a flight', async styleManager, dataManager: { layers: new Map(), getAll: () => [] }, }); - assert.equal((await runner('fly_to_location', { locationId: 'austin' })).ok, true); + assert.equal( + (await runner('fly_to_location', { locationId: 'austin' })).ok, + true, + ); const moved = runner('move_camera', { motion: 'pan' }); const movedDone = settledYet(moved); await new Promise((resolve) => setTimeout(resolve, 0)); @@ -4832,7 +4977,11 @@ test('set_context_mode space-missions switches the layer on and opens its panel' assert.equal(result.action, 'set_context_mode'); assert.equal(result.mode, 'space-missions'); assert.equal(result.layerId, 'rocket-launches'); - assert.deepEqual(calls.contextModes, [], 'Space Missions is not a Context mode'); + assert.deepEqual( + calls.contextModes, + [], + 'Space Missions is not a Context mode', + ); assert.deepEqual(calls.setEnabled, [['rocket-launches', true, 'voice']]); assert.deepEqual(calls.panels, [ ['space-missions-panel', false, { explicit: true }], @@ -6965,12 +7114,16 @@ function createStreetLevelHarness({ const lookups = []; const origins = []; const revealed = []; - const { viewer, styleManager, currentGeneration, panelSearch } = createVoiceNavigationHarness(); + const { viewer, styleManager, currentGeneration, panelSearch } = + createVoiceNavigationHarness(); // Who owns the camera: the shell's navigation stamps and globe gestures. Object.defineProperty(styleManager, '_navigationGeneration', { get: () => currentGeneration(), }); - viewer.scene.canvas = Object.assign(new EventTarget(), { clientWidth: 1200, clientHeight: 800 }); + viewer.scene.canvas = Object.assign(new EventTarget(), { + clientWidth: 1200, + clientHeight: 800, + }); let completeFlight = null; viewer.camera.lookAt = () => {}; viewer.camera.flyToBoundingSphere = (_sphere, options) => { @@ -7005,7 +7158,11 @@ function createStreetLevelHarness({ configured, keyRequired: keyRequired || keyRejected, keyRejected, - error: keyRejected ? KEY_REJECTED_MESSAGE : keyRequired ? `${names[id]} needs its key` : null, + error: keyRejected + ? KEY_REJECTED_MESSAGE + : keyRequired + ? `${names[id]} needs its key` + : null, groundClick: id === 'google', billed: id === 'google', available: id !== 'google' || stack === 'photoreal', @@ -7013,7 +7170,9 @@ function createStreetLevelHarness({ : null, getUIState: () => ({ providers: ['mapillary', 'google'] - .filter((id) => id !== 'google' || (stack === 'photoreal' && listGoogle)) + .filter( + (id) => id !== 'google' || (stack === 'photoreal' && listGoogle), + ) .map((id) => ({ id, name: id === 'google' ? 'Google Street View' : 'Mapillary', @@ -7030,14 +7189,23 @@ function createStreetLevelHarness({ }), closeViewer() { order.push('close'); - Object.assign(street, { open: false, imageId: null, error: null, nearestOutcome: null }); + Object.assign(street, { + open: false, + imageId: null, + error: null, + nearestOutcome: null, + }); }, armNearest(point, options) { - order.push(`arm:${options.providerIds.join('+')}:${options.radiusM ?? 'default'}:${point ? `${point.lat},${point.lon}` : 'view-centre'}`); + order.push( + `arm:${options.providerIds.join('+')}:${options.radiusM ?? 'default'}:${point ? `${point.lat},${point.lon}` : 'view-centre'}`, + ); }, async openNearest(point, options) { lookups.push({ point, ...options }); - order.push(`open:${options.providerIds.join('+')}:${options.radiusM ?? 'default'}:${options.frame}${point ? '' : ':view-centre'}`); + order.push( + `open:${options.providerIds.join('+')}:${options.radiusM ?? 'default'}:${options.frame}${point ? '' : ':view-centre'}`, + ); if (options.signal?.aborted) return false; if (duringLookup) { const effect = duringLookup(); @@ -7065,7 +7233,8 @@ function createStreetLevelHarness({ } if (!nearest) { closeReplaced(); - street.nearestOutcome = options.aim === 'screen-centre' && sky ? 'sky' : 'empty'; + street.nearestOutcome = + options.aim === 'screen-centre' && sky ? 'sky' : 'empty'; street.error = `No street-level imagery within ${options.radiusM ?? 50} m of ${point ? 'that point' : 'the view centre'}`; return false; } @@ -7082,7 +7251,12 @@ function createStreetLevelHarness({ getLayerParams: () => ({ ...params }), setLayerParams(id, next, { origin }) { origins.push(origin); - order.push(`params:${Object.entries(next).filter(([, on]) => on).map(([k]) => k).join('+')}:${origin}`); + order.push( + `params:${Object.entries(next) + .filter(([, on]) => on) + .map(([k]) => k) + .join('+')}:${origin}`, + ); if (paramsAccepted === false) return false; if (!lightFails) params = { ...params, ...next }; return true; @@ -7097,7 +7271,8 @@ function createStreetLevelHarness({ }, getAll: () => [{ id: 'street-level', name: 'Street Level', enabled }], }; - styleManager.setPanelCollapsed = (id, collapsed) => revealed.push(`collapse:${id}:${collapsed}`); + styleManager.setPanelCollapsed = (id, collapsed) => + revealed.push(`collapse:${id}:${collapsed}`); styleManager.revealPanel = (id) => revealed.push(`reveal:${id}`); const runner = createGevActionRunner({ viewer, styleManager, dataManager }); return { @@ -7121,7 +7296,8 @@ function createStreetLevelHarness({ function withCamera(harness) { harness.dataManager.layers.set('cctv', { module: { - findByQuery: (id) => (id === 'cam-9' ? { latitude: 38.58, longitude: -121.5 } : null), + findByQuery: (id) => + id === 'cam-9' ? { latitude: 38.58, longitude: -121.5 } : null, }, }); const wasEnabled = harness.dataManager.isEnabled; @@ -7130,11 +7306,23 @@ function withCamera(harness) { } test('show_street_level flies first, then switches the map, lights the source, turns the layer on and opens the nearest photo', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; const { runner, order, finishFlight } = createStreetLevelHarness(); - const pending = runner('show_street_level', { latitude: 38.5799, longitude: -121.4937, provider: 'google' }); + const pending = runner('show_street_level', { + latitude: 38.5799, + longitude: -121.4937, + provider: 'google', + }); await new Promise((resolve) => setImmediate(resolve)); - assert.deepEqual(order, ['fly'], 'nothing changes until the place is reached'); + assert.deepEqual( + order, + ['fly'], + 'nothing changes until the place is reached', + ); finishFlight(); const result = await pending; assert.equal(result.ok, true, result.error); @@ -7153,7 +7341,10 @@ test('show_street_level flies first, then switches the map, lights the source, t // A name given with its coordinates is what the answer says. const named = createStreetLevelHarness(); const naming = named.runner('show_street_level', { - query: 'Capitol Mall', latitude: 38.5799, longitude: -121.4937, provider: 'google', + query: 'Capitol Mall', + latitude: 38.5799, + longitude: -121.4937, + provider: 'google', }); await new Promise((resolve) => setImmediate(resolve)); named.finishFlight(); @@ -7161,8 +7352,15 @@ test('show_street_level flies first, then switches the map, lights the source, t }); test('show_street_level on Mapillary keeps the map, searches at the default radius and skips what is already on', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; - const { runner, order } = createStreetLevelHarness({ enabled: true, activeStack: 'osm' }); + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; + const { runner, order } = createStreetLevelHarness({ + enabled: true, + activeStack: 'osm', + }); const result = await runner('show_street_level', { latitude: 38.58, longitude: -121.49, @@ -7170,68 +7368,126 @@ test('show_street_level on Mapillary keeps the map, searches at the default radi fly: false, }); assert.equal(result.ok, true, result.error); - assert.deepEqual(order, ['params:mapillary:voice', 'open:mapillary:default:false']); + assert.deepEqual(order, [ + 'params:mapillary:voice', + 'open:mapillary:default:false', + ]); assert.equal(result.flew, false); }); test('show_street_level without a source uses the one lit in the panel', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; const { runner, order } = createStreetLevelHarness({ activeStack: 'photoreal', lit: { mapillary: false, google: true }, enabled: true, }); - const result = await runner('show_street_level', { latitude: 1, longitude: 2, fly: false }); + const result = await runner('show_street_level', { + latitude: 1, + longitude: 2, + fly: false, + }); assert.equal(result.ok, true, result.error); assert.equal(result.provider, 'google'); assert.deepEqual(order, ['params:google:voice', 'open:google:250:false']); }); test('show_street_level reports each stage it could not pass', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; - const centre = createStreetLevelHarness({ enabled: true, activeStack: 'photoreal' }); + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; + const centre = createStreetLevelHarness({ + enabled: true, + activeStack: 'photoreal', + }); const none = await centre.runner('show_street_level', { provider: 'google' }); assert.equal(none.ok, true, 'no place at all means the view centre'); assert.equal(none.label, 'the view centre'); - assert.deepEqual(centre.order, ['params:google:voice', 'open:google:250:false:view-centre']); + assert.deepEqual(centre.order, [ + 'params:google:voice', + 'open:google:250:false:view-centre', + ]); - const offGlobe = createStreetLevelHarness({ enabled: true, activeStack: 'photoreal' }); - const outOfRange = await offGlobe.runner('show_street_level', { latitude: 95, longitude: 2, provider: 'google' }); + const offGlobe = createStreetLevelHarness({ + enabled: true, + activeStack: 'photoreal', + }); + const outOfRange = await offGlobe.runner('show_street_level', { + latitude: 95, + longitude: 2, + provider: 'google', + }); assert.deepEqual([outOfRange.ok, outOfRange.stage], [false, 'location']); assert.deepEqual(offGlobe.order, [], 'nothing flies, switches or looks up'); const unknown = await createStreetLevelHarness().runner('show_street_level', { - latitude: 1, longitude: 2, provider: 'openstreetcam', fly: false, + latitude: 1, + longitude: 2, + provider: 'openstreetcam', + fly: false, }); assert.deepEqual([unknown.ok, unknown.stage], [false, 'provider']); assert.match(unknown.error, /openstreetcam/); - const keylessHarness = createStreetLevelHarness({ enabled: true, keyRequired: true }); + const keylessHarness = createStreetLevelHarness({ + enabled: true, + keyRequired: true, + }); const keyless = await keylessHarness.runner('show_street_level', { - latitude: 1, longitude: 2, provider: 'google', fly: false, + latitude: 1, + longitude: 2, + provider: 'google', + fly: false, }); assert.deepEqual([keyless.ok, keyless.stage], [false, 'key']); assert.match(keyless.error, /needs its key/); assert.equal(keyless.providerName, 'Google Street View'); - assert.deepEqual(keylessHarness.order, [], 'a keyless source changes nothing: no flight, no map, no switch'); + assert.deepEqual( + keylessHarness.order, + [], + 'a keyless source changes nothing: no flight, no map, no switch', + ); - const refusedSwitch = await createStreetLevelHarness({ enabled: true, paramsAccepted: false }).runner( - 'show_street_level', - { latitude: 1, longitude: 2, provider: 'google', fly: false }, + const refusedSwitch = await createStreetLevelHarness({ + enabled: true, + paramsAccepted: false, + }).runner('show_street_level', { + latitude: 1, + longitude: 2, + provider: 'google', + fly: false, + }); + assert.deepEqual( + [refusedSwitch.ok, refusedSwitch.stage], + [false, 'provider'], ); - assert.deepEqual([refusedSwitch.ok, refusedSwitch.stage], [false, 'provider']); assert.match(refusedSwitch.error, /could not be switched on/); - const empty = await createStreetLevelHarness({ enabled: true, nearest: null }).runner( - 'show_street_level', - { latitude: 1, longitude: 2, provider: 'google', fly: false }, - ); + const empty = await createStreetLevelHarness({ + enabled: true, + nearest: null, + }).runner('show_street_level', { + latitude: 1, + longitude: 2, + provider: 'google', + fly: false, + }); assert.deepEqual([empty.ok, empty.stage], [false, 'imagery']); assert.match(empty.error, /within 250 m/); }); test('show_street_level stops at the map when the source’s map is refused, before touching the panel', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; const { layer, order } = createStreetLevelHarness({ enabled: true }); const reason = 'Google 3D needs GOOGLE_MAPS_API_KEY'; const dataManager = { @@ -7243,21 +7499,47 @@ test('show_street_level stops at the map when the source’s map is refused, bef }; const { viewer, styleManager } = createVoiceNavigationHarness(); styleManager.mapStackController = { getActiveId: () => 'osm' }; - styleManager.setMapStack = async () => ({ ok: false, activeStack: 'osm', error: reason }); + styleManager.setMapStack = async () => ({ + ok: false, + activeStack: 'osm', + error: reason, + }); const runner = createGevActionRunner({ viewer, styleManager, dataManager }); - const result = await runner('show_street_level', { latitude: 1, longitude: 2, provider: 'google', fly: false }); - assert.deepEqual([result.ok, result.stage, result.error], [false, 'map', reason]); - assert.deepEqual(order, [], 'the source is not switched when its map is refused'); + const result = await runner('show_street_level', { + latitude: 1, + longitude: 2, + provider: 'google', + fly: false, + }); + assert.deepEqual( + [result.ok, result.stage, result.error], + [false, 'map', reason], + ); + assert.deepEqual( + order, + [], + 'the source is not switched when its map is refused', + ); }); test('show_street_level opens photos of a numbered item or a pointed spot through its entity', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; const { runner, order, finishFlight } = withCamera( createStreetLevelHarness({ enabled: true, activeStack: 'photoreal' }), ); const pending = runner('show_street_level', { provider: 'google', - entity: { layerId: 'cctv', id: 'cam-9', label: 'Camera 9', lat: 38.58, lon: -121.5 }, + entity: { + layerId: 'cctv', + id: 'cam-9', + label: 'Camera 9', + lat: 38.58, + lon: -121.5, + }, }); await new Promise((resolve) => setImmediate(resolve)); assert.deepEqual(order, ['fly'], 'the entity position is flown to'); @@ -7265,14 +7547,25 @@ test('show_street_level opens photos of a numbered item or a pointed spot throug const result = await pending; assert.equal(result.ok, true, result.error); assert.equal(result.label, 'Camera 9'); - assert.deepEqual(order, ['fly', 'params:google:voice', 'open:google:250:false']); + assert.deepEqual(order, [ + 'fly', + 'params:google:voice', + 'open:google:250:false', + ]); }); test('show_street_level hands the point from a named place, a preset and a curated POI to the lookup', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; const points = []; const make = () => { - const harness = createStreetLevelHarness({ enabled: true, activeStack: 'osm' }); + const harness = createStreetLevelHarness({ + enabled: true, + activeStack: 'osm', + }); const open = harness.layer.openNearest; harness.layer.openNearest = async (point, options) => { points.push(point); @@ -7285,7 +7578,10 @@ test('show_street_level hands the point from a named place, a preset and a curat const viewerFor = () => ({ ...createVoiceNavigationHarness().viewer }); const runnerWithSearch = createGevActionRunner({ viewer: viewerFor(), - styleManager: { mapStackController: { getActiveId: () => 'osm' }, setMapStack: async () => ({ ok: true }) }, + styleManager: { + mapStackController: { getActiveId: () => 'osm' }, + setMapStack: async () => ({ ok: true }), + }, dataManager: { layers: new Map([['street-level', { module: named.layer }]]), isEnabled: () => true, @@ -7295,16 +7591,28 @@ test('show_street_level hands the point from a named place, a preset and a curat }, searchNavigation: async (_viewer, query, options) => { options.onComplete?.(); - return { label: `${query}, CA`, latitude: 38.5799, longitude: -121.4937, navigationMode: 'precise-place', rangeM: 250 }; + return { + label: `${query}, CA`, + latitude: 38.5799, + longitude: -121.4937, + navigationMode: 'precise-place', + rangeM: 250, + }; }, }); - const geocoded = await runnerWithSearch('show_street_level', { query: '10th Street, Sacramento', provider: 'mapillary' }); + const geocoded = await runnerWithSearch('show_street_level', { + query: '10th Street, Sacramento', + provider: 'mapillary', + }); assert.equal(geocoded.ok, true, geocoded.error); assert.equal(geocoded.label, '10th Street, Sacramento, CA'); assert.deepEqual(points.at(-1), { lat: 38.5799, lon: -121.4937 }); // A curated POI and a city preset fly to their hand-tuned poses and report them. for (const [args, expected] of [ - [{ query: 'Golden Gate Bridge', provider: 'mapillary' }, { lat: 37.8199, lon: -122.4783 }], + [ + { query: 'Golden Gate Bridge', provider: 'mapillary' }, + { lat: 37.8199, lon: -122.4783 }, + ], [{ query: 'austin', provider: 'mapillary' }, null], ]) { const harness = make(); @@ -7315,13 +7623,24 @@ test('show_street_level hands the point from a named place, a preset and a curat assert.equal(result.ok, true, `${args.query}: ${result.error}`); const point = points.at(-1); if (expected) assert.deepEqual(point, expected); - else assert.ok(Number.isFinite(point.lat) && Number.isFinite(point.lon), 'a preset flight reports its point'); + else + assert.ok( + Number.isFinite(point.lat) && Number.isFinite(point.lon), + 'a preset flight reports its point', + ); } }); test('show_street_level retires its lookup when the turn is superseded, and says so', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; - const { runner, order, layer } = createStreetLevelHarness({ enabled: true, activeStack: 'photoreal' }); + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; + const { runner, order, layer } = createStreetLevelHarness({ + enabled: true, + activeStack: 'photoreal', + }); const controller = new AbortController(); let currentTurn = true; layer.openNearest = async (_point, options) => { @@ -7335,33 +7654,68 @@ test('show_street_level retires its lookup when the turn is superseded, and says { latitude: 1, longitude: 2, provider: 'google', fly: false }, { signal: controller.signal, isCurrent: () => currentTurn }, ); - assert.deepEqual([result.ok, result.cancelled, result.stage], [false, true, 'imagery']); + assert.deepEqual( + [result.ok, result.cancelled, result.stage], + [false, true, 'imagery'], + ); assert.doesNotMatch(result.error, /No .* imagery/); - assert.ok(order.includes('open:signal:true'), 'the lookup gets the turn signal'); + assert.ok( + order.includes('open:signal:true'), + 'the lookup gets the turn signal', + ); }); test('show_street_level with autoOpen:false arms a billed source and leaves the load to a click; a free source still opens', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; - const armedHarness = createStreetLevelHarness({ enabled: true, activeStack: 'osm' }); + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; + const armedHarness = createStreetLevelHarness({ + enabled: true, + activeStack: 'osm', + }); const armed = await armedHarness.runner('show_street_level', { - latitude: 38.5799, longitude: -121.4937, provider: 'google', fly: false, autoOpen: false, + latitude: 38.5799, + longitude: -121.4937, + provider: 'google', + fly: false, + autoOpen: false, }); assert.equal(armed.ok, true, armed.error); assert.equal(armed.armed, true); assert.equal(armed.imageId, undefined); assert.deepEqual( armedHarness.order, - ['map:photoreal', 'params:google:voice', 'arm:google:250:38.5799,-121.4937'], + [ + 'map:photoreal', + 'params:google:voice', + 'arm:google:250:38.5799,-121.4937', + ], 'map and source are ready, the lookup is armed at the point, nothing is loaded', ); assert.match(armed.say, /^Google Street View is ready at .*press OPEN/); assert.deepEqual( { ...armed, say: undefined, display: undefined }, - { ok: true, action: 'show_street_level', provider: 'google', providerName: 'Google Street View', label: '38.5799, -121.4937', armed: true, flew: false, say: undefined, display: undefined }, + { + ok: true, + action: 'show_street_level', + provider: 'google', + providerName: 'Google Street View', + label: '38.5799, -121.4937', + armed: true, + flew: false, + say: undefined, + display: undefined, + }, ); const free = createStreetLevelHarness({ enabled: true, activeStack: 'osm' }); const opened = await free.runner('show_street_level', { - latitude: 38.5799, longitude: -121.4937, provider: 'mapillary', fly: false, autoOpen: false, + latitude: 38.5799, + longitude: -121.4937, + provider: 'mapillary', + fly: false, + autoOpen: false, }); assert.equal(opened.ok, true, opened.error); assert.equal(opened.armed, undefined); @@ -7369,38 +7723,81 @@ test('show_street_level with autoOpen:false arms a billed source and leaves the }); test('show_street_level tells a failed enable, a delisted source, a key refused mid-lookup and a layer switched off apart', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; const at = { latitude: 1, longitude: 2, provider: 'google', fly: false }; - const notEnabled = await createStreetLevelHarness({ activeStack: 'photoreal', enableResult: false }).runner('show_street_level', at); - assert.deepEqual([notEnabled.ok, notEnabled.stage, notEnabled.cancelled], [false, 'layer', false]); + const notEnabled = await createStreetLevelHarness({ + activeStack: 'photoreal', + enableResult: false, + }).runner('show_street_level', at); + assert.deepEqual( + [notEnabled.ok, notEnabled.stage, notEnabled.cancelled], + [false, 'layer', false], + ); assert.match(notEnabled.say, /Couldn't turn on Street Level/); - const delisted = await createStreetLevelHarness({ enabled: true, activeStack: 'photoreal', listGoogle: false }).runner('show_street_level', at); + const delisted = await createStreetLevelHarness({ + enabled: true, + activeStack: 'photoreal', + listGoogle: false, + }).runner('show_street_level', at); assert.deepEqual([delisted.ok, delisted.stage], [false, 'provider']); assert.equal(delisted.error, 'not on this map'); - const refused = await createStreetLevelHarness({ enabled: true, activeStack: 'photoreal', duringLookup: () => 'key-rejected' }).runner('show_street_level', at); - assert.deepEqual([refused.ok, refused.stage, refused.keyRejected], [false, 'key', true]); + const refused = await createStreetLevelHarness({ + enabled: true, + activeStack: 'photoreal', + duringLookup: () => 'key-rejected', + }).runner('show_street_level', at); + assert.deepEqual( + [refused.ok, refused.stage, refused.keyRejected], + [false, 'key', true], + ); assert.equal(refused.say, 'Google Street View refused its key.'); - const switchedOff = await createStreetLevelHarness({ enabled: true, activeStack: 'photoreal', duringLookup: () => 'layer-off' }).runner('show_street_level', at); - assert.deepEqual([switchedOff.ok, switchedOff.stage, switchedOff.cancelled], [false, 'imagery', true]); - assert.equal(switchedOff.say, undefined, 'a request the user withdrew is not spoken'); + const switchedOff = await createStreetLevelHarness({ + enabled: true, + activeStack: 'photoreal', + duringLookup: () => 'layer-off', + }).runner('show_street_level', at); + assert.deepEqual( + [switchedOff.ok, switchedOff.stage, switchedOff.cancelled], + [false, 'imagery', true], + ); + assert.equal( + switchedOff.say, + undefined, + 'a request the user withdrew is not spoken', + ); // A source whose status call says it is not configured is key-gated even // before its coverage reports a missing key. - const unconfigured = createStreetLevelHarness({ enabled: true, activeStack: 'photoreal', configured: false }); + const unconfigured = createStreetLevelHarness({ + enabled: true, + activeStack: 'photoreal', + configured: false, + }); const gated = await unconfigured.runner('show_street_level', at); assert.deepEqual([gated.ok, gated.stage], [false, 'key']); assert.deepEqual(unconfigured.order, [], 'nothing changed'); }); test('show_street_level reports a geocoder that throws as its location stage', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; const h = createStreetLevelHarness({ enabled: true, activeStack: 'osm' }); const runner = createGevActionRunner({ viewer: createVoiceNavigationHarness().viewer, - styleManager: { mapStackController: { getActiveId: () => 'osm' }, setMapStack: async () => ({ ok: true }) }, + styleManager: { + mapStackController: { getActiveId: () => 'osm' }, + setMapStack: async () => ({ ok: true }), + }, dataManager: h.dataManager, placeSearch: { geocode: async () => { @@ -7408,76 +7805,157 @@ test('show_street_level reports a geocoder that throws as its location stage', a }, }, }); - const result = await runner('show_street_level', { query: 'Capitol Mall', provider: 'mapillary' }); + const result = await runner('show_street_level', { + query: 'Capitol Mall', + provider: 'mapillary', + }); assert.deepEqual([result.ok, result.stage], [false, 'location']); assert.equal(result.error, 'Could not arrive at Capitol Mall'); - assert.deepEqual(h.order.filter((step) => /^(params|open|arm)/.test(step)), [], 'nothing switched or looked up'); + assert.deepEqual( + h.order.filter((step) => /^(params|open|arm)/.test(step)), + [], + 'nothing switched or looked up', + ); }); test('show_street_level reports a flight that lands without a position', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; const hit = createStreetLevelHarness({ enabled: true, activeStack: 'osm' }); // A flight that reports no coordinates cannot be followed by a lookup. const noPoint = createGevActionRunner({ viewer: createVoiceNavigationHarness().viewer, - styleManager: { mapStackController: { getActiveId: () => 'osm' }, setMapStack: async () => ({ ok: true }) }, + styleManager: { + mapStackController: { getActiveId: () => 'osm' }, + setMapStack: async () => ({ ok: true }), + }, dataManager: hit.dataManager, searchNavigation: async (_viewer, query, options) => { options.onComplete?.(); return { label: query, navigationMode: 'city-overview', rangeM: null }; }, }); - const unplaced = await noPoint('show_street_level', { query: 'Somewhere', provider: 'mapillary' }); + const unplaced = await noPoint('show_street_level', { + query: 'Somewhere', + provider: 'mapillary', + }); assert.deepEqual([unplaced.ok, unplaced.stage], [false, 'location']); assert.match(unplaced.error, /no position/); }); test('fly_to_location reports the overview centre for a city framed as a whole, and the first POI for a close view', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; const { viewer, styleManager } = createVoiceNavigationHarness(); viewer.camera.lookAt = () => {}; viewer.camera.flyTo = (options) => options.complete?.(); viewer.camera.flyToBoundingSphere = (_s, options) => options.complete?.(); - styleManager.runImmediateLocationNavigation = (navigate) => styleManager.runImmediateNavigation('location', navigate); - const runner = createGevActionRunner({ viewer, styleManager, dataManager: { layers: new Map(), getAll: () => [] } }); + styleManager.runImmediateLocationNavigation = (navigate) => + styleManager.runImmediateNavigation('location', navigate); + const runner = createGevActionRunner({ + viewer, + styleManager, + dataManager: { layers: new Map(), getAll: () => [] }, + }); const overview = await runner('fly_to_location', { locationId: 'austin' }); assert.equal(overview.ok, true); - assert.ok(Math.abs(overview.latitude - 30.31) < 0.001, String(overview.latitude)); - assert.ok(Math.abs(overview.longitude - -97.75) < 0.001, String(overview.longitude)); - const close = await runner('fly_to_location', { locationId: 'austin', viewMode: 'close' }); + assert.ok( + Math.abs(overview.latitude - 30.31) < 0.001, + String(overview.latitude), + ); + assert.ok( + Math.abs(overview.longitude - -97.75) < 0.001, + String(overview.longitude), + ); + const close = await runner('fly_to_location', { + locationId: 'austin', + viewMode: 'close', + }); assert.deepEqual([close.latitude, close.longitude], [30.2747, -97.7403]); }); test('show_street_level arms the view centre when a billed link names no place, and keeps the flight label when it flew', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; - const centre = createStreetLevelHarness({ enabled: true, activeStack: 'photoreal' }); - const armed = await centre.runner('show_street_level', { provider: 'google', autoOpen: false }); + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; + const centre = createStreetLevelHarness({ + enabled: true, + activeStack: 'photoreal', + }); + const armed = await centre.runner('show_street_level', { + provider: 'google', + autoOpen: false, + }); assert.equal(armed.ok, true, armed.error); assert.equal(armed.armed, true); - assert.deepEqual(centre.order, ['params:google:voice', 'arm:google:250:view-centre'], 'armed at the view centre, nothing opened'); - const flown = createStreetLevelHarness({ enabled: true, activeStack: 'photoreal' }); - const pending = flown.runner('show_street_level', { latitude: 38.5799, longitude: -121.4937, provider: 'google', autoOpen: false }); + assert.deepEqual( + centre.order, + ['params:google:voice', 'arm:google:250:view-centre'], + 'armed at the view centre, nothing opened', + ); + const flown = createStreetLevelHarness({ + enabled: true, + activeStack: 'photoreal', + }); + const pending = flown.runner('show_street_level', { + latitude: 38.5799, + longitude: -121.4937, + provider: 'google', + autoOpen: false, + }); await new Promise((resolve) => setImmediate(resolve)); flown.finishFlight(); const result = await pending; assert.equal(result.armed, true); assert.equal(result.flew, true); assert.equal(result.location, '38.5799, -121.4937'); - assert.ok(!flown.order.some((entry) => entry.startsWith('open:')), 'no load after the flight'); + assert.ok( + !flown.order.some((entry) => entry.startsWith('open:')), + 'no load after the flight', + ); }); test('show_street_level says "refused its key" when Google already refused it, and fails when the source will not light', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; - const refusedHarness = createStreetLevelHarness({ enabled: true, keyRejectedAtStart: true }); - const refused = await refusedHarness.runner('show_street_level', { latitude: 1, longitude: 2, provider: 'google', fly: false }); - assert.deepEqual([refused.ok, refused.stage, refused.keyRejected], [false, 'key', true]); + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; + const refusedHarness = createStreetLevelHarness({ + enabled: true, + keyRejectedAtStart: true, + }); + const refused = await refusedHarness.runner('show_street_level', { + latitude: 1, + longitude: 2, + provider: 'google', + fly: false, + }); + assert.deepEqual( + [refused.ok, refused.stage, refused.keyRejected], + [false, 'key', true], + ); assert.equal(refused.error, KEY_REJECTED_MESSAGE); assert.equal(refused.say, 'Google Street View refused its key.'); assert.deepEqual(refusedHarness.order, [], 'nothing changed'); - const dark = await createStreetLevelHarness({ enabled: true, activeStack: 'photoreal', lightFails: true }).runner( - 'show_street_level', - { latitude: 1, longitude: 2, provider: 'google', fly: false }, - ); + const dark = await createStreetLevelHarness({ + enabled: true, + activeStack: 'photoreal', + lightFails: true, + }).runner('show_street_level', { + latitude: 1, + longitude: 2, + provider: 'google', + fly: false, + }); assert.deepEqual([dark.ok, dark.stage], [false, 'provider']); assert.match(dark.error, /could not be switched on/); }); @@ -7485,18 +7963,39 @@ test('show_street_level says "refused its key" when Google already refused it, a test('activeImageryFilter reports only the narrowing filters the lit source honours', async () => { const { activeImageryFilter } = await import('./gevActions.js'); const both = { pano: true, since: true }; - assert.equal(activeImageryFilter({ filter: { pano: 'all', sinceDays: 0 }, filterControls: both }), null); - assert.deepEqual(activeImageryFilter({ filter: { pano: 'pano', sinceDays: 0 }, filterControls: both }), { - pano: 'pano', - label: '360° filter', - }); - assert.deepEqual(activeImageryFilter({ filter: { pano: 'flat', sinceDays: 365 }, filterControls: both }), { - pano: 'flat', - sinceDays: 365, - label: 'flat-photo and SINCE filters', - }); assert.equal( - activeImageryFilter({ filter: { pano: 'pano', sinceDays: 365 }, filterControls: { pano: false, since: false } }), + activeImageryFilter({ + filter: { pano: 'all', sinceDays: 0 }, + filterControls: both, + }), + null, + ); + assert.deepEqual( + activeImageryFilter({ + filter: { pano: 'pano', sinceDays: 0 }, + filterControls: both, + }), + { + pano: 'pano', + label: '360° filter', + }, + ); + assert.deepEqual( + activeImageryFilter({ + filter: { pano: 'flat', sinceDays: 365 }, + filterControls: both, + }), + { + pano: 'flat', + sinceDays: 365, + label: 'flat-photo and SINCE filters', + }, + ); + assert.equal( + activeImageryFilter({ + filter: { pano: 'pano', sinceDays: 365 }, + filterControls: { pano: false, since: false }, + }), null, 'Street View honours neither', ); @@ -7504,19 +8003,46 @@ test('activeImageryFilter reports only the narrowing filters the lit source hono }); test('analyst item display strings are single-line and bounded for voice', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; - const rows = [{ id: 'stable-id', name: 'Şehir\n' + 'x'.repeat(3000), label: 'Town\tStation', operator: 'City\nPD', lat: 30, lon: -97 }]; - const { runner } = manifestRunner({ bikeshare: { getStats: () => ({ count: 1, lastUpdate: Date.now() }), getAnalystRecords: () => rows } }); - const result = await runner('analyst_query', { layers: ['bikeshare'], scope: { kind: 'anywhere' }, limit: 1 }); + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; + const rows = [ + { + id: 'stable-id', + name: 'Şehir\n' + 'x'.repeat(3000), + label: 'Town\tStation', + operator: 'City\nPD', + lat: 30, + lon: -97, + }, + ]; + const { runner } = manifestRunner({ + bikeshare: { + getStats: () => ({ count: 1, lastUpdate: Date.now() }), + getAnalystRecords: () => rows, + }, + }); + const result = await runner('analyst_query', { + layers: ['bikeshare'], + scope: { kind: 'anywhere' }, + limit: 1, + }); assert.equal(result.ok, true); assert.equal(result.items[0].name.length, 180); assert.equal(result.items[0].label, 'Town Station'); assert.equal(result.items[0].id, 'stable-id'); - for (const value of Object.values(result.items[0])) if (typeof value === 'string') assert.doesNotMatch(value, /[\r\n\t]/); + for (const value of Object.values(result.items[0])) + if (typeof value === 'string') assert.doesNotMatch(value, /[\r\n\t]/); }); test('analyst_query keeps canonical IDs raw so numbered references still fly to the station', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; const { viewer, styleManager } = createVoiceNavigationHarness(); const referents = createReferentRegistry(); const longName = 'Station ' + 'é'.repeat(200); @@ -7525,51 +8051,97 @@ test('analyst_query keeps canonical IDs raw so numbered references still fly to { id: spaced, name: spaced, lat: 30.2672, lon: -97.7431 }, { id: longName, name: longName, lat: 30.2711, lon: -97.7437 }, ]; - const bikeshare = { getStats: () => ({ count: stations.length, lastUpdate: Date.now() }), getAnalystRecords: () => stations }; + const bikeshare = { + getStats: () => ({ count: stations.length, lastUpdate: Date.now() }), + getAnalystRecords: () => stations, + }; const runner = createActionRunner({ - viewer, styleManager, + viewer, + styleManager, dataManager: { layers: new Map([['bikeshare', { module: bikeshare }]]), isEnabled: () => true, - getAll: () => [{ id: 'bikeshare', name: 'bikeshare', enabled: true, stats: bikeshare.getStats() }], + getAll: () => [ + { + id: 'bikeshare', + name: 'bikeshare', + enabled: true, + stats: bikeshare.getStats(), + }, + ], }, deixis: { referents }, }); - const listed = await runner('analyst_query', { layers: ['bikeshare'], scope: { kind: 'anywhere' }, limit: 2 }); + const listed = await runner('analyst_query', { + layers: ['bikeshare'], + scope: { kind: 'anywhere' }, + limit: 2, + }); assert.equal(listed.ok, true); const bySpaced = listed.items.find((item) => item.id === spaced); const byLong = listed.items.find((item) => item.id === longName); assert.ok(bySpaced && byLong, 'compact items keep the raw station-name IDs'); - assert.equal(bySpaced.name, 'Congress Ave & 2nd', 'display name is still normalized'); + assert.equal( + bySpaced.name, + 'Congress Ave & 2nd', + 'display name is still normalized', + ); assert.equal(byLong.name.length, 180, 'display name is still bounded'); assert.equal(byLong.id.length, longName.length); const registered = referents.list(); - assert.equal(registered.length, 2, 'the analyst result became the numbered list'); + assert.equal( + registered.length, + 2, + 'the analyst result became the numbered list', + ); for (const ref of registered) { const station = stations.find((row) => row.id === ref.id); assert.ok(station, `referent ${ref.n} keeps the canonical ID`); const flown = await runner('fly_to_location', { referent: ref.n }); - assert.equal(flown.ok, true, `referent ${ref.n} resolves instead of "no longer loaded"`); + assert.equal( + flown.ok, + true, + `referent ${ref.n} resolves instead of "no longer loaded"`, + ); assert.equal(flown.latitude, station.lat); assert.equal(flown.longitude, station.lon); } }); test('analyst_query keeps transit route IDs raw so a follow-up filter still matches', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; for (const routeId of ['Route 17', 'R'.repeat(181)]) { const { viewer, styleManager } = createVoiceNavigationHarness(); const vehicles = [{ id: 'bus-1', routeId, lat: 30, lon: -97 }]; - const transit = { getStats: () => ({ count: 1, lastUpdate: Date.now() }), getAnalystRecords: () => vehicles }; + const transit = { + getStats: () => ({ count: 1, lastUpdate: Date.now() }), + getAnalystRecords: () => vehicles, + }; const runner = createActionRunner({ - viewer, styleManager, + viewer, + styleManager, dataManager: { layers: new Map([['transit', { module: transit }]]), isEnabled: () => true, - getAll: () => [{ id: 'transit', name: 'transit', enabled: true, stats: transit.getStats() }], + getAll: () => [ + { + id: 'transit', + name: 'transit', + enabled: true, + stats: transit.getStats(), + }, + ], }, }); - const listed = await runner('analyst_query', { layers: ['transit'], scope: { kind: 'anywhere' }, limit: 1 }); + const listed = await runner('analyst_query', { + layers: ['transit'], + scope: { kind: 'anywhere' }, + limit: 1, + }); assert.equal(listed.ok, true); assert.equal(listed.items[0].routeId, routeId); const followUp = await runner('analyst_query', { @@ -7577,7 +8149,11 @@ test('analyst_query keeps transit route IDs raw so a follow-up filter still matc filters: [{ field: 'routeId', op: 'eq', value: listed.items[0].routeId }], }); assert.equal(followUp.ok, true); - assert.equal(followUp.count, 1, 'the returned route ID matches the same vehicle'); + assert.equal( + followUp.count, + 1, + 'the returned route ID matches the same vehicle', + ); } }); @@ -7649,6 +8225,7 @@ test('set_panel_open opens the Space Missions panel only while its layer is on', const calls = []; let missionsOn = false; let starting = false; + let cockpit = false; const runner = createGevActionRunner({ viewer: { clock: { onTick: { addEventListener: () => () => {} } }, @@ -7660,6 +8237,8 @@ test('set_panel_open opens the Space Missions panel only while its layer is on', }, styleManager: { setPanelCollapsed: (...args) => calls.push(args), + revealPanel: (id) => calls.push(['reveal', id]), + getCockpitState: () => ({ active: cockpit }), }, dataManager: { layers: new Map(), @@ -7691,9 +8270,21 @@ test('set_panel_open opens the Space Missions panel only while its layer is on', open: true, }); assert.equal(opened.ok, true); + // On a phone the Missions sheet shows too. assert.deepEqual(calls, [ ['space-missions-panel', false, { explicit: true }], + ['reveal', 'space-missions-panel'], ]); + // The Cockpit owns the screen: nothing opens and no preference is written. + calls.length = 0; + cockpit = true; + const underCockpit = await runner('set_panel_open', { + panelId: 'space-missions-panel', + open: true, + }); + assert.equal(underCockpit.ok, false); + assert.match(underCockpit.say, /leave the cockpit/); + assert.deepEqual(calls, []); }); test('set_panel_open reaches the Utilities panel by its name, Draw or Import', async () => { @@ -7748,20 +8339,36 @@ test('a partial analyst card shows one partial chip', () => { }); test('show_street_level superseded during its flight switches nothing', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; const h = createStreetLevelHarness(); let current = true; - const pending = h.runner('show_street_level', { latitude: 38.5799, longitude: -121.4937, provider: 'google' }, { isCurrent: () => current }); + const pending = h.runner( + 'show_street_level', + { latitude: 38.5799, longitude: -121.4937, provider: 'google' }, + { isCurrent: () => current }, + ); await new Promise((resolve) => setImmediate(resolve)); current = false; h.finishFlight(); const result = await pending; - assert.deepEqual(h.order.filter((step) => /^(map|params|open|arm|enable)/.test(step)), [], 'the stale turn switched nothing'); + assert.deepEqual( + h.order.filter((step) => /^(map|params|open|arm|enable)/.test(step)), + [], + 'the stale turn switched nothing', + ); assert.equal(result.cancelled, true); }); test('show_street_level superseded during its map switch lights no source', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; const h = createStreetLevelHarness({ enabled: true }); let current = true; const runner = createGevActionRunner({ @@ -7776,31 +8383,71 @@ test('show_street_level superseded during its map switch lights no source', asyn }, dataManager: h.dataManager, }); - const result = await runner('show_street_level', { latitude: 1, longitude: 2, provider: 'google', fly: false }, { isCurrent: () => current }); - assert.deepEqual(h.order.filter((step) => /^(params|open|arm)/.test(step)), [], 'the stale turn lit nothing'); + const result = await runner( + 'show_street_level', + { latitude: 1, longitude: 2, provider: 'google', fly: false }, + { isCurrent: () => current }, + ); + assert.deepEqual( + h.order.filter((step) => /^(params|open|arm)/.test(step)), + [], + 'the stale turn lit nothing', + ); assert.deepEqual([result.stage, result.cancelled], ['map', true]); }); test('show_street_level goes ahead while a source’s key status is still unknown', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; // A freshly loaded sl= link meets the source before its status call answers. - const { runner, order } = createStreetLevelHarness({ enabled: true, configured: null }); - const result = await runner('show_street_level', { latitude: 38.58, longitude: -121.49, provider: 'mapillary', fly: false }); + const { runner, order } = createStreetLevelHarness({ + enabled: true, + configured: null, + }); + const result = await runner('show_street_level', { + latitude: 38.58, + longitude: -121.49, + provider: 'mapillary', + fly: false, + }); assert.equal(result.ok, true); assert.ok(order.some((step) => step.startsWith('open:mapillary'))); }); test('show_street_level in a view that hides its panel stops before anything loads unseen', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; const saved = globalThis.document; - for (const mode of ['cockpit-mode', 'ui-clean-view', 'recording-mode', 'scene-playback-mode']) { - globalThis.document = { body: { classList: { contains: (name) => name === mode } } }; + for (const mode of [ + 'cockpit-mode', + 'ui-clean-view', + 'recording-mode', + 'scene-playback-mode', + ]) { + globalThis.document = { + body: { classList: { contains: (name) => name === mode } }, + }; try { const { runner, order } = createStreetLevelHarness({ enabled: true }); - const result = await runner('show_street_level', { latitude: 38.58, longitude: -121.49, provider: 'google', fly: false }); + const result = await runner('show_street_level', { + latitude: 38.58, + longitude: -121.49, + provider: 'google', + fly: false, + }); assert.deepEqual([result.ok, result.stage], [false, 'view'], mode); assert.match(result.error, /hidden in the current view/); - assert.deepEqual(order.filter((step) => /^(map|params|open|arm|enable)/.test(step)), [], `${mode}: nothing switched`); + assert.deepEqual( + order.filter((step) => /^(map|params|open|arm|enable)/.test(step)), + [], + `${mode}: nothing switched`, + ); } finally { globalThis.document = saved; } @@ -7808,10 +8455,16 @@ test('show_street_level in a view that hides its panel stops before anything loa }); test('show_street_level checks the panel again after every wait: a mode entered meanwhile loads nothing unseen', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; const saved = globalThis.document; const classes = new Set(); - globalThis.document = { body: { classList: { contains: (name) => classes.has(name) } } }; + globalThis.document = { + body: { classList: { contains: (name) => classes.has(name) } }, + }; try { for (const [mode, when] of [ ['ui-clean-view', 'duringEnable'], @@ -7819,9 +8472,18 @@ test('show_street_level checks the panel again after every wait: a mode entered ]) { classes.clear(); const h = createStreetLevelHarness({ [when]: () => classes.add(mode) }); - const result = await h.runner('show_street_level', { latitude: 38.58, longitude: -121.49, provider: 'google', fly: false }); + const result = await h.runner('show_street_level', { + latitude: 38.58, + longitude: -121.49, + provider: 'google', + fly: false, + }); assert.deepEqual([result.ok, result.stage], [false, 'view'], mode); - assert.deepEqual(h.order.filter((step) => /^(open|arm)/.test(step)), [], `${mode}: no billed load`); + assert.deepEqual( + h.order.filter((step) => /^(open|arm)/.test(step)), + [], + `${mode}: no billed load`, + ); assert.deepEqual(h.revealed, [], `${mode}: nothing revealed`); } // Entered while the photo loaded: it is closed again, not reported as shown. @@ -7833,7 +8495,12 @@ test('show_street_level checks the panel again after every wait: a mode entered classes.add('recording-mode'); return opened; }; - const result = await late.runner('show_street_level', { latitude: 38.58, longitude: -121.49, provider: 'mapillary', fly: false }); + const result = await late.runner('show_street_level', { + latitude: 38.58, + longitude: -121.49, + provider: 'mapillary', + fly: false, + }); assert.deepEqual([result.ok, result.stage], [false, 'view']); assert.equal(late.order.at(-1), 'close'); assert.deepEqual(late.revealed, []); @@ -7843,12 +8510,21 @@ test('show_street_level checks the panel again after every wait: a mode entered }); test('show_street_level refuses a hidden panel before the camera leaves a recording', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; const saved = globalThis.document; - globalThis.document = { body: { classList: { contains: (name) => name === 'recording-mode' } } }; + globalThis.document = { + body: { classList: { contains: (name) => name === 'recording-mode' } }, + }; try { const { runner, order } = createStreetLevelHarness(); - const result = await runner('show_street_level', { query: 'Eiffel Tower', provider: 'mapillary' }); + const result = await runner('show_street_level', { + query: 'Eiffel Tower', + provider: 'mapillary', + }); assert.deepEqual([result.ok, result.stage], [false, 'view']); assert.deepEqual(order, [], 'no flight'); } finally { @@ -7857,42 +8533,107 @@ test('show_street_level refuses a hidden panel before the camera leaves a record }); test('show_street_level stops once the camera is someone else’s: a navigation or a gesture during the map switch', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; for (const take of ['navigate', 'gesture']) { let h; h = createStreetLevelHarness({ duringMapSwitch: () => h[take]() }); - const result = await h.runner('show_street_level', { latitude: 38.58, longitude: -121.49, provider: 'mapillary', fly: false }); + const result = await h.runner('show_street_level', { + latitude: 38.58, + longitude: -121.49, + provider: 'mapillary', + fly: false, + }); assert.equal(result.ok, true, `${take}: Mapillary needs no map switch`); h = createStreetLevelHarness({ duringMapSwitch: () => h[take]() }); - const google = await h.runner('show_street_level', { latitude: 38.58, longitude: -121.49, provider: 'google', fly: false }); - assert.deepEqual([google.ok, google.stage, google.cancelled, google.superseded], [false, 'map', true, true], take); - assert.deepEqual(h.order.filter((step) => /^(params|enable|open|arm)/.test(step)), [], `${take}: nothing lit for the old place`); + const google = await h.runner('show_street_level', { + latitude: 38.58, + longitude: -121.49, + provider: 'google', + fly: false, + }); + assert.deepEqual( + [google.ok, google.stage, google.cancelled, google.superseded], + [false, 'map', true, true], + take, + ); + assert.deepEqual( + h.order.filter((step) => /^(params|enable|open|arm)/.test(step)), + [], + `${take}: nothing lit for the old place`, + ); } // During the layer switch-on: the photo lookup never runs. let h; h = createStreetLevelHarness({ duringEnable: () => h.navigate() }); - const result = await h.runner('show_street_level', { latitude: 38.58, longitude: -121.49, provider: 'mapillary', fly: false }); - assert.deepEqual([result.ok, result.stage, result.superseded], [false, 'layer', true]); + const result = await h.runner('show_street_level', { + latitude: 38.58, + longitude: -121.49, + provider: 'mapillary', + fly: false, + }); + assert.deepEqual( + [result.ok, result.stage, result.superseded], + [false, 'layer', true], + ); assert.ok(!h.order.some((step) => step.startsWith('open:'))); }); test('show_street_level loads no photo it found once the camera or the panel moved on during the lookup', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; for (const take of ['navigate', 'gesture']) { let h; - h = createStreetLevelHarness({ enabled: true, activeStack: 'photoreal', duringLookup: () => h[take]() }); - const result = await h.runner('show_street_level', { latitude: 38.58, longitude: -121.49, provider: 'google', fly: false }); - assert.deepEqual([result.ok, result.stage, result.superseded], [false, 'imagery', true], take); + h = createStreetLevelHarness({ + enabled: true, + activeStack: 'photoreal', + duringLookup: () => h[take](), + }); + const result = await h.runner('show_street_level', { + latitude: 38.58, + longitude: -121.49, + provider: 'google', + fly: false, + }); + assert.deepEqual( + [result.ok, result.stage, result.superseded], + [false, 'imagery', true], + take, + ); assert.equal(h.lookups.length, 1); - assert.equal(h.street.open, false, `${take}: the billed panorama never loads`); - assert.ok(!h.order.includes('close'), `${take}: nothing opened, nothing to close`); + assert.equal( + h.street.open, + false, + `${take}: the billed panorama never loads`, + ); + assert.ok( + !h.order.includes('close'), + `${take}: nothing opened, nothing to close`, + ); } const saved = globalThis.document; const classes = new Set(); - globalThis.document = { body: { classList: { contains: (name) => classes.has(name) } } }; + globalThis.document = { + body: { classList: { contains: (name) => classes.has(name) } }, + }; try { - const h = createStreetLevelHarness({ enabled: true, activeStack: 'photoreal', duringLookup: () => classes.add('ui-clean-view') }); - const result = await h.runner('show_street_level', { latitude: 38.58, longitude: -121.49, provider: 'google', fly: false }); + const h = createStreetLevelHarness({ + enabled: true, + activeStack: 'photoreal', + duringLookup: () => classes.add('ui-clean-view'), + }); + const result = await h.runner('show_street_level', { + latitude: 38.58, + longitude: -121.49, + provider: 'google', + fly: false, + }); assert.deepEqual([result.ok, result.stage], [false, 'view']); assert.equal(h.street.open, false, 'nothing loads into the hidden panel'); } finally { @@ -7901,19 +8642,44 @@ test('show_street_level loads no photo it found once the camera or the panel mov }); test('show_street_level replaces an open photo in place: the viewer (and EXPAND) stays up while it looks', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; - const h = createStreetLevelHarness({ enabled: true, photoOpen: true, nearest: 'pano-b' }); - const result = await h.runner('show_street_level', { latitude: 38.58, longitude: -121.49, provider: 'mapillary', fly: false }); + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; + const h = createStreetLevelHarness({ + enabled: true, + photoOpen: true, + nearest: 'pano-b', + }); + const result = await h.runner('show_street_level', { + latitude: 38.58, + longitude: -121.49, + provider: 'mapillary', + fly: false, + }); assert.equal(result.ok, true); - assert.equal(h.lookups[0].replace, true, 'the lookup takes over the open photo'); + assert.equal( + h.lookups[0].replace, + true, + 'the lookup takes over the open photo', + ); assert.ok(!h.order.includes('close'), 'never closed on the way'); assert.deepEqual([h.street.open, h.street.imageId], [true, 'pano-b']); }); test('show_street_level owns the camera from where its own flight lands', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; const h = createStreetLevelHarness(); - const pending = h.runner('show_street_level', { latitude: 38.58, longitude: -121.49, provider: 'mapillary' }); + const pending = h.runner('show_street_level', { + latitude: 38.58, + longitude: -121.49, + provider: 'mapillary', + }); await new Promise((resolve) => setTimeout(resolve, 0)); h.finishFlight(); const result = await pending; @@ -7926,15 +8692,27 @@ test('show_street_level owns the camera from where its own flight lands', async // press on the globe, which does not cancel a Cesium flight either. for (const take of ['navigate', 'gesture']) { test(`show_street_level stands down when the camera is taken during its own flight (${take})`, async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; const h = createStreetLevelHarness(); - const pending = h.runner('show_street_level', { latitude: 38.58, longitude: -121.49, provider: 'google' }); + const pending = h.runner('show_street_level', { + latitude: 38.58, + longitude: -121.49, + provider: 'google', + }); await new Promise((resolve) => setTimeout(resolve, 0)); assert.deepEqual(h.order, ['fly'], 'the flight is under way'); h[take](); h.finishFlight(); const result = await pending; - assert.deepEqual([result.ok, result.superseded], [false, true], result.error); + assert.deepEqual( + [result.ok, result.superseded], + [false, true], + result.error, + ); assert.deepEqual( h.order.filter((step) => /^(map|params|open|arm|enable)/.test(step)), [], @@ -7944,32 +8722,88 @@ for (const take of ['navigate', 'gesture']) { } test('show_street_level closes the previous photo, so one that finds nothing leaves no other place on screen', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; - const empty = createStreetLevelHarness({ enabled: true, photoOpen: true, nearest: null }); - const result = await empty.runner('show_street_level', { latitude: 23.4, longitude: 12.5, provider: 'mapillary', fly: false }); + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; + const empty = createStreetLevelHarness({ + enabled: true, + photoOpen: true, + nearest: null, + }); + const result = await empty.runner('show_street_level', { + latitude: 23.4, + longitude: 12.5, + provider: 'mapillary', + fly: false, + }); assert.deepEqual([result.ok, result.noImagery], [false, true]); assert.equal(empty.street.open, false, 'the Paris photo is gone'); - assert.match(empty.street.error, /No street-level imagery/, 'the panel shows why'); + assert.match( + empty.street.error, + /No street-level imagery/, + 'the panel shows why', + ); // A link that only arms a billed source closes it too. - const armed = createStreetLevelHarness({ enabled: true, photoOpen: true, activeStack: 'photoreal' }); - await armed.runner('show_street_level', { latitude: 23.4, longitude: 12.5, provider: 'google', fly: false, autoOpen: false }); - assert.deepEqual(armed.order.filter((step) => /^(close|arm)/.test(step)).map((step) => step.split(':')[0]), ['close', 'arm']); + const armed = createStreetLevelHarness({ + enabled: true, + photoOpen: true, + activeStack: 'photoreal', + }); + await armed.runner('show_street_level', { + latitude: 23.4, + longitude: 12.5, + provider: 'google', + fly: false, + autoOpen: false, + }); + assert.deepEqual( + armed.order + .filter((step) => /^(close|arm)/.test(step)) + .map((step) => step.split(':')[0]), + ['close', 'arm'], + ); }); test('show_street_level opens over the clean embedded globe but respects its other exclusive modes', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; const saved = globalThis.document; try { - for (const mode of [null, 'cockpit-mode', 'recording-mode', 'scene-playback-mode']) { + for (const mode of [ + null, + 'cockpit-mode', + 'recording-mode', + 'scene-playback-mode', + ]) { const classes = new Set(['ui-embed', 'ui-clean-view', mode]); - globalThis.document = { body: { classList: { contains: (name) => classes.has(name) } } }; + globalThis.document = { + body: { classList: { contains: (name) => classes.has(name) } }, + }; const { runner, order } = createStreetLevelHarness({ enabled: true }); - const result = await runner('show_street_level', { latitude: 38.58, longitude: -121.49, provider: 'mapillary', fly: false }); + const result = await runner('show_street_level', { + latitude: 38.58, + longitude: -121.49, + provider: 'mapillary', + fly: false, + }); if (mode) { assert.deepEqual([result.ok, result.stage], [false, 'view'], mode); - assert.deepEqual(order.filter((step) => /^(map|params|open|arm|enable)/.test(step)), [], `${mode}: nothing switched`); + assert.deepEqual( + order.filter((step) => /^(map|params|open|arm|enable)/.test(step)), + [], + `${mode}: nothing switched`, + ); } else { - assert.equal(result.ok, true, 'embed clean view lifts the photo over the globe'); + assert.equal( + result.ok, + true, + 'embed clean view lifts the photo over the globe', + ); assert.ok(order.some((step) => step.startsWith('open:mapillary'))); } } @@ -7979,7 +8813,11 @@ test('show_street_level opens over the clean embedded globe but respects its oth }); test('show_street_level from a link keeps the recipient’s preferences: its switches are not the user’s', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; const link = createStreetLevelHarness(); const linked = await link.runner( 'show_street_level', @@ -7987,48 +8825,120 @@ test('show_street_level from a link keeps the recipient’s preferences: its swi { origin: 'programmatic' }, ); assert.equal(linked.ok, true, linked.error); - assert.deepEqual(link.origins, ['programmatic', 'programmatic'], 'source switch and layer on'); + assert.deepEqual( + link.origins, + ['programmatic', 'programmatic'], + 'source switch and layer on', + ); const asked = createStreetLevelHarness(); - await asked.runner('show_street_level', { latitude: 1, longitude: 2, provider: 'mapillary', fly: false }); - assert.deepEqual(asked.origins, ['voice', 'voice'], 'the assistant’s request is the user’s choice'); + await asked.runner('show_street_level', { + latitude: 1, + longitude: 2, + provider: 'mapillary', + fly: false, + }); + assert.deepEqual( + asked.origins, + ['voice', 'voice'], + 'the assistant’s request is the user’s choice', + ); }); test('show_street_level with no place looks under the screen centre, not a link’s armed point', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; const here = createStreetLevelHarness({ enabled: true }); - const result = await here.runner('show_street_level', { provider: 'mapillary' }); + const result = await here.runner('show_street_level', { + provider: 'mapillary', + }); assert.equal(result.ok, true, result.error); assert.equal(result.atViewCentre, true); assert.equal(here.lookups[0].point, null); assert.equal(here.lookups[0].aim, 'screen-centre'); assert.equal(here.lookups[0].armed, false); const placed = createStreetLevelHarness({ enabled: true }); - await placed.runner('show_street_level', { latitude: 1, longitude: 2, provider: 'mapillary', fly: false }); - assert.equal(placed.lookups[0].aim, undefined, 'a place is looked up where it is'); - const sky = createStreetLevelHarness({ enabled: true, nearest: null, sky: true }); - const refused = await sky.runner('show_street_level', { provider: 'mapillary' }); - assert.deepEqual([refused.ok, refused.stage, refused.aim], [false, 'imagery', 'sky']); + await placed.runner('show_street_level', { + latitude: 1, + longitude: 2, + provider: 'mapillary', + fly: false, + }); + assert.equal( + placed.lookups[0].aim, + undefined, + 'a place is looked up where it is', + ); + const sky = createStreetLevelHarness({ + enabled: true, + nearest: null, + sky: true, + }); + const refused = await sky.runner('show_street_level', { + provider: 'mapillary', + }); + assert.deepEqual( + [refused.ok, refused.stage, refused.aim], + [false, 'imagery', 'sky'], + ); }); test('show_street_level tells missing imagery from a failing source', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; - const empty = await createStreetLevelHarness({ enabled: true, nearest: null }).runner('show_street_level', { - latitude: 1, longitude: 2, provider: 'mapillary', fly: false, + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; + const empty = await createStreetLevelHarness({ + enabled: true, + nearest: null, + }).runner('show_street_level', { + latitude: 1, + longitude: 2, + provider: 'mapillary', + fly: false, }); - assert.deepEqual([empty.stage, empty.noImagery, empty.imageryError], ['imagery', true, undefined]); - const broken = await createStreetLevelHarness({ enabled: true, imageryError: 'Mapillary graph HTTP 500' }).runner( - 'show_street_level', - { latitude: 1, longitude: 2, provider: 'mapillary', fly: false }, + assert.deepEqual( + [empty.stage, empty.noImagery, empty.imageryError], + ['imagery', true, undefined], + ); + const broken = await createStreetLevelHarness({ + enabled: true, + imageryError: 'Mapillary graph HTTP 500', + }).runner('show_street_level', { + latitude: 1, + longitude: 2, + provider: 'mapillary', + fly: false, + }); + assert.deepEqual( + [broken.stage, broken.noImagery, broken.imageryError], + ['imagery', undefined, true], ); - assert.deepEqual([broken.stage, broken.noImagery, broken.imageryError], ['imagery', undefined, true]); assert.equal(broken.error, 'Mapillary graph HTTP 500'); }); test('show_street_level shows every photo it opens, also over a panel the user had closed', async () => { - globalThis.window = globalThis.window || { clearTimeout, setTimeout, requestIdleCallback: null }; + globalThis.window = globalThis.window || { + clearTimeout, + setTimeout, + requestIdleCallback: null, + }; const harness = createStreetLevelHarness({ enabled: true }); - await harness.runner('show_street_level', { latitude: 1, longitude: 2, provider: 'mapillary', fly: false }); - await harness.runner('show_street_level', { latitude: 3, longitude: 4, provider: 'mapillary', fly: false }); + await harness.runner('show_street_level', { + latitude: 1, + longitude: 2, + provider: 'mapillary', + fly: false, + }); + await harness.runner('show_street_level', { + latitude: 3, + longitude: 4, + provider: 'mapillary', + fly: false, + }); assert.deepEqual(harness.revealed, [ 'collapse:street-level-panel:false', 'reveal:street-level-panel', @@ -8036,6 +8946,11 @@ test('show_street_level shows every photo it opens, also over a panel the user h 'reveal:street-level-panel', ]); const missing = createStreetLevelHarness({ enabled: true, nearest: null }); - await missing.runner('show_street_level', { latitude: 1, longitude: 2, provider: 'mapillary', fly: false }); + await missing.runner('show_street_level', { + latitude: 1, + longitude: 2, + provider: 'mapillary', + fly: false, + }); assert.deepEqual(missing.revealed, [], 'nothing opened, nothing revealed'); });