mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-17 08:42:21 +00:00
feat(globe): surface height quality
engine.surface.sampleHeightDetailed(place, { exclude, lod }) answers
{ height, source: 'tiles' | 'terrain', tileSizeM? } (src/globe/surfaceDetail.js).
On Navara tileSizeM is the extent of the tile that answered and
lod 'finest' takes the finest loaded tile, drawn or not; Cesium answers
tiles without a size, else the globe's terrain. acceptedSurfaceHeight()
turns an answer into a height or a miss: tiles larger than
MAX_FLOOR_TILE_SIZE_M (4 km) are too coarse, terrain is not the mesh.
The mesh floor sampler and the ground snap are engine-only now (a viewer
or scene reaches its engine through engineFromViewer, which also registers
the scene) and treat a coarse answer as a miss, as they treat undefined.
Measured on Navara at Austin: while the tiles stream, a 27.9 km tile reads
143.2 m where the ground is 122.5 m (a 1.8 km tile).
`exclude` takes the engine's own mover sets (MoverSet.id): Cesium hides a
set's primitive for the synchronous sample (Cesium matches excluded objects
per billboard, not per collection); Navara's ray only meets tiles.
"sampleHeight undefined in the app on Navara" did not reproduce: the
startup Austin sample is 121.9 m (tile 889 m) on Navara and 122.4 m on
Cesium; one ModelMesh class is patched.
S2 QA (scripts/qa-surface-heights.mjs, 20 places at JFK, SFO, AUS, roofs
and streets): Navara within 2 m of Cesium at 19/20 from 800 m and 18/20
from 15 km with lod 'finest' (gates 18 and 15); offsets per region
-0.21 / +0.4 / +0.1 m; the Empire State roof differs by 39 m (spire
geometry). Navara tile sizes at 800 m: 112-314 m.
This commit is contained in:
1 parent
f640890cf6
commit
645f042450
20 files changed
+635
-244
No files matched your search
@@ -31,6 +31,7 @@ import { createLineRegistry } from '../lines.js';
|
||||
import { createMoverRegistry } from '../movers.js';
|
||||
import { createCpuPicker } from '../cpuPicks.js';
|
||||
import { createFollowController } from '../follow.js';
|
||||
import { normalizeSurfaceOptions } from '../surfaceDetail.js';
|
||||
|
||||
const { cartesian2, cartesian3, cartographic, ellipsoid, math, matrix4 } = geo;
|
||||
const WGS84 = ellipsoid.WGS84;
|
||||
@@ -55,6 +56,7 @@ const SCRIPTABLE = new Set([
|
||||
'pickEllipsoid',
|
||||
'viewRectangle',
|
||||
'sampleHeight',
|
||||
'sampleHeightDetailed',
|
||||
'terrainHeight',
|
||||
'clampToHeight',
|
||||
'tilesLoaded',
|
||||
@@ -927,6 +929,28 @@ export function createFakeEngine(options = {}) {
|
||||
record('surface.sampleHeight', [position, exclude]);
|
||||
return scripted('sampleHeight', [position, exclude], () => undefined);
|
||||
},
|
||||
// Scripted as 'sampleHeightDetailed', else from the scripted
|
||||
// sampleHeight (tiles, no size) and terrainHeight.
|
||||
sampleHeightDetailed(position, surfaceOptions) {
|
||||
const { exclude, lod } = normalizeSurfaceOptions(surfaceOptions);
|
||||
record('surface.sampleHeightDetailed', [position, { exclude, lod }]);
|
||||
return scripted(
|
||||
'sampleHeightDetailed',
|
||||
[position, { exclude, lod }],
|
||||
() => {
|
||||
const height = scripted(
|
||||
'sampleHeight',
|
||||
[position, exclude],
|
||||
() => undefined,
|
||||
);
|
||||
if (Number.isFinite(height)) return { height, source: 'tiles' };
|
||||
const terrain = scripted('terrainHeight', [position], () => 0);
|
||||
return Number.isFinite(terrain)
|
||||
? { height: terrain, source: 'terrain' }
|
||||
: undefined;
|
||||
},
|
||||
);
|
||||
},
|
||||
supported: true,
|
||||
terrainHeight(position) {
|
||||
record('surface.terrainHeight', [position]);
|
||||
|
||||
Reference in new issue
Block a user