mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-17 00:32:21 +00:00
fix(military): don't treat adsb.lol's position-less rows as a partial snapshot
readsb omits lat/lon for a contact heard without a current position; about a third of every /v2/mil response is such rows. They made every military snapshot partial, so a contact that left the feed was retained at full opacity for five minutes instead of fading and leaving on the missed-poll limits. A row with a hex and no lat/lon now leaves the snapshot complete and is listed in retainIds, as OpenSky's null-position rows already are.
This commit is contained in:
1 parent
15de9d738c
commit
60dad0c35e
7 files changed
+151
-37
No files matched your search
@@ -39,9 +39,11 @@ export function normalizeOpenSkyAircraft(row) {
|
||||
};
|
||||
}
|
||||
|
||||
const readsbId = (row) => cleanText(row?.hex).toLowerCase();
|
||||
|
||||
/** Normalize readsb observations. The caller supplies the source snapshot epoch. */
|
||||
export function normalizeReadsbAircraft(row, snapshotTimeMs) {
|
||||
const id = cleanText(row?.hex).toLowerCase();
|
||||
const id = readsbId(row);
|
||||
const latitude = finite(row?.lat),
|
||||
longitude = finite(row?.lon);
|
||||
if (!id || !coordinates(latitude, longitude)) return null;
|
||||
@@ -128,6 +130,14 @@ export function openSkySnapshot(
|
||||
};
|
||||
}
|
||||
|
||||
/**
|
||||
* readsb omits lat/lon for a contact heard without a current position. Both
|
||||
* must be absent; a half or unreadable position still marks the row malformed.
|
||||
*/
|
||||
function readsbUnpositionedId(row) {
|
||||
return row?.lat == null && row?.lon == null ? readsbId(row) : '';
|
||||
}
|
||||
|
||||
export function readsbSnapshot(
|
||||
payload,
|
||||
{
|
||||
@@ -142,6 +152,7 @@ export function readsbSnapshot(
|
||||
payload?.ac,
|
||||
(row) => normalizeReadsbAircraft(row, observedAtMs),
|
||||
'adsb.lol',
|
||||
readsbUnpositionedId,
|
||||
);
|
||||
const ageMs = observedAtMs == null ? null : Math.max(0, now - observedAtMs);
|
||||
return {
|
||||
|
||||
Reference in new issue
Block a user