mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 16:22:20 +00:00
Renderer conformance: checks that read an exact colour set a bare sky
With atmosphere, fog and lighting off and clear weather a renderer applies none of its look, so draw.models.tint, draw.models.blend, globe.base.vector and globe.imagery.video set that sky first and test what they draw, not a renderer's sky light or tone mapping.
This commit is contained in:
1 parent
1b226e14f2
commit
5cd28731fa
3 files changed
+22
-6
No files matched your search
@@ -155,7 +155,10 @@ the sun lights it. The checks `globe.weather`, `globe.weather.drawn` and
|
||||
|
||||
How the sky, atmosphere, haze, lighting and the frame's tone mapping and
|
||||
exposure look is the renderer's own: `globe.sky` switches parts on and
|
||||
off, and no check compares colours. The
|
||||
off, and no check compares colours. With
|
||||
`atmosphere`, `fog` and `lighting` off and clear weather a renderer applies
|
||||
none of its look, so the checks that read an exact colour (`bareSky` in
|
||||
`checks/ports.js`) set that sky first. The
|
||||
reference images under `src/render/conformance/goldens/visual/` are the
|
||||
default renderer's own, for checking it against itself.
|
||||
|
||||
|
||||
Reference in new issue
Block a user