mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 08:12:24 +00:00
refactor(build): place the views in the page instead of expanding templates
index.html now lists each view's host and the loading screen itself, so the gev:template expansion plugin, its view list, the loading-screen template and the ./build/html export are gone. createApplication takes omitViews for views an application leaves out; their hosts are removed, and a view an earlier call rendered is unmounted.
This commit is contained in:
1 parent
f279200af5
commit
5bf797ef71
18 files changed
+176
-174
No files matched your search
@@ -0,0 +1,77 @@
|
||||
// src/ui/views/mountApplicationViews.test.mjs — a page's view hosts render
|
||||
// their views, and an application can leave views out, over happy-dom.
|
||||
import '../../testSupport/registerDom.mjs';
|
||||
import test from 'node:test';
|
||||
import assert from 'node:assert/strict';
|
||||
import { createApplication } from '../../app/application.js';
|
||||
import { mountApplicationViews } from './index.js';
|
||||
|
||||
function page(names) {
|
||||
document.body.replaceChildren();
|
||||
for (const name of names) {
|
||||
const host = document.createElement('div');
|
||||
host.className = 'gev-view';
|
||||
host.setAttribute('data-gev-view', name);
|
||||
document.body.append(host);
|
||||
}
|
||||
}
|
||||
|
||||
const hostNames = () =>
|
||||
[...document.querySelectorAll('[data-gev-view]')].map((host) =>
|
||||
host.getAttribute('data-gev-view'),
|
||||
);
|
||||
|
||||
test('omitted views lose their hosts and the rest render', () => {
|
||||
page(['welcome', 'provider-settings']);
|
||||
mountApplicationViews(document, { omit: ['provider-settings'] });
|
||||
assert.deepEqual(hostNames(), ['welcome']);
|
||||
assert.equal(document.getElementById('key-setup-chip'), null);
|
||||
assert.ok(
|
||||
document.querySelector('[data-gev-view="welcome"]').children.length,
|
||||
);
|
||||
});
|
||||
|
||||
test('a view an earlier call rendered is unmounted when a later call omits it', () => {
|
||||
page(['welcome', 'provider-settings']);
|
||||
mountApplicationViews(document);
|
||||
assert.ok(document.getElementById('key-setup-chip'));
|
||||
mountApplicationViews(document, { omit: ['provider-settings'] });
|
||||
assert.deepEqual(hostNames(), ['welcome']);
|
||||
assert.equal(document.getElementById('key-setup-chip'), null);
|
||||
});
|
||||
|
||||
test('unknown view names are refused, in the page or in the omit list', () => {
|
||||
page([]);
|
||||
for (const name of ['toString', 'constructor'])
|
||||
assert.throws(
|
||||
() => mountApplicationViews(document, { omit: [name] }),
|
||||
/Unknown application view/,
|
||||
);
|
||||
page(['toString']);
|
||||
assert.throws(
|
||||
() => mountApplicationViews(document),
|
||||
/Unknown application view/,
|
||||
);
|
||||
assert.throws(
|
||||
() => mountApplicationViews(document, { omit: ['nope'] }),
|
||||
/Unknown application view: nope/,
|
||||
);
|
||||
page(['nope']);
|
||||
assert.throws(
|
||||
() => mountApplicationViews(document),
|
||||
/Unknown application view: nope/,
|
||||
);
|
||||
});
|
||||
|
||||
test('createApplication leaves out the views its omitViews names', () => {
|
||||
page(['welcome', 'provider-settings']);
|
||||
const noop = () => ({});
|
||||
createApplication({
|
||||
createScene: noop,
|
||||
createControls: noop,
|
||||
createData: noop,
|
||||
createTools: noop,
|
||||
omitViews: ['provider-settings'],
|
||||
});
|
||||
assert.deepEqual(hostNames(), ['welcome']);
|
||||
});
|
||||
Reference in new issue
Block a user