From 58872358944341618b048607fae8ea16d02be75a Mon Sep 17 00:00:00 2001 From: brandonabyrd Date: Mon, 9 Nov 2026 06:35:39 -0600 Subject: [PATCH] docs(cctv): describe conservative horizon geometry --- src/layers/cctv/frames.js | 4 ++-- src/layers/cctv/frames.test.mjs | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/layers/cctv/frames.js b/src/layers/cctv/frames.js index 95ef0a9794..aab35fcec6 100644 --- a/src/layers/cctv/frames.js +++ b/src/layers/cctv/frames.js @@ -252,8 +252,8 @@ export function createFrames({ state: layerState, services, parts, source }) { /** * Whether a camera's monitor plane can be on screen: the mount, the far cap * and its corners are bounded by one sphere that is tested against the view - * frustum, and at least one of those points must be above the horizon when - * the reference ellipsoid is a reliable occluder for this view. + * frustum, and at least one of those points must be above a conservative + * horizon computed from a shrunken reference ellipsoid. * Anything this cannot judge (no viewer, a 2D or Columbus scene, no geometry * yet) counts as visible, so a missing input never blocks a picture. * @param {Object} record - Camera record. diff --git a/src/layers/cctv/frames.test.mjs b/src/layers/cctv/frames.test.mjs index d12bd401fb..b21fea1cbc 100644 --- a/src/layers/cctv/frames.test.mjs +++ b/src/layers/cctv/frames.test.mjs @@ -275,8 +275,7 @@ test('a nearby plane below the ellipsoid still fetches for a low viewer', () => frames.refreshProjectionImage(record); assert.match(record.projection.image.src, /projTs=/); - // An above-threshold viewer still needs a conservative result when the - // entire plane itself is below the reference ellipsoid. + // The same below-ellipsoid plane remains visible from a higher viewer. const high = point(0.00135, 0, 1200); const highDirection = Cesium.Cartesian3.normalize( Cesium.Cartesian3.subtract(cap, high, new Cesium.Cartesian3()),