mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-20 10:12:18 +00:00
Vue kit: the view scan reads SFC scripts, string markup and bound types
Following review, the scan now also: - reads every SFC's script blocks, not only modules; - matches a createElement call Prettier wraps over lines, and any case of the tag name; - fails on a button, select, input or textarea written as markup in a string, comments aside, apart from the globe panel's standalone page (plain HTML a host serves, with no Vue or kit), which the test names and requires to still be the reason; - catches a Material class built in a template string; - reads an input's type when bound to a quoted literal or named in a v-bind object, in any case, and unquoted before `/>`; - catches a Material class named in a v-bind object. Each new path was confirmed to fail when its violation is put back. docs/VUE-MIGRATION.md now names the globe panel page as the exception, lists the two text areas among the native fields left, and notes that the scene dialog's field takes text-like types from its callers only. Co-authored-by: Manjunath Paparaju <[email protected]>
This commit is contained in:
1 parent
91e42b887f
commit
559a7cec71
2 files changed
+138
-36
No files matched your search
+10
-4
@@ -89,10 +89,16 @@ the kit is a `UiButton`, `UiCloseButton` or another kit control, every
|
||||
Material Symbols glyph a `UiIcon`, every checkbox a `UiCheckbox`, every
|
||||
select a `UiSelect`, and every range a `UiSlider` except the radio
|
||||
tuner's and the world timeline's, for the reasons given below. No module
|
||||
outside the kit builds a button, select, field or Material glyph in script
|
||||
(`src/ui/kit/viewControls.test.mjs` pins all of it). The native fields
|
||||
left are the text, number, password and file inputs the kit has no
|
||||
control for, and the search fields whose surfaces this document names.
|
||||
outside the kit, and no SFC's script, builds a button, select, field or
|
||||
Material glyph in script or writes one as markup in a string, apart from
|
||||
the globe panel's standalone page (`src/tools/globePanel.js`), plain HTML
|
||||
a host serves with no Vue or kit, whose Expand and Open buttons are
|
||||
written as markup (`src/ui/kit/viewControls.test.mjs` pins all of it).
|
||||
The native fields left are the text, number, password and file inputs
|
||||
and the two text areas (the chat's message box and the scene dialog's
|
||||
multiline field) the kit has no control for, and the search fields whose
|
||||
surfaces this document names. The scene dialog's single-line field takes
|
||||
its type from its caller, which passes text-like types only.
|
||||
`UiButton` adds `pressedClass`, Core's class on a pressed toggle (most use
|
||||
`active`); its pressed classes toggle through `classList`, so a class other
|
||||
code adds (a voice highlight) survives a press. Every pressed toggle (a
|
||||
|
||||
Reference in new issue
Block a user