mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 08:12:24 +00:00
Report model load failures to model sets, and bound the tracked model's retries again
The renderer contract gains an optional event on model draw sets,
`on('loadFailed', (id, message) => ...)`, beside `ready`: a model's url
failed to load, once per failed load. The item stays in the set drawing
what it drew before; removing it and adding it again tries at once. A
renderer that cannot tell a failure may never fire it.
The Cesium draw port fires it once Cesium is done with the frame it
raised the error in, and not for a load that was superseded or whose item
went. The stub fails urls under `stub-fail:`, telling each load once. A
conformance check (`draw.models.loadFailed`) runs on both, with a model
url the dev server does not serve for Cesium.
The flights and military layers use it in place of rewriting every
unloaded model every 5 s. A fleet model whose load failed is removed and
added again 5 s later. The tracked model gets back its per-selection
budget: a failed load is let go and tried again 1.5 s later, and after
three failures the contact stays 2D until another is selected, as
before the models moved onto the draw port. A good load retires the
budget, and a model that loads after all is kept.
This commit is contained in:
1 parent
396e7f0deb
commit
5370feb825
23 files changed
+536
-58
No files matched your search
@@ -143,6 +143,37 @@ test('the capability and frame-step lists are the types’ own', () => {
|
||||
);
|
||||
});
|
||||
|
||||
test('a draw set’s events: ready with the id, loadFailed with the id and why', () => {
|
||||
const on = checker
|
||||
.getTypeAtLocation(declared('DrawSet').name)
|
||||
.getProperty('on');
|
||||
const signatures = checker
|
||||
.getTypeOfSymbolAtLocation(on, declared('DrawSet'))
|
||||
.getCallSignatures();
|
||||
const events = Object.fromEntries(
|
||||
signatures.map((signature) => {
|
||||
const [event, cb] = signature.getParameters();
|
||||
const callback = checker
|
||||
.getTypeOfSymbolAtLocation(cb, cb.valueDeclaration)
|
||||
.getCallSignatures()[0];
|
||||
return [
|
||||
checker.getTypeOfSymbolAtLocation(event, event.valueDeclaration).value,
|
||||
callback
|
||||
.getParameters()
|
||||
.map((p) =>
|
||||
checker.typeToString(
|
||||
checker.getTypeOfSymbolAtLocation(p, p.valueDeclaration),
|
||||
),
|
||||
),
|
||||
];
|
||||
}),
|
||||
);
|
||||
assert.deepEqual(events, {
|
||||
ready: ['string'],
|
||||
loadFailed: ['string', 'string'],
|
||||
});
|
||||
});
|
||||
|
||||
test('the shape check names what is missing and what a capability does not allow', () => {
|
||||
assert.deepEqual(checkRendererShape(null), ['renderer is not an object']);
|
||||
assert.deepEqual(checkRendererShape({}), [
|
||||
|
||||
Vendored
+9
@@ -507,6 +507,15 @@ export interface DrawSet<T> {
|
||||
show: boolean;
|
||||
/** `models`: a model has loaded and is posed. */
|
||||
on(event: 'ready', cb: (id: string) => void): Off;
|
||||
/**
|
||||
* `models`: a model's url failed to load (`message` says why), once per
|
||||
* failed load. The item stays in the set, drawing what it drew before (a
|
||||
* new item draws nothing); a renderer may try the url again when the item
|
||||
* is next updated. Removing the item and adding it again tries at once.
|
||||
* Optional: where the renderer cannot tell a failure it may never fire it, so
|
||||
* a fallback must not wait on it.
|
||||
*/
|
||||
on(event: 'loadFailed', cb: (id: string, message: string) => void): Off;
|
||||
dispose(): void;
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user