mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 08:12:24 +00:00
Report model load failures to model sets, and bound the tracked model's retries again
The renderer contract gains an optional event on model draw sets,
`on('loadFailed', (id, message) => ...)`, beside `ready`: a model's url
failed to load, once per failed load. The item stays in the set drawing
what it drew before; removing it and adding it again tries at once. A
renderer that cannot tell a failure may never fire it.
The Cesium draw port fires it once Cesium is done with the frame it
raised the error in, and not for a load that was superseded or whose item
went. The stub fails urls under `stub-fail:`, telling each load once. A
conformance check (`draw.models.loadFailed`) runs on both, with a model
url the dev server does not serve for Cesium.
The flights and military layers use it in place of rewriting every
unloaded model every 5 s. A fleet model whose load failed is removed and
added again 5 s later. The tracked model gets back its per-selection
budget: a failed load is let go and tried again 1.5 s later, and after
three failures the contact stays 2D until another is selected, as
before the models moved onto the draw port. A good load retires the
budget, and a model that loads after all is kept.
This commit is contained in:
1 parent
396e7f0deb
commit
5370feb825
23 files changed
+536
-58
No files matched your search
@@ -45,6 +45,7 @@ export const CESIUM_CHECKS = new Set([
|
||||
'draw.lines.segments',
|
||||
'draw.ids',
|
||||
'draw.models',
|
||||
'draw.models.loadFailed',
|
||||
'draw.models.tint',
|
||||
'draw.models.update',
|
||||
'draw.motion',
|
||||
@@ -113,11 +114,16 @@ function nextFrame() {
|
||||
}
|
||||
|
||||
/**
|
||||
* @param {{name?: string, model?: string}} [options] `model`: a glTF URL
|
||||
* for the model checks.
|
||||
* @param {{name?: string, model?: string, missingModel?: string}} [options]
|
||||
* `model`: a glTF URL for the model checks; `missingModel`: one that
|
||||
* fails to load, for the failure check.
|
||||
* @returns {import('../conformance/index.js').ConformanceHarness}
|
||||
*/
|
||||
export function createCesiumHarness({ name = 'cesium', model } = {}) {
|
||||
export function createCesiumHarness({
|
||||
name = 'cesium',
|
||||
model,
|
||||
missingModel,
|
||||
} = {}) {
|
||||
return {
|
||||
name,
|
||||
async create({ viewport, capabilities }) {
|
||||
@@ -157,6 +163,6 @@ export function createCesiumHarness({ name = 'cesium', model } = {}) {
|
||||
toEcef,
|
||||
tolerance: DEFAULT_TOLERANCE,
|
||||
flightPaths: 'endpoints',
|
||||
...(model ? { assets: { model } } : {}),
|
||||
...(model ? { assets: { model, missingModel } } : {}),
|
||||
};
|
||||
}
|
||||
Reference in new issue
Block a user