mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 08:12:24 +00:00
Report model load failures to model sets, and bound the tracked model's retries again
The renderer contract gains an optional event on model draw sets,
`on('loadFailed', (id, message) => ...)`, beside `ready`: a model's url
failed to load, once per failed load. The item stays in the set drawing
what it drew before; removing it and adding it again tries at once. A
renderer that cannot tell a failure may never fire it.
The Cesium draw port fires it once Cesium is done with the frame it
raised the error in, and not for a load that was superseded or whose item
went. The stub fails urls under `stub-fail:`, telling each load once. A
conformance check (`draw.models.loadFailed`) runs on both, with a model
url the dev server does not serve for Cesium.
The flights and military layers use it in place of rewriting every
unloaded model every 5 s. A fleet model whose load failed is removed and
added again 5 s later. The tracked model gets back its per-selection
budget: a failed load is let go and tried again 1.5 s later, and after
three failures the contact stays 2D until another is selected, as
before the models moved onto the draw port. A good load retires the
budget, and a model that loads after all is kept.
This commit is contained in:
1 parent
396e7f0deb
commit
5370feb825
23 files changed
+536
-58
No files matched your search
@@ -19,6 +19,8 @@ const POLICY = {
|
||||
TRACKED_MODEL_MAX_PX: 600,
|
||||
MODEL_HEADING_OFFSET_DEG: 0,
|
||||
FLEET_DR_INTERVAL_MS: 80,
|
||||
TRACKED_MODEL_MAX_LOAD_FAILS: 3,
|
||||
TRACKED_MODEL_RETRY_BACKOFF_MS: 1500,
|
||||
};
|
||||
|
||||
const SPEC = {
|
||||
@@ -247,7 +249,7 @@ test('a failed fleet write leaves the icons in charge and is sent again', () =>
|
||||
assert.equal(f.shown.get('a1'), false);
|
||||
});
|
||||
|
||||
test('a model that has not loaded is written again for the renderer to retry', () => {
|
||||
test('a fleet model whose load failed is loaded again after a wait, not before', () => {
|
||||
const positions = new Map([['a1', near(1)]]);
|
||||
const f = fleetFixture(positions);
|
||||
const realNow = Date.now;
|
||||
@@ -256,18 +258,39 @@ test('a model that has not loaded is written again for the renderer to retry', (
|
||||
try {
|
||||
f.tick();
|
||||
const writes = f.fleet().writes;
|
||||
clock += 60_000;
|
||||
f.tick();
|
||||
assert.equal(
|
||||
f.fleet().writes,
|
||||
writes,
|
||||
'an unchanged loading model is not rewritten every tick',
|
||||
'a model still loading is not rewritten, however long it takes',
|
||||
);
|
||||
clock += 5_000;
|
||||
f.draw.loadFailed(f.fleetId, 'a1');
|
||||
f.removes.length = 0;
|
||||
clock += 4_999;
|
||||
f.tick();
|
||||
assert.deepEqual(f.removes, [], 'not before the wait');
|
||||
assert.equal(f.shown.get('a1'), true, 'the icon carries the contact');
|
||||
clock += 1;
|
||||
f.tick();
|
||||
assert.deepEqual(f.removes, [['a1']], 'removed once the wait is over');
|
||||
assert.ok(f.fleet().items.has('a1'), 'and added again in the same tick');
|
||||
assert.equal(f.state._models.get('a1').failedAt, 0);
|
||||
assert.equal(f.state._models.get('a1').ready, false, 'a fresh load');
|
||||
f.removes.length = 0;
|
||||
clock += 60_000;
|
||||
f.tick();
|
||||
assert.deepEqual(f.removes, [], 'tried again only after another failure');
|
||||
// A renderer's own retry that loads before the layer's: nothing is due.
|
||||
f.draw.loadFailed(f.fleetId, 'a1');
|
||||
f.draw.ready(f.fleetId, 'a1');
|
||||
clock += 60_000;
|
||||
f.tick();
|
||||
assert.deepEqual(f.removes, [], 'a model that loaded is not tried again');
|
||||
assert.equal(
|
||||
f.fleet().writes,
|
||||
writes + 1,
|
||||
'but it is rewritten every few seconds',
|
||||
f.shown.get('a1'),
|
||||
false,
|
||||
'the model takes over once it loads',
|
||||
);
|
||||
} finally {
|
||||
Date.now = realNow;
|
||||
|
||||
Reference in new issue
Block a user