From 5301a0af8dbbf30a6294f9bc935edcc43e2d5673 Mon Sep 17 00:00:00 2001 From: Sameh Khamis Date: Thu, 19 Nov 2026 02:45:21 -0800 Subject: [PATCH] Vue kit: the welcome card's buttons are UiButtons and its glyphs UiIcons SKIP, the three start tiles, BROWSE STORIES, BACK and the main NEXT / ENTER GOD MODE action are ghost UiButtons; the start tiles are pressed toggles, and the others keep aria-disabled so they stay focusable while the card is busy. The tile, tip, Stories and arrow glyphs are UiIcons sized by first-run.css. God mode's preview globe and callouts stay inline SVG drawings. A guard test pins it, the dismiss markup pin allows the kit classes, and the first-run mutation anchors follow the new tile markup. Co-authored-by: Manjunath Paparaju --- docs/VUE-MIGRATION.md | 8 ++++++ scripts/format-scope.json | 1 + scripts/qa-firstrun-mutations.mjs | 8 +++--- src/firstRunExperience.test.mjs | 2 +- src/ui/kit/welcomeControls.test.mjs | 37 +++++++++++++++++++++++++ src/ui/views/WelcomeView.vue | 42 +++++++++++++++-------------- 6 files changed, 73 insertions(+), 25 deletions(-) create mode 100644 src/ui/kit/welcomeControls.test.mjs diff --git a/docs/VUE-MIGRATION.md b/docs/VUE-MIGRATION.md index 35d0deffc9..9dfee07595 100644 --- a/docs/VUE-MIGRATION.md +++ b/docs/VUE-MIGRATION.md @@ -89,6 +89,14 @@ tilt-map button, whose owners still write their state into the DOM. Core's pressable chips and pills (rail card chips, map sources, cities and places) are `UiButton`s too; `UiChip` is a non-interactive label chip, used by the voice card. +The welcome card's buttons (SKIP, the three start tiles, BROWSE STORIES, +BACK and the main NEXT / ENTER GOD MODE action) are ghost `UiButton`s: +the start tiles are pressed toggles, and all but SKIP keep `aria-disabled` +rather than `disabled`, so they stay focusable while the card is busy. Its +tile, tip, Stories and arrow glyphs are `UiIcon`s with `:size="null"`, so +first-run.css still sizes them (`src/ui/kit/welcomeControls.test.mjs` pins +it). God mode's preview globe and callouts stay inline SVG drawings, and +its outbound links stay links. `UiSelect` renders the bare native select (Core's labels sit outside it or come as an `aria-label`) with `v-model`, `options` and `disabled`; options that carry their own attributes come through the slot, a caller's diff --git a/scripts/format-scope.json b/scripts/format-scope.json index 7dc54bc407..abc77b56d7 100644 --- a/scripts/format-scope.json +++ b/scripts/format-scope.json @@ -1343,6 +1343,7 @@ "src/ui/kit/UiDialog.vue", "src/ui/kit/UiDialog.test.mjs", "src/ui/kit/dialogs.test.mjs", + "src/ui/kit/welcomeControls.test.mjs", "src/ui/styles/chip.css", "src/ui/styles/empty-state.css", "src/ui/rail/RailChips.vue", diff --git a/scripts/qa-firstrun-mutations.mjs b/scripts/qa-firstrun-mutations.mjs index 7177daceee..9bce1d3fd6 100644 --- a/scripts/qa-firstrun-mutations.mjs +++ b/scripts/qa-firstrun-mutations.mjs @@ -444,14 +444,14 @@ const MUTATIONS = [ { defect: 'a mission tile is dropped from the menu', file: 'html', - from: ' +

{{ t(TITLES[step - 1]) }}

{{ t(TITLES[step - 1]) }}

@@ -207,22 +209,22 @@ function onSuppress(event) {

{{ t('Start with') }}

- - - +
@@ -230,17 +232,17 @@ function onSuppress(event) {
  • - + {{ t('Turn on layers') }} {{ t('Turn layers on to see flights, ships, cameras, weather and more.') }}
  • - + {{ t('Click anything') }} {{ t('Select a map item to see its details.') }}
  • @@ -248,12 +250,12 @@ function onSuppress(event) {

    {{ t('Go deeper') }}

    @@ -304,10 +306,10 @@ function onSuppress(event) {

    {{ launcher?.status ?? '' }}

    - - + {{ t('BACK') }} + + {{ step < STEPS ? t('NEXT') : t('ENTER GOD MODE') }} +