mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 16:22:20 +00:00
feat(globe): add the engine contract and its test suite
src/globe/contract.js defines the engine-neutral GlobeEngine capabilities (JSDoc), createEngineEvent with Cesium.Event semantics and assertGlobeEngine. src/globe/testing adds a geo-based fake engine for shell tests and an engine-agnostic contract suite that the fake passes in Node. check-import-directions keeps the contract free of cesium, three and @navaramap, and each engine directory free of the other engine.
This commit is contained in:
1 parent
f2fcd82290
commit
528ec75f32
9 files changed
+2036
-1
No files matched your search
@@ -100,6 +100,47 @@ for (const [name, files, pattern] of [
|
||||
},
|
||||
/src\/data\/helper\.js: geo reaches platform\/rendering dependency: cesium/,
|
||||
],
|
||||
[
|
||||
'globe contract imports cesium',
|
||||
{ 'src/globe/contract.js': "import 'cesium';" },
|
||||
/src\/globe\/contract\.js: globe contract reaches engine dependency: cesium/,
|
||||
],
|
||||
[
|
||||
'globe contract imports three',
|
||||
{ 'src/globe/contract.js': "import * as THREE from 'three';" },
|
||||
/globe contract reaches engine dependency: three/,
|
||||
],
|
||||
[
|
||||
'globe testing support imports a Navara package',
|
||||
{ 'src/globe/testing/fakeEngine.js': "import '@navaramap/three';" },
|
||||
/src\/globe\/testing\/fakeEngine\.js: globe contract reaches engine dependency: @navaramap\/three/,
|
||||
],
|
||||
[
|
||||
'globe contract reaches cesium through a helper',
|
||||
{
|
||||
'src/globe/contract.js': "import '../data/helper.js';",
|
||||
'src/data/helper.js': "export * from '@cesium/engine';",
|
||||
},
|
||||
/src\/data\/helper\.js: globe contract reaches engine dependency: @cesium\/engine/,
|
||||
],
|
||||
[
|
||||
'globe contract imports an engine implementation',
|
||||
{
|
||||
'src/globe/contract.js': "import('./navara/index.js');",
|
||||
'src/globe/navara/index.js': '',
|
||||
},
|
||||
/globe contract imports engine implementation: src\/globe\/navara\/index\.js/,
|
||||
],
|
||||
[
|
||||
'Cesium globe engine imports Navara',
|
||||
{ 'src/globe/cesium/engine.js': "import '@navaramap/three';" },
|
||||
/Cesium globe engine imports @navaramap\/three/,
|
||||
],
|
||||
[
|
||||
'Navara globe engine imports Cesium',
|
||||
{ 'src/globe/navara/engine.js': "import { Cartesian3 } from 'cesium';" },
|
||||
/Navara globe engine imports cesium/,
|
||||
],
|
||||
[
|
||||
'browser imports Node without prefix',
|
||||
{ 'src/unused.mjs': "import 'fs/promises';" },
|
||||
@@ -175,6 +216,23 @@ test('geo modules may import each other, and its tests may import cesium', (t) =
|
||||
assert.doesNotThrow(() => checkImportDirections(root));
|
||||
});
|
||||
|
||||
test('globe engines use their own dependencies, and globe tests may import any engine', (t) => {
|
||||
const { root, write } = fixture(t);
|
||||
write('src/geo/math.js', 'export const half = (value) => value / 2;');
|
||||
write('src/globe/contract.js', "export { half } from '../geo/math.js';");
|
||||
write('src/globe/testing/suite.mjs', "import '../contract.js';");
|
||||
write('src/globe/testing/suite.test.mjs', "import 'cesium'; import 'three';");
|
||||
write(
|
||||
'src/globe/cesium/engine.js',
|
||||
"import 'cesium'; import '../contract.js';",
|
||||
);
|
||||
write(
|
||||
'src/globe/navara/engine.js',
|
||||
"import 'three'; import '@navaramap/three'; import '../contract.js';",
|
||||
);
|
||||
assert.doesNotThrow(() => checkImportDirections(root));
|
||||
});
|
||||
|
||||
test('self package imports cannot evade portable ownership', (t) => {
|
||||
const { root, write } = fixture(t, { './view': './src/ui/view.js' });
|
||||
write('src/sources/demo.js', "import '@gods-eye-view/core/view';");
|
||||
|
||||
Reference in new issue
Block a user