mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-17 00:32:21 +00:00
Stories: a teardown that times out cannot undo the restored view
directorSettled now tells a timeout from settlement, and on a timeout revokes the scene's layer cleanup still in flight before Close puts the view back.
This commit is contained in:
1 parent
0a39b05cdb
commit
4fa80fb18c
5 files changed
+105
-8
No files matched your search
@@ -2031,6 +2031,42 @@ test('startScene resolves its result, resumes after a shot without a scene id, a
|
||||
} finally { await director.destroy(); restore(); }
|
||||
});
|
||||
|
||||
test('a revoked scene release turns no further layer off', async () => {
|
||||
const project = structuredClone(PROJECT_FIXTURE);
|
||||
project.scenes[0].releaseLayerIds = ['flights', 'traffic'];
|
||||
const { director, dataManager, restore } = makeDirector({ project });
|
||||
try {
|
||||
const calls = [];
|
||||
let finishFirst;
|
||||
dataManager.setEnabled = (id, enabled, { signal }) => {
|
||||
calls.push({ id, enabled, signal });
|
||||
// The first layer's disable hangs, as a stuck teardown does.
|
||||
return new Promise((resolve) => {
|
||||
finishFirst = resolve;
|
||||
});
|
||||
};
|
||||
const releasing = director._releaseSceneLayers(director._project.scenes[0]);
|
||||
await settle();
|
||||
assert.deepEqual(calls.map(({ id }) => id), ['flights']);
|
||||
director.revokeSceneRelease();
|
||||
assert.equal(calls[0].signal.aborted, true, 'the disable under way is aborted');
|
||||
finishFirst(true);
|
||||
assert.equal(await releasing, false);
|
||||
assert.deepEqual(
|
||||
calls.map(({ id }) => id),
|
||||
['flights'],
|
||||
'the next layer is never turned off',
|
||||
);
|
||||
// A release started afterwards has its say again.
|
||||
dataManager.setEnabled = async (id, enabled, { signal }) => {
|
||||
calls.push({ id, enabled, signal });
|
||||
return true;
|
||||
};
|
||||
assert.equal(await director._releaseSceneLayers(director._project.scenes[0]), true);
|
||||
assert.deepEqual(calls.slice(1).map(({ id }) => id), ['flights', 'traffic']);
|
||||
} finally { await director.destroy(); restore(); }
|
||||
});
|
||||
|
||||
/** Drive frame-by-frame camera motion headlessly for one test. */
|
||||
function installAnimationFrames() {
|
||||
const original = globalThis.requestAnimationFrame;
|
||||
|
||||
Reference in new issue
Block a user