mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 16:22:20 +00:00
fix(globe): the Navara follow orbits on drag and zooms to the floor
Review of Task 5: while following on Navara a left drag panned the globe about the ground point under the cursor (range 2,154 m → 54,136 m) and the wheel zoomed toward that point (462 m after 40 notches, Cesium stops at the 150 m floor). While a follow runs, Navara's spin, zoom and tilt are now suspended (input.suspendCameraInputs, which gives the app's own setCameraInputs choice back after the release) and followGestures.js turns a drag into heading and pitch of the ENU offset (a canvas width is one turn, its height half a turn; elevation kept within 2°-89°) and a wheel notch into 20 % of its range, never inside the minimum range, as Cesium's EntityView orbits the target. The offset is no longer read back from a camera the follow alone moves. Also (review item 7): a follow requests a render only when the target, the offset or a gesture changed, so a still target lets Navara idle. The contract follow check drags (range within ±5 %, target within 3 px) and turns the wheel 40 notches (never below 149 m, ends within 5 % of 150 m) on both engines with real input (qa-globe-contract's pointer gains drag and wheel); after stop it waits for Cesium's gesture inertia to end before checking that the camera is free. Contract: Cesium 73/73, Navara 79/79.
This commit is contained in:
1 parent
68ff4e1c25
commit
4e195dac6b
9 files changed
+362
-15
No files matched your search
@@ -111,6 +111,15 @@ export function createNavaraInput(
|
||||
passive: true,
|
||||
});
|
||||
|
||||
let suspended = 0;
|
||||
const sendCameraInputs = () => {
|
||||
const enabled = cameraInputs && suspended === 0;
|
||||
input.setCameraOptions({
|
||||
enableSpin: enabled,
|
||||
enableZoom: enabled,
|
||||
enableTilt: enabled,
|
||||
});
|
||||
};
|
||||
const input = {
|
||||
on(type, listener, options = {}) {
|
||||
const { modifier, pick, drill } = normalizeInputOptions(type, options);
|
||||
@@ -128,11 +137,23 @@ export function createNavaraInput(
|
||||
},
|
||||
setCameraInputs(enabled) {
|
||||
cameraInputs = Boolean(enabled);
|
||||
input.setCameraOptions({
|
||||
enableSpin: cameraInputs,
|
||||
enableZoom: cameraInputs,
|
||||
enableTilt: cameraInputs,
|
||||
});
|
||||
sendCameraInputs();
|
||||
},
|
||||
/**
|
||||
* Navara-only: Navara's spin, zoom and tilt off until the returned
|
||||
* release (the follow camera takes drag and wheel itself); the app's
|
||||
* setCameraInputs choice comes back after the last release.
|
||||
*/
|
||||
suspendCameraInputs() {
|
||||
suspended++;
|
||||
sendCameraInputs();
|
||||
let released = false;
|
||||
return () => {
|
||||
if (released) return;
|
||||
released = true;
|
||||
suspended--;
|
||||
sendCameraInputs();
|
||||
};
|
||||
},
|
||||
/**
|
||||
* Navara-only extension: camera controller options (zoom distances,
|
||||
|
||||
Reference in new issue
Block a user