mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-05 10:53:59 +00:00
docs: point contributors at the per-feature regression gates (#271)
CONTRIBUTING.md named only npm run build, npm test and npm run test:track, so a contributor following it literally never learns that most features have a dedicated gate in scripts/qa-*.mjs. Today 25 of the 40 gates are not named in CURRENT-STATE.md either, so for those there was nothing in the written guide to find them by. Point at the directory rather than transcribing a list that would go stale the same way: every gate already opens with a comment saying what it asserts and how to run it, so `ls scripts/qa-*.mjs` plus the script header is the canonical, self-maintaining reference. Also state plainly that CI runs neither test:track nor any qa gate, since that is what makes running them locally matter.
This commit is contained in:
1 parent
0d41b6be54
commit
4b161ea7af
1 file changed
+32
-1
+32
-1
@@ -37,6 +37,37 @@ configuration through the development app or environment file. Unknown API
|
|||||||
paths return JSON 404 responses. Vite preview is for checking a local build;
|
paths return JSON 404 responses. Vite preview is for checking a local build;
|
||||||
it is not a production server.
|
it is not a production server.
|
||||||
|
|
||||||
|
## Feature regression gates
|
||||||
|
|
||||||
|
Those three are the baseline, not the whole story. Most features also have a
|
||||||
|
dedicated headless gate under `scripts/qa-*.mjs` that drives the real app and
|
||||||
|
asserts that feature's contract. **Run the gate covering whatever you touched**,
|
||||||
|
and say which one you ran in the PR.
|
||||||
|
|
||||||
|
The scripts are the canonical list, and each one documents itself:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
ls scripts/qa-*.mjs # every gate
|
||||||
|
head -20 scripts/qa-radio.mjs # what this gate proves, and how to run it
|
||||||
|
```
|
||||||
|
|
||||||
|
Every gate opens with a comment naming what it asserts. Most take
|
||||||
|
`--url http://localhost:<port>` and need a dev server up; some need a specific
|
||||||
|
provider key or a particular port, and the header says which. Run them directly
|
||||||
|
with `node scripts/qa-<name>.mjs`; only a couple (`qa:map-source-tray`,
|
||||||
|
`qa:transit`) have an `npm run` alias.
|
||||||
|
|
||||||
|
If you aren't sure which gate covers your change, search `docs/CURRENT-STATE.md`
|
||||||
|
for the feature: it names the gate for many of them, and it's the authoritative
|
||||||
|
runtime reference either way.
|
||||||
|
|
||||||
|
> **CI does not cover this for you.** The workflow runs the setup policy
|
||||||
|
> checks, the formatting and package-boundary checks, the unit suite and the
|
||||||
|
> production build, plus a Windows onboarding job. It runs neither
|
||||||
|
> `npm run test:track` nor any `qa-*.mjs` gate — both need a live dev server
|
||||||
|
> and a browser. For anything outside the unit suite, your local run
|
||||||
|
> is the only check before it reaches `main`.
|
||||||
|
|
||||||
## Good first contributions
|
## Good first contributions
|
||||||
|
|
||||||
The highest-leverage places to jump in:
|
The highest-leverage places to jump in:
|
||||||
@@ -82,7 +113,7 @@ ownership and adoption process.
|
|||||||
## Pull requests
|
## Pull requests
|
||||||
|
|
||||||
1. Branch off `main`.
|
1. Branch off `main`.
|
||||||
2. Keep `npm run build`, `npm test`, and `npm run test:track` green and avoid new console errors.
|
2. Keep `npm run build`, `npm test`, and `npm run test:track` green and avoid new console errors, plus the [feature gate](#feature-regression-gates) for the area you touched.
|
||||||
3. If you change runtime behavior, update `docs/CURRENT-STATE.md` and `CHANGELOG.md` in the same PR.
|
3. If you change runtime behavior, update `docs/CURRENT-STATE.md` and `CHANGELOG.md` in the same PR.
|
||||||
4. If you add or change a data source, update [DATA_SOURCES.md](DATA_SOURCES.md) with its license and attribution. **Don't add data you don't have the right to redistribute** — fetch it at runtime instead.
|
4. If you add or change a data source, update [DATA_SOURCES.md](DATA_SOURCES.md) with its license and attribution. **Don't add data you don't have the right to redistribute** — fetch it at runtime instead.
|
||||||
5. Describe what you changed and how you verified it (screenshots welcome for anything visual).
|
5. Describe what you changed and how you verified it (screenshots welcome for anything visual).
|
||||||
|
|||||||
Reference in new issue
Block a user