mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-19 01:32:19 +00:00
Stories: phone entry, centred framing, review follow-ups
- On GEV's phone layout, where neither the style readout nor the account avatar shows, the Stories button goes icon-only under the corner-actions column instead of covering the top row of icon buttons. - Explore frames its start view and a picked story in the middle of the map it leaves visible (beside the feed, above the phone sheet), with one short correction if that area moved during the flight. - The share icon stays visible in icon-only header buttons. - A world clock nothing moved while Stories was open (no jump, same mode and rate) is left alone on Close. - Card images use the globe's own Esri tile URL; the credit list keeps the application's full-screen placement on phones. - Tests cover the live and playing clock restores, the clock coming back after the share state, the tile-settling hold being released (settled, 10 s, Close), the visible-map aim, and the near-end Play fix in the director's real order. One changelog fragment covers the PR.
This commit is contained in:
1 parent
8a0953c35d
commit
472cc35c47
13 files changed
+351
-38
No files matched your search
+18
-5
@@ -34,13 +34,26 @@ export function creditPlacement({ map, feed, width, height }) {
|
||||
* Where the Stories button sits: just left of the leftmost visible control
|
||||
* in GEV's top-right corner — the ACTIVE STYLE readout in GEV, the account
|
||||
* avatar (with or beside the readout) in GEV Hosted — top-aligned with it.
|
||||
* Where none of those shows (GEV's phone layout, whose top row of icon
|
||||
* buttons spans the corner), it goes icon-only just under the right-hand
|
||||
* column of corner actions, aligned with its right edge.
|
||||
* @param {Array<DOMRect|null|undefined>} corner The corner controls' boxes.
|
||||
* @param {number} width The window's width.
|
||||
* @returns {{top: number, right: number}} Pixels from the top and right.
|
||||
* @param {DOMRect|null} [column] The corner-actions column's box.
|
||||
* @returns {{top: number, right: number, compact?: boolean}} Pixels from
|
||||
* the top and right; `compact` for the icon-only button.
|
||||
*/
|
||||
export function entryPlacement(corner, width) {
|
||||
export function entryPlacement(corner, width, column = null) {
|
||||
const shown = corner.filter((r) => r && r.width > 0 && r.height > 0);
|
||||
if (!shown.length) return { top: 14, right: 14 };
|
||||
const left = shown.reduce((a, b) => (b.left < a.left ? b : a));
|
||||
return { top: left.top, right: width - left.left + 10 };
|
||||
if (shown.length) {
|
||||
const left = shown.reduce((a, b) => (b.left < a.left ? b : a));
|
||||
return { top: left.top, right: width - left.left + 10 };
|
||||
}
|
||||
if (column && column.width > 0 && column.height > 0)
|
||||
return {
|
||||
top: Math.round(column.bottom + 8),
|
||||
right: Math.round(width - column.right),
|
||||
compact: true,
|
||||
};
|
||||
return { top: 14, right: 14 };
|
||||
}
|
||||
Reference in new issue
Block a user