mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-17 00:32:21 +00:00
Draw the last native world labels through the label overlay
The Directions A and B letters and a data pack's media label were the two Cesium text labels left, kept by an allow-list in noCesiumLabels.test.mjs. Both now publish entries to the shared world-overlay host, and the allow-list is gone, so any Cesium label in src is a test failure. Directions publishes the letters to the directions-markers source; the markers keep only their points. A clicked endpoint's letter hangs over the surface that was clicked. One placed without a click stays hidden until its ground-floor cell resolves, then requests a render, so a still camera shows it; a cell that settles with no height falls back to the ellipsoid. Each position is computed once. A pack resource handle gains label(entry). The application passes its shared overlay host to SceneDirector through dataPacks.overlayHost; without one a media pack fails to load rather than drawing a native label. Each labelled resource takes a source from a pool and returns it on dispose, as the host never removes a source, so two presentations of one pack never clear each other's labels and repeat loads add no sources. A label written after dispose is ignored. The media label is protected, so it always draws as before. Live (Denver, keyless globe): a clicked A and a programmatic B both anchor on their dots over 1.58 km ground. Documented in docs/CURRENT-STATE.md and docs/DIRECTOR-DATA-PACKS.md.
This commit is contained in:
1 parent
18d6e3292d
commit
464c29a9ed
12 files changed
+382
-44
No files matched your search
@@ -10,6 +10,8 @@ import { useDataPacksStore } from '../../ui/stores/dataPacks.js';
|
||||
import DataPacks from '../../ui/views/panels/DataPacks.vue';
|
||||
import { createPackPresentations } from './presentation.js';
|
||||
|
||||
const overlayHost = { setEntries() {}, clearSource() {} };
|
||||
|
||||
const ANCHOR = { id: 'here', lat: 30, lon: -97, alt: 10 };
|
||||
const pack = (id, url) => ({
|
||||
id,
|
||||
@@ -29,7 +31,10 @@ function fixture(t) {
|
||||
entities: { add: (spec) => spec, remove() {} },
|
||||
};
|
||||
const store = useDataPacksStore(pinia);
|
||||
const presentations = createPackPresentations(viewer, new Map(), { store });
|
||||
const presentations = createPackPresentations(viewer, new Map(), {
|
||||
store,
|
||||
overlayHost,
|
||||
});
|
||||
t.after(() => app.unmount());
|
||||
const settle = async () => {
|
||||
for (let flush = 0; flush < 4; flush += 1) await nextTick();
|
||||
@@ -118,7 +123,10 @@ test('each set of presentations keeps its own panel', async (t) => {
|
||||
const { presentations, viewer, store, settle, $$ } = fixture(t);
|
||||
const one = await media(presentations, 'one');
|
||||
await media(presentations, 'two');
|
||||
const later = createPackPresentations(viewer, new Map(), { store });
|
||||
const later = createPackPresentations(viewer, new Map(), {
|
||||
store,
|
||||
overlayHost,
|
||||
});
|
||||
const three = await media(later, 'three');
|
||||
await settle();
|
||||
const cards = () =>
|
||||
|
||||
Reference in new issue
Block a user