mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-20 02:02:21 +00:00
fix(annotations): keep an arrow whose unsampled far end is past the 0 m horizon (#1277)
An endpoint outside the frustum is not sampled and projects at its 0 m stand-in height. The horizon test then judged that stand-in, so an arrow whose far end lies beyond the sea-level horizon but above it at its real height disappeared with its label. Such an endpoint now skips the point horizon test; the height-range test still drops endpoints that are provably hidden, and settled or in-frustum anchors keep the point test. Adds a regression with a real frustum and occluder (camera 100 m up, far end 56 km away on 100 m terrain). CURRENT-STATE and the changelog now say the 32-sample budget applies per projection pass, and the redundant helper comment in the test is gone.
This commit is contained in:
1 parent
8767eb23ab
commit
40daecadbe
4 files changed
+112
-13
No files matched your search
@@ -148,12 +148,13 @@ injection.
|
||||
Screen annotations skip hidden records and, before surface sampling, reject an
|
||||
unsettled anchor only when its whole accepted height range (-430 to 9000 m) is
|
||||
behind the camera or below the globe horizon; a settled height is tested as the
|
||||
actual point. Anchors outside the conservative frustum still project at their
|
||||
cached or zero height, so a partly visible arrow keeps its connector, but do
|
||||
not sample. Unresolved visible heights share a 32-sample projection-pass budget,
|
||||
served oldest-refused first, retry at most once per second per anchor on
|
||||
rendered frames, and retain no extra timer or listener. Validated heights remain
|
||||
settled in the bounded cache.
|
||||
actual point. Anchors outside the conservative frustum do not sample and still
|
||||
project at their cached or zero height, without the horizon test that this
|
||||
stand-in height cannot decide, so a partly visible arrow keeps its connector.
|
||||
Unresolved visible heights share a 32-sample budget per projection pass (each
|
||||
board change and each rendered frame runs one), served oldest-refused first,
|
||||
retry at most once per second per anchor, and retain no extra timer or
|
||||
listener. Validated heights remain settled in the bounded cache.
|
||||
|
||||
Terrain height requests accept at most 64 points, matching the browser service's
|
||||
existing batch size and one bounded upstream chunk. Larger requests return HTTP
|
||||
|
||||
Reference in new issue
Block a user