mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 08:12:24 +00:00
i18n: fix the final pre-merge review findings
Fixes the P1 and the confirmed P2 findings of the final review of the
i18n branch.
- CI: the air-quality model no longer imports i18n (portable module),
so check:boundaries passes again.
- Air quality layer: named in the layer panel, HUD and voice; its
Weather card, bands and errors translate. A test keeps the layer-name
table in step with the layer registry.
- Layer statuses that still reached ru/es in English: GNSS, CelesTrak,
Transit loading and feed errors, launches, perimeters, ALPR, ECCC,
wind "field unavailable", Local ADS-B streaming lines.
- Voice and HUD: preset ids show city names ("Fly to San Francisco"),
the HUD city translates, cockpit refusals cover frame, aircraft and
satellite; empty Transit notes translate on the analyst card.
- tn() keeps a caller's formatted count ("12,345 map objects").
- Cyber HUD: the language button no longer covers the bottom-right
card or the cockpit position readout.
- CCTV buttons wrap only in non-English locales; English layout matches
main again.
- Switching language asks first when Provider Settings holds unsaved
keys.
Catalogs: es/ru 2611 messages each, complete.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
1 parent
fada8b161b
commit
3adce33cc6
43 files changed
+1350
-97
No files matched your search
@@ -0,0 +1,90 @@
|
||||
// N-03: layer status texts produced without msg()/catalog entries (GNSS,
|
||||
// Transit, CelesTrak, AQHI) stay English in the es/ru DATA LAYERS row.
|
||||
// Place: src/ui/layerStatusLocale.test.mjs
|
||||
import assert from 'node:assert/strict';
|
||||
import test from 'node:test';
|
||||
import { setLocale } from '../i18n/index.js';
|
||||
import { LayerPanel } from './layerPanel.js';
|
||||
|
||||
const row = (id, stats) =>
|
||||
LayerPanel.prototype._buildMetaText({ id, enabled: true, stats });
|
||||
const now = Date.now();
|
||||
|
||||
// [layer id, stats, English fragment that must not reach the row]
|
||||
const cases = [
|
||||
[
|
||||
'gnss-integrity',
|
||||
{
|
||||
count: 0,
|
||||
error: 'GNSS feed rate limited (HTTP 429)',
|
||||
source: 'GNSS',
|
||||
lastUpdate: now,
|
||||
},
|
||||
'rate limited',
|
||||
],
|
||||
[
|
||||
'gnss-integrity',
|
||||
{
|
||||
count: 0,
|
||||
error: 'GNSS feed unavailable (HTTP 503)',
|
||||
source: 'GNSS',
|
||||
lastUpdate: now,
|
||||
},
|
||||
'feed unavailable',
|
||||
],
|
||||
[
|
||||
'transit',
|
||||
{
|
||||
count: 0,
|
||||
error: 'GO Transit feed unavailable',
|
||||
source: 'GTFS-RT',
|
||||
lastUpdate: now,
|
||||
},
|
||||
'feed unavailable',
|
||||
],
|
||||
[
|
||||
'transit',
|
||||
{
|
||||
count: 0,
|
||||
loading: true,
|
||||
loadingLabel: 'Loading GO Transit, Metro Transit',
|
||||
source: 'GTFS-RT',
|
||||
},
|
||||
'Loading',
|
||||
],
|
||||
[
|
||||
'satellites',
|
||||
{
|
||||
count: 10,
|
||||
error: '1 CelesTrak group unavailable',
|
||||
source: 'CelesTrak',
|
||||
lastUpdate: now,
|
||||
},
|
||||
'group unavailable',
|
||||
],
|
||||
[
|
||||
'air-quality',
|
||||
{
|
||||
count: 0,
|
||||
error: 'ECCC request timed out',
|
||||
source: 'ECCC',
|
||||
lastUpdate: now,
|
||||
},
|
||||
'request timed out',
|
||||
],
|
||||
];
|
||||
|
||||
for (const locale of ['es', 'ru']) {
|
||||
test(`${locale}: layer status texts are translated in the row`, () => {
|
||||
setLocale(locale);
|
||||
try {
|
||||
const english = cases
|
||||
.map(([id, stats, marker]) => [id, row(id, stats), marker])
|
||||
.filter(([, text, marker]) => text.includes(marker))
|
||||
.map(([id, text]) => `${id}: ${text}`);
|
||||
assert.deepEqual(english, []);
|
||||
} finally {
|
||||
setLocale('en');
|
||||
}
|
||||
});
|
||||
}
|
||||
Reference in new issue
Block a user