mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 08:12:24 +00:00
test: compare DOM nodes by identity, never through assert.equal
A failed assert.equal or deepEqual prints both operands, and a happy-dom node reaches the whole page and window: printing one exhausted memory and took the machine down. assertSameNode() compares identity and fails with a short description of each node; every node comparison in the happy-dom tests uses it.
This commit is contained in:
1 parent
e949584c0a
commit
3a2acf9b0f
8 files changed
+46
-20
No files matched your search
@@ -1,6 +1,7 @@
|
||||
import '../testSupport/registerDom.mjs';
|
||||
import test from 'node:test';
|
||||
import assert from 'node:assert/strict';
|
||||
import { assertSameNode } from '../testSupport/domAssert.mjs';
|
||||
import { nextTick } from 'vue';
|
||||
import { createRailCards } from './railCards.js';
|
||||
import { railDocumentFixture as railFixture } from './railTestFixture.mjs';
|
||||
@@ -94,7 +95,7 @@ test('footer buttons retain focus and current callbacks; links use safe new tabs
|
||||
},
|
||||
]),
|
||||
]);
|
||||
assert.equal(f.document.activeElement, button);
|
||||
assertSameNode(f.document.activeElement, button);
|
||||
assert.equal(button.parentElement.tagName, 'FOOTER');
|
||||
assert.equal(
|
||||
f.find((n) => n.className === 'rail-card-action-hint').textContent,
|
||||
@@ -200,7 +201,7 @@ test('setting ranges stay below presets and commit expensive filters on release'
|
||||
assert.equal(slider.value, '53', 'release keeps the handle until the owner');
|
||||
view.update([model(53)]);
|
||||
assert.equal(slider.value, '53');
|
||||
assert.equal(f.document.activeElement, slider);
|
||||
assertSameNode(f.document.activeElement, slider);
|
||||
slider.value = '41';
|
||||
slider.dispatchEvent(new Event('input'));
|
||||
await nextTick();
|
||||
@@ -334,7 +335,7 @@ test('labelled rows, lists and results retain focus and dispatch current params'
|
||||
const chip = f.find((n) => n.dataset.chipId === 'motion');
|
||||
chip.focus();
|
||||
view.update([model(true)]);
|
||||
assert.equal(f.document.activeElement, chip);
|
||||
assertSameNode(f.document.activeElement, chip);
|
||||
chip.click();
|
||||
assert.deepEqual(calls.at(-1), ['a', { paused: false }]);
|
||||
const storm = f.find(
|
||||
|
||||
Reference in new issue
Block a user