Drop payload mass checks that existing tests already pin

Blank, negative and non-numeric masses are covered by the existing missing-payload test; keep the amount fallback and the fractional string mass.
This commit is contained in:
Sameh Khamis committed 2026-10-16 15:25:46 -07:00
1 parent 300447c9ce
commit 393f42aed5
1 file changed
+7 -24
+7 -24
View File
@@ -803,7 +803,7 @@ test('normalizes recovery stage coordinates, downrange distance, and flight numb
assert.equal(expendable.success, null); assert.equal(expendable.success, null);
}); });
test('normalizes payload edge cases for missing, blank, or invalid mass and non-numeric amounts', () => { test('normalizes payload amounts and fractional string masses', () => {
const launches = normalizeRocketLaunches( const launches = normalizeRocketLaunches(
{ {
results: [ results: [
@@ -817,33 +817,17 @@ test('normalizes payload edge cases for missing, blank, or invalid mass and non-
{ {
id: 601, id: 601,
amount: 'not-a-number', amount: 'not-a-number',
payload: { payload: { id: 11, name: 'Unknown Amount Payload' },
id: 11,
name: 'Empty Mass Payload',
mass: '',
},
}, },
{ {
id: 602, id: 602,
amount: 3, amount: 3,
payload: { payload: { id: 12, name: 'Triple Payload' },
id: 12,
name: 'Negative Mass Payload',
mass: -50,
},
}, },
{ {
id: 603, id: 603,
payload: { payload: {
id: 13, id: 13,
name: 'Non-Numeric Mass Payload',
mass: 'unknown',
},
},
{
id: 604,
payload: {
id: 14,
name: 'Valid Fractional Mass Payload', name: 'Valid Fractional Mass Payload',
mass: '12.75', mass: '12.75',
}, },
@@ -856,14 +840,13 @@ test('normalizes payload edge cases for missing, blank, or invalid mass and non-
NOW, NOW,
); );
// Blank, negative and non-numeric masses are pinned by "missing payload
// details stay unknown without inventing mass or classification".
const payloads = launches[0].payloads; const payloads = launches[0].payloads;
assert.equal(payloads.length, 4); assert.equal(payloads.length, 3);
assert.equal(payloads[0].amount, 1); assert.equal(payloads[0].amount, 1);
assert.equal(payloads[0].massKg, null);
assert.equal(payloads[1].amount, 3); assert.equal(payloads[1].amount, 3);
assert.equal(payloads[1].massKg, null); assert.equal(payloads[2].massKg, 12.75);
assert.equal(payloads[2].massKg, null);
assert.equal(payloads[3].massKg, 12.75);
}); });
test('keeps payload and recovery collections empty when LL2 does not disclose them', () => { test('keeps payload and recovery collections empty when LL2 does not disclose them', () => {