Animate traffic on the frame port and follow the camera through the camera port

The traffic lifecycle listens on the frame port's preRender and on the
camera port's changed (at its own 5% threshold) and moveEnd, instead of
the scene's preRender, the camera's events and the shared
percentageChanged ledger. It no longer reaches Cesium and leaves the
allow-list; rendering.js, still listed for the surface identity, tile
readiness and draped-line support, now loads the unbound camera and
globe factories for the layer.
This commit is contained in:
Sameh Khamis committed 2026-11-07 23:16:11 -08:00
1 parent 5715bf9df3
commit 38e0750715
11 files changed
+163 -46

No files matched your search

+28 -3
View File
@@ -3617,7 +3617,7 @@ test('reject then selected history backfill cannot resurrect a 111 km displaceme
assert.equal(entry.track.resets, 0);
});
test('actual Traffic and Transit lifecycles retain sensitivity in every enable/disable order, Bikeshare among them', async (t) => {
test('the actual Transit lifecycle retains its sensitivity in every enable/disable order, Traffic and Bikeshare among them', async (t) => {
const { createLifecycle: trafficLifecycle } =
await import('../traffic/lifecycle.js');
const { createLifecycle: bikeLifecycle } =
@@ -3670,15 +3670,33 @@ test('actual Traffic and Transit lifecycles retain sensitivity in every enable/d
const bikeViewer = {};
const unbindBike = bindRenderer(bikeViewer, { camera: bikeCamera.port });
t.after(unbindBike);
// So does traffic, which animates on its renderer's frame port.
const trafficCamera = fakeCameraPort();
const trafficViewer = {};
const trafficFrames = new Set();
const unbindTraffic = bindRenderer(trafficViewer, {
camera: trafficCamera.port,
frame: {
on(_phase, cb) {
trafficFrames.add(cb);
return () => trafficFrames.delete(cb);
},
requestRender: noop,
},
});
t.after(unbindTraffic);
const layers = {
traffic,
traffic: {
enable: () => traffic.enable(trafficViewer),
disable: () => traffic.disable(trafficViewer),
},
bikeshare: {
enable: () => bike.enable(bikeViewer),
disable: () => bike.disable(bikeViewer),
},
transit: app.layer,
};
const claimants = new Set(['traffic', 'transit']);
const claimants = new Set(['transit']);
const orders = [
['traffic', 'bikeshare', 'transit'],
['traffic', 'transit', 'bikeshare'],
@@ -3696,6 +3714,10 @@ test('actual Traffic and Transit lifecycles retain sensitivity in every enable/d
if (claimants.has(id)) active.add(id);
if (id === 'bikeshare')
assert.equal(bikeCamera.listenerCount('changed'), 1);
if (id === 'traffic') {
assert.equal(trafficCamera.listenerCount('changed'), 1);
assert.equal(trafficFrames.size, 1);
}
assert.equal(
app.viewer.camera.percentageChanged,
active.size ? 0.05 : 0.5,
@@ -3719,6 +3741,9 @@ test('actual Traffic and Transit lifecycles retain sensitivity in every enable/d
);
}
assert.equal(bikeCamera.listenerCount('changed'), 0);
assert.equal(trafficCamera.listenerCount('changed'), 0);
assert.equal(trafficCamera.listenerCount('moveEnd'), 0);
assert.equal(trafficFrames.size, 0);
}
} finally {
for (const layer of Object.values(layers)) layer.disable(app.viewer);