Recent Imagery: keep a picked day when the automatic preview probes empty

A card click on an unprobed day follows that day while the automatic
preview stays on the map. If the automatic day then probed empty, the
hand-over to the next ranked day overwrote that follow, so neither the
picked day nor the successor draped when their probes came back
present. The hand-over now leaves the slot to a day the user picked that
is still being probed or waiting out the arrow-key debounce.

Also covers the off-screen successor with empty days shown: once the
visible days probe empty, the successor's probe is queued (the re-request
that came with the merge from main) and the day drapes when present.
This commit is contained in:
German Khokhlov committed 2026-11-20 00:33:12 +04:00
1 parent ea8ad63632
commit 35f69e84df
4 files changed
+56 -3

No files matched your search

+3 -1
View File
@@ -320,7 +320,9 @@ export function createRecentImageryLayer({
_previewKey = null;
_auto = null;
changed = true;
if (wasAuto) autoPreview(preview.key);
// A day the user picked meanwhile, still being probed or debounced,
// takes the slot instead of the next ranked day.
if (wasAuto && !_followKey && !_pending) autoPreview(preview.key);
}
// A followed day that turns out empty is dropped; an automatic one hands
// over to the next ranked day.
+50
View File
@@ -1266,6 +1266,56 @@ test('empty auto VIIRS re-requests a cancelled successor', async () => {
assert.deepEqual(f.drapes(), { a: `${next}|none`, b: null });
});
test('with empty days shown, an off-screen successor is probed once the visible days return empty', async () => {
const f = fixture();
const days = dailyViirs();
f.layer.setSources({ hls: false });
f.layer.setShowUnavailable(true);
f.layer.setVisibleRange(0, 5);
await f.ready(days);
const offscreen = days.findIndex(
({ key }) => !f.thumbnails.requested.includes(key),
);
assert.ok(offscreen > 5, 'the first unrequested day is off-screen');
for (const { key } of days.slice(0, offscreen)) {
assert.equal(f.diag().following, key);
f.thumbnails.probe(key, 'empty');
}
const successor = days[offscreen].key;
assert.equal(f.diag().following, successor);
assert.equal(f.snap().focus.key, successor);
assert.deepEqual(f.thumbnails.requests.at(-1), [successor, 0]);
assert.ok(f.thumbnails.retained.at(-1).includes(successor));
f.thumbnails.probe(successor, 'present');
assert.equal(f.snap().preview.key, successor);
assert.deepEqual(f.drapes(), { a: `${successor}|none`, b: null });
});
test('a pick still being probed or debounced survives a late empty result for the automatic preview', async () => {
const f = fixture();
await f.ready([CANDIDATES[0], CANDIDATES[1], CANDIDATES[3]]);
assert.equal(f.snap().preview.key, S18);
assert.equal(f.layer.preview(V15), false);
assert.equal(f.diag().following, V15);
f.thumbnails.probe(S18, 'empty');
assert.equal(f.diag().following, V15, 'the pick is kept');
assert.equal(f.snap().focus.key, V15);
f.thumbnails.probe(V21, 'present');
f.thumbnails.probe(V15, 'present');
assert.equal(f.snap().preview.key, V15);
assert.deepEqual(f.drapes(), { a: `${V15}|none`, b: null });
// An arrow-key pick waiting out the debounce is kept too.
const g = fixture();
await g.ready();
g.thumbnails.setStatus(V15, 'present');
g.layer.focus(3);
assert.equal(g.diag().pending, V15);
g.thumbnails.probe(S18, 'empty');
assert.equal(g.owned().a, null, 'no other day drapes meanwhile');
g.timers.flush();
assert.equal(g.snap().preview.key, V15);
});
test('restored pins outside the visible strip window are probed and swipe once present', async () => {
const f = fixture();
const days = dailyViirs();