mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 08:12:24 +00:00
Give the Cesium renderer the contract's listener rules and error channel
Frame-phase and draw-set ready listeners now run in subscription order,
skip one removed during delivery, defer one added during it, and hand a
throw to the renderer's error listeners (or reportError) instead of into
Cesium's render loop. The renderer gains on('error' | 'contextLost' |
'contextRestored'); Cesium cannot restore a lost context, so it never sends
contextRestored. Dispose clears every list. renderer.listeners joins the
Cesium checks.
This commit is contained in:
1 parent
2e0af3dc0d
commit
35a73b6fda
6 files changed
+144
-19
No files matched your search
@@ -1,7 +1,11 @@
|
||||
import assert from 'node:assert/strict';
|
||||
import * as Cesium from 'cesium';
|
||||
import test from 'node:test';
|
||||
import { cesiumCapabilities, createCesiumPorts } from './ports.js';
|
||||
import {
|
||||
cesiumCapabilities,
|
||||
createCesiumPorts,
|
||||
listenerList,
|
||||
} from './ports.js';
|
||||
|
||||
test('capabilities follow what the scene supports', () => {
|
||||
assert.deepEqual(cesiumCapabilities({}), ['models']);
|
||||
@@ -27,6 +31,48 @@ test('a caller can ask for fewer capabilities, never more', () => {
|
||||
assert.deepEqual(cesiumCapabilities({}, new Set(['sampleHeight'])), []);
|
||||
});
|
||||
|
||||
test('a listener list keeps the listener rules', () => {
|
||||
const errors = [];
|
||||
const list = listenerList((error) => errors.push(error));
|
||||
const seen = [];
|
||||
let offB = () => {};
|
||||
list.on(() => {
|
||||
seen.push('a');
|
||||
offB();
|
||||
list.on(() => seen.push('late'));
|
||||
});
|
||||
offB = list.on(() => seen.push('b'));
|
||||
list.on(() => {
|
||||
throw new Error('listener');
|
||||
});
|
||||
const c = () => seen.push('c');
|
||||
list.on(c);
|
||||
const offC2 = list.on(c);
|
||||
list.fire();
|
||||
assert.deepEqual(seen, ['a', 'c', 'c']);
|
||||
assert.equal(errors.length, 1);
|
||||
offC2();
|
||||
seen.length = 0;
|
||||
list.fire();
|
||||
assert.deepEqual(seen, ['a', 'c', 'late']);
|
||||
list.clear();
|
||||
assert.equal(list.size, 0);
|
||||
});
|
||||
|
||||
test('a listener that clears its list stops the rest of the event', () => {
|
||||
const list = listenerList((error) => {
|
||||
throw error;
|
||||
});
|
||||
const seen = [];
|
||||
list.on(() => {
|
||||
seen.push('a');
|
||||
list.clear();
|
||||
});
|
||||
list.on(() => seen.push('b'));
|
||||
list.fire();
|
||||
assert.deepEqual(seen, ['a']);
|
||||
});
|
||||
|
||||
/** A widget whose scene records what the query port asks of it. */
|
||||
function fakeWidget(overrides = {}) {
|
||||
const listeners = new Set();
|
||||
|
||||
Reference in new issue
Block a user