mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 08:12:24 +00:00
Share links carry the world time when made away from live
Field 28, worldTime, holds the world time of a link made away from live: zigzag seconds since 2026-01-01, like field 8, but it may lie ahead of the link's creation (a forecast moment). Opening such a link pauses the world clock at that time; a link without it leaves the clock alone, so a page opens live and Back or Forward does not stop a replay. Times no JS Date can hold are dropped.
This commit is contained in:
1 parent
0c4da3cdb2
commit
32ec6ed436
8 files changed
+96
-8
No files matched your search
+14
-2
@@ -31,6 +31,7 @@ import {
|
||||
} from '../data/detectionPolicy.js';
|
||||
import { clampScopeFeatherPct } from '../scopeMaskPolicy.js';
|
||||
import { VIEW_STYLES } from '../view/index.js';
|
||||
import { isWorldTime } from '../time/worldClock.js';
|
||||
import { RETIRED_STYLES } from '../visualStylePolicy.js';
|
||||
import {
|
||||
GLOBAL_POST_DEFAULTS,
|
||||
@@ -373,6 +374,7 @@ export const SHARE_VIEW_FIELDS = freezeAll([
|
||||
{ number: 25, key: 'scopeFeatherPct', type: 'uint', default: 100 },
|
||||
{ number: 26, key: 'scopeTerminusPct', type: 'uint', default: null },
|
||||
{ number: 27, key: 'styleParams', type: 'bytes', default: BY_STYLE },
|
||||
{ number: 28, key: 'worldTime', type: 'epoch', default: null },
|
||||
]);
|
||||
const FIELD_BY_KEY = new Map(SHARE_VIEW_FIELDS.map((f) => [f.key, f]));
|
||||
const fieldNumber = (key) => FIELD_BY_KEY.get(key).number;
|
||||
@@ -732,6 +734,9 @@ export function normalizeShareViewState(input = {}) {
|
||||
: null;
|
||||
state.panelState = normalizePanelState(source.panelState);
|
||||
state.sharedAtMs = epochMsOr(source.sharedAtMs);
|
||||
state.worldTime = isWorldTime(source.worldTime)
|
||||
? Math.floor(source.worldTime / 1000) * 1000
|
||||
: null;
|
||||
let view = normalizeView(source.view);
|
||||
if (state.layerState) view = liftTrackedEntity(state.layerState, view);
|
||||
if (view.kind === 'thing') {
|
||||
@@ -948,8 +953,9 @@ export function encodeShareView(input) {
|
||||
writer.sintField(field.number, signedAngle(state[field.key]));
|
||||
break;
|
||||
case 'sharedAtMs':
|
||||
if (state.sharedAtMs !== null)
|
||||
writer.sintField(field.number, epochSeconds(state.sharedAtMs));
|
||||
case 'worldTime':
|
||||
if (state[field.key] !== null)
|
||||
writer.sintField(field.number, epochSeconds(state[field.key]));
|
||||
break;
|
||||
case 'flags': {
|
||||
let bits = 0;
|
||||
@@ -1347,6 +1353,12 @@ export function decodeShareView(code, { nowMs = Date.now() } = {}) {
|
||||
raw.sharedAtMs =
|
||||
createdAtS >= 1 && Number.isSafeInteger(ms) && ms <= nowMs ? ms : null;
|
||||
}
|
||||
// The world time the link was made at, when it was away from live. It
|
||||
// may lie ahead of the link's creation (a forecast) or of now.
|
||||
if (get('worldTime')) {
|
||||
const ms = (SHARE_VIEW_EPOCH_S + unz(get('worldTime').varint)) * 1000;
|
||||
raw.worldTime = isWorldTime(ms) ? ms : null;
|
||||
}
|
||||
|
||||
if (get('layerState'))
|
||||
raw.layerState = decodeLayers(
|
||||
|
||||
@@ -361,6 +361,7 @@ test('every registered field round-trips at once', () => {
|
||||
})),
|
||||
},
|
||||
sharedAtMs: NOW_MS,
|
||||
worldTime: NOW_MS - 6 * 3_600_000,
|
||||
};
|
||||
// A thing view derives its camera (roll 0), so the camera fields are
|
||||
// checked on the same state as a place view.
|
||||
@@ -501,6 +502,7 @@ test('the field registry is well formed and permanent', () => {
|
||||
[25, 'scopeFeatherPct', 100],
|
||||
[26, 'scopeTerminusPct', null],
|
||||
[27, 'styleParams', BY_STYLE],
|
||||
[28, 'worldTime', null],
|
||||
],
|
||||
);
|
||||
assert.deepEqual(
|
||||
@@ -1338,3 +1340,22 @@ test('a layer option filed under a mirror layer is ignored', () => {
|
||||
{ scope: 'layer-option', code: `${military}.${layerTokenNumber('m')}` },
|
||||
]);
|
||||
});
|
||||
|
||||
test('the world time is written only away from live, and may lie ahead', () => {
|
||||
const at = (worldTime) =>
|
||||
decodeShareView(encodeShareView({ sharedAtMs: NOW_MS, worldTime }), {
|
||||
nowMs: NOW_MS,
|
||||
}).state.worldTime;
|
||||
assert.equal(at(null), null);
|
||||
assert.equal(at(NOW_MS - 3_600_000), NOW_MS - 3_600_000);
|
||||
// A forecast moment ahead of the link's creation is kept.
|
||||
assert.equal(at(NOW_MS + 86_400_000), NOW_MS + 86_400_000);
|
||||
// Before the 2026 epoch too: the field is zigzag.
|
||||
assert.equal(at(Date.UTC(2024, 0, 1)), Date.UTC(2024, 0, 1));
|
||||
// Past what a Date can hold: dropped, so the link opens live.
|
||||
assert.equal(at(8.8e15), null);
|
||||
assert.ok(
|
||||
encodeShareView({ sharedAtMs: NOW_MS, worldTime: NOW_MS - 1000 }).length >
|
||||
encodeShareView({ sharedAtMs: NOW_MS }).length,
|
||||
);
|
||||
});
|
||||
Reference in new issue
Block a user