mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-06 11:24:00 +00:00
fix: retain completed scene status in current snapshots
This commit is contained in:
1 parent
e0652b19f2
commit
3164405108
5 files changed
+6
-5
No files matched your search
@@ -339,7 +339,6 @@ owners with synchronous cleanup. Existing scene, share and HUD engines retain
|
|||||||
their entry points. `ui/styles` loads the ordered stylesheet entry; component
|
their entry points. `ui/styles` loads the ordered stylesheet entry; component
|
||||||
files retain the original cascade, including responsive and dock refinements.
|
files retain the original cascade, including responsive and dock refinements.
|
||||||
|
|
||||||
|
|
||||||
## UI state and Scene actions
|
## UI state and Scene actions
|
||||||
|
|
||||||
`StyleManager.subscribeShareState(listener)` supplies the current shareable
|
`StyleManager.subscribeShareState(listener)` supplies the current shareable
|
||||||
|
|||||||
@@ -258,7 +258,7 @@ test('deferred search releases only after its final authority check', () => {
|
|||||||
assert.match(ui, /begin: \(\) => this\._beginDeferredNavigation\('location'\)/);
|
assert.match(ui, /begin: \(\) => this\._beginDeferredNavigation\('location'\)/);
|
||||||
assert.match(ui, /beforeFly: \(generation\) => this\._reassertNavigationHandoff\(generation\)/);
|
assert.match(ui, /beforeFly: \(generation\) => this\._reassertNavigationHandoff\(generation\)/);
|
||||||
assert.match(ui, /isCurrent: \(generation\) =>\s*!this\._disposed && generation === this\._navigationGeneration/);
|
assert.match(ui, /isCurrent: \(generation\) =>\s*!this\._disposed && generation === this\._navigationGeneration/);
|
||||||
assert.match(ui, /change\.type === 'settled'\) this\._settleLocationSearchUi\(change\.generation\)/);
|
assert.match(ui, /change\.type === 'settled'\)\s*this\._settleLocationSearchUi\(change\.generation\)/);
|
||||||
assert.doesNotMatch(search.slice(0, search.indexOf('await this.search')), /_releaseFollowCamera/);
|
assert.doesNotMatch(search.slice(0, search.indexOf('await this.search')), /_releaseFollowCamera/);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|||||||
@@ -404,6 +404,7 @@ export class SceneDirector {
|
|||||||
_publish(change) { this._state?.publish(change); }
|
_publish(change) { this._state?.publish(change); }
|
||||||
|
|
||||||
_shotOutcome(type, scene, shot, index = scene.shots.indexOf(shot)) {
|
_shotOutcome(type, scene, shot, index = scene.shots.indexOf(shot)) {
|
||||||
|
if (type === 'shot-loaded') this._presentation.status = `Loaded: ${scene.title} / ${shot.title}`;
|
||||||
this._publish({ type, sceneId: scene.id, sceneTitle: scene.title, shot, index });
|
this._publish({ type, sceneId: scene.id, sceneTitle: scene.title, shot, index });
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -979,6 +980,7 @@ export class SceneDirector {
|
|||||||
link.click();
|
link.click();
|
||||||
link.remove();
|
link.remove();
|
||||||
URL.revokeObjectURL(url);
|
URL.revokeObjectURL(url);
|
||||||
|
this._presentation.status = 'Project exported';
|
||||||
this._publish({ type: 'project-exported', project: this._project });
|
this._publish({ type: 'project-exported', project: this._project });
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -100,9 +100,8 @@ export class SceneControls {
|
|||||||
this.setPlaybackActive(state.playbackActive);
|
this.setPlaybackActive(state.playbackActive);
|
||||||
if (initial || type === 'playback-keyboard')
|
if (initial || type === 'playback-keyboard')
|
||||||
this.setPlaybackKeyboardEnabled(state.keyboardEnabled);
|
this.setPlaybackKeyboardEnabled(state.keyboardEnabled);
|
||||||
if (type === 'project-exported') this.updateStatus('Project exported');
|
if (type === 'project-exported') this.updateStatus(state.status);
|
||||||
if (type === 'shot-loaded')
|
if (type === 'shot-loaded') this.updateStatus(state.status);
|
||||||
this.updateStatus(`Loaded: ${change.sceneTitle} / ${change.shot.title}`);
|
|
||||||
if (type === 'run-event' && change.event === 'shot_start')
|
if (type === 'run-event' && change.event === 'shot_start')
|
||||||
this.setButtons(state.running);
|
this.setButtons(state.running);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -374,6 +374,7 @@ test('Scene controls consume current state, preserve rows on progress, and unsub
|
|||||||
f.state.progress = 0.5;
|
f.state.progress = 0.5;
|
||||||
channel.publish({ type: 'progress-changed' });
|
channel.publish({ type: 'progress-changed' });
|
||||||
assert.equal(f.elements.shots.children[0], row);
|
assert.equal(f.elements.shots.children[0], row);
|
||||||
|
f.state.status = 'Project exported';
|
||||||
channel.publish({ type: 'project-exported' });
|
channel.publish({ type: 'project-exported' });
|
||||||
assert.equal(f.elements.status.textContent, 'Project exported');
|
assert.equal(f.elements.status.textContent, 'Project exported');
|
||||||
owner.destroy();
|
owner.destroy();
|
||||||
|
|||||||
Reference in new issue
Block a user