mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 08:12:24 +00:00
address review findings on voice outlines
- remove the unused Nominatim reserve(); spacing tests now measure the actual transport start across processes - start each queued building's 2 s ground-sampling budget when it reaches the head of the queue, and request a frame on promotion - accept Nominatim and grounds outlines that cross the antimeridian - let an unnamed school, university, hospital, cemetery, stadium or zoo area answer a grounds ask whose head noun names that kind, using only the part that holds the point; compare grounds names symmetrically - charge shared OpenFreeMap consumers their own slice and keep the charged budget at the previous 64 MiB - share one place-name fold, point-in-polygon, line stitching and nextTask helper instead of duplicates - exclude Who's On First sources licensed only as "CC BY (equivalent)" or "CC0 (equivalent)"; rebuild the pack from the pinned archives - whole-word neighbourhood alias guard; correct the outline size-limit comment - restore DATA_SOURCES.md table formatting, keeping only real edits - test behaviour instead of private engine fields
This commit is contained in:
1 parent
5a1cfa6800
commit
2e82425d62
37 files changed
+921
-481
No files matched your search
@@ -379,6 +379,7 @@ test('places pack: every state file, unique ids, sane and valid rings', () => {
|
||||
});
|
||||
|
||||
const WOF_LICENSE_POLICY = readJson(WOF_LICENSES);
|
||||
const WOF_RECORD_COUNT = 61_441;
|
||||
const ALLOWED_WOF_LICENSES = new Set(WOF_LICENSE_POLICY.licenses);
|
||||
const licenceAllowed = (value) =>
|
||||
typeof value === 'string' && ALLOWED_WOF_LICENSES.has(value);
|
||||
@@ -455,6 +456,8 @@ test('neighborhood pack ships only explicitly allowed and credited sources', ()
|
||||
'mapzen',
|
||||
'can-ons',
|
||||
'can-saskodp',
|
||||
'can-gatsudd',
|
||||
'esp-aytomad',
|
||||
])
|
||||
assert.equal(sources[excluded], undefined, excluded);
|
||||
const listed = readFileSync(new URL('files.js', WOF), 'utf8');
|
||||
@@ -494,23 +497,15 @@ test('neighborhood pack ships only explicitly allowed and credited sources', ()
|
||||
}
|
||||
for (const [key, source] of Object.entries(sources))
|
||||
assert.equal(used[key], source.records, key);
|
||||
assert.deepEqual(index.meta.recordExclusions, {
|
||||
'can-ons': 36,
|
||||
'can-saskodp': 54,
|
||||
});
|
||||
const excludedIds = new Set();
|
||||
for (const rule of Object.values(
|
||||
WOF_LICENSE_POLICY.recordExclusions.sources,
|
||||
)) {
|
||||
assert.equal(rule.ids.length, rule.count);
|
||||
for (const id of rule.ids) {
|
||||
assert.ok(!excludedIds.has(id));
|
||||
excludedIds.add(id);
|
||||
assert.ok(!ids.has(id), `${id} excluded from shipped rows`);
|
||||
}
|
||||
}
|
||||
assert.equal(excludedIds.size, 90);
|
||||
assert.equal(ids.size, 61_665);
|
||||
// A licence listed only as an "equivalent" of an open licence is not one.
|
||||
for (const [key, source] of Object.entries(sources))
|
||||
assert.doesNotMatch(source.license, /equivalent/i, key);
|
||||
assert.ok(
|
||||
WOF_LICENSE_POLICY.licenses.every((value) => !/equivalent/i.test(value)),
|
||||
);
|
||||
assert.deepEqual(index.meta.recordExclusions, {});
|
||||
assert.deepEqual(WOF_LICENSE_POLICY.recordExclusions.sources, {});
|
||||
assert.equal(ids.size, WOF_RECORD_COUNT);
|
||||
});
|
||||
|
||||
test('neighborhoods resolve near the view, in any script', async () => {
|
||||
|
||||
Reference in new issue
Block a user