fix(places): don't let the browser cache a refused Google answer

The Places and Geocoding proxies sent Cache-Control: private,
max-age=300 whatever Google answered. A 403 from a key without the
Places API, or a geocode REQUEST_DENIED / OVER_QUERY_LIMIT (which
Google sends as HTTP 200), was then replayed from the browser cache for
five minutes after the key was fixed. Refusals are now no-store.
This commit is contained in:
Rudy Celekli committed 2026-11-04 22:13:01 -05:00
1 parent 7d8b80db0a
commit 2e2f756468
3 files changed
+62 -3

No files matched your search

+38
View File
@@ -185,6 +185,44 @@ for (const preview of [false, true]) {
});
}
test('a refused Places or Geocoding answer is not kept by the browser', async (t) => {
const plugin = googlePlacesContextProxy({
resolveApiKey: () => 'fixture-server-key',
});
const request = install((middlewares) =>
plugin.configureServer({ middlewares }),
);
t.mock.method(globalThis, 'fetch', async () =>
Response.json({ error: { message: 'API key not valid' } }, { status: 403 }),
);
for (const url of [
['/api/google/nearby-places', '?lat=30&lon=-97'],
['/api/google/text-search', '?q=museum&lat=30&lon=-97'],
]) {
const refused = await request(...url);
assert.equal(refused.statusCode, 403);
assert.equal(refused.headers['cache-control'], 'no-store');
}
// Geocoding reports a denied key as HTTP 200 with a status of its own.
let status = 'REQUEST_DENIED';
t.mock.method(globalThis, 'fetch', async () =>
Response.json({ status, results: [] }),
);
for (const denied of ['REQUEST_DENIED', 'OVER_QUERY_LIMIT']) {
status = denied;
const answer = await request('/api/google/geocode', '?address=Austin');
assert.equal(answer.statusCode, 200);
assert.equal(answer.body.status, denied);
assert.equal(answer.headers['cache-control'], 'no-store', denied);
}
for (const answered of ['OK', 'ZERO_RESULTS']) {
status = answered;
const answer = await request('/api/google/geocode', '?address=Austin');
assert.equal(answer.headers['cache-control'], 'private, max-age=300');
}
});
test('OSRM routing preserves aliases, cache, span guards and upstream failure behavior', async (t) => {
const request = install(installRouteMiddleware);
let calls = 0;