Keep the transit layer's Cesium objects in its rendering part, ask terrain through the height gateway, and take height, lifecycle and testing off the Cesium list

The transit rendering part now owns everything that drives Cesium: the two
billboard collections (made, shown, cleared and removed in the same order
as before), the camera change listener and its sensitivity claim, the
preRender hookup, the camera height and subpoint reads, the globe-shown
and flat-terrain check, the mesh floor sampler call that sees through the
billboards, and the frame-measuring QA probe. The camera factory import
moves there too.

The height part asks the terrain under a vehicle through the queries
gateway (heightsOf over the query port) instead of the Cesium height
service; the Cesium query port answers it from the same loaded globe
tiles. The QA fixture paths are built with the shared ellipsoid helper,
which gives the same coordinates.

The transit tests bind a query port that reads the fake globe, and a new
test covers the hidden, terrain and flat globe answers. Height, lifecycle
and testing no longer import Cesium or drive the viewer, so they leave the
allow-list.
This commit is contained in:
Sameh Khamis committed 2026-11-07 04:35:50 -08:00
1 parent 35021d9f10
commit 2e0a206c6c
6 files changed
+387 -283

No files matched your search

+14 -88
View File
@@ -1,16 +1,5 @@
import { destroyTrack } from '../../data/contactPlayback.js';
import * as Cesium from 'cesium';
// The Cesium camera factory: given a viewer of a caller's own, with no
// renderer bound, the layer's camera reads find a camera port.
import '../../render/cesium/camera.js';
import {
claimCameraSensitivity,
releaseCameraSensitivity,
} from '../../data/cameraSensitivity.js';
import {
CAMERA_PERCENTAGE_CHANGED,
TRANSIT_SELECTED_OVERLAY_SOURCE_ID,
} from './policy.js';
import { TRANSIT_SELECTED_OVERLAY_SOURCE_ID } from './policy.js';
import { TRANSIT_ENABLED_FEEDS } from '../../data/transitFeeds.js';
/**
@@ -22,38 +11,10 @@ import { TRANSIT_ENABLED_FEEDS } from '../../data/transitFeeds.js';
* @returns {object}
*/
export function createLifecycle({ state, services, parts }) {
const {
registerSpriteCollection,
unregisterSpriteCollection,
restoreSpriteOrder,
} = services.sprites;
const { restoreSpriteOrder } = services.sprites;
const { registerPickOwner, unregisterPickOwner } = services.picking;
const { releaseContinuousRender } = services.render;
/**
* Borrow the camera's change sensitivity through the shared claim ledger.
*
* `camera.changed` fires on a percentage of the view moving, and this layer
* needs a finer trigger than the default to notice it has entered a feed's
* coverage. It is a single shared number, so the claim is registered by name
* rather than written directly: comparing the VALUE on the way out could not
* tell this layer's 0.05 from anybody else's, and handing back the coarse
* default while Bikeshare was still relying on a fine one was exactly the
* bug that produced.
*/
function borrowCameraSensitivity(viewer) {
claimCameraSensitivity(
viewer?.camera,
'transit',
CAMERA_PERCENTAGE_CHANGED,
);
}
/** Give the claim up. The camera keeps whatever anyone else still asks for. */
function returnCameraSensitivity(viewer) {
releaseCameraSensitivity(viewer?.camera, 'transit');
}
/**
* Follow the active post-FX style so the sprites can be restyled for it.
* The map style arrives on `gev:style-change`; a cockpit vision override
@@ -126,22 +87,11 @@ export function createLifecycle({ state, services, parts }) {
/**
* Create the point collection. Called once at bootstrap.
* @param {Cesium.Viewer} viewer
* @param {object} viewer
*/
init(viewer) {
state._viewer = viewer;
state._markers = new Cesium.BillboardCollection({
blendOption: Cesium.BlendOption.TRANSLUCENT,
});
viewer.scene.primitives.add(state._markers);
registerSpriteCollection('transit', state._markers);
state._animatedMarkers = new Cesium.BillboardCollection({
blendOption: Cesium.BlendOption.TRANSLUCENT,
});
viewer.scene.primitives.add(state._animatedMarkers);
registerSpriteCollection('transit-motion', state._animatedMarkers);
state._animatedMarkers.show = false;
state._markers.show = false;
parts.rendering.createMarkers(viewer);
state._enabled = false;
state._activeFeeds.clear();
state._feedStatus.clear();
@@ -172,15 +122,14 @@ export function createLifecycle({ state, services, parts }) {
/**
* Show vehicles, watch the camera, and poll every feed in range.
* @param {Cesium.Viewer} viewer
* @param {object} viewer
*/
enable(viewer) {
state._enabled = true;
bindVisibility();
state._generation += 1;
state._error = null;
state._markers.show = true;
state._animatedMarkers.show = true;
parts.rendering.showMarkers();
state._maintenanceTimer = setInterval(
parts.rendering.maintainPresentation,
250,
@@ -189,22 +138,17 @@ export function createLifecycle({ state, services, parts }) {
parts.selection.installClickHandler(viewer);
registerPickOwner('transit', (pickedId) => state._vehicles.has(pickedId));
if (!state._cameraChangedAttached) {
viewer.camera.changed.addEventListener(parts.viewport.onCameraChanged);
borrowCameraSensitivity(viewer);
parts.rendering.watchCamera(viewer, parts.viewport.onCameraChanged);
state._cameraChangedAttached = true;
}
if (!state._preRenderRemove) {
state._preRenderRemove = viewer.scene.preRender.addEventListener(
parts.rendering.onPreRender,
);
}
parts.rendering.startFrames(viewer);
parts.viewport.runProximityCheck();
restoreSpriteOrder(viewer);
},
/**
* Hide everything, stop polling, drop all vehicles.
* @param {Cesium.Viewer} viewer
* @param {object} viewer
*/
disable(viewer) {
state._enabled = false;
@@ -226,16 +170,10 @@ export function createLifecycle({ state, services, parts }) {
parts.selection.removeClickHandler();
unregisterPickOwner('transit');
if (state._cameraChangedAttached) {
viewer.camera.changed.removeEventListener(
parts.viewport.onCameraChanged,
);
returnCameraSensitivity(viewer);
parts.rendering.unwatchCamera(viewer, parts.viewport.onCameraChanged);
state._cameraChangedAttached = false;
}
if (state._preRenderRemove) {
state._preRenderRemove();
state._preRenderRemove = null;
}
parts.rendering.stopFrames();
parts.ingestion.abortAllInFlight();
state._activeFeeds.clear();
state._feedStatus.clear();
@@ -246,10 +184,7 @@ export function createLifecycle({ state, services, parts }) {
}
state._vehicles.clear();
parts.height.clear();
state._markers?.removeAll();
state._animatedMarkers?.removeAll();
if (state._animatedMarkers) state._animatedMarkers.show = false;
if (state._markers) state._markers.show = false;
parts.rendering.clearMarkers();
state._altitudeGateOpen = false;
state._moving.clear();
state._heightDirty.clear();
@@ -281,20 +216,11 @@ export function createLifecycle({ state, services, parts }) {
/**
* Tear down the collection entirely and release every shared registration.
* @param {Cesium.Viewer} viewer
* @param {object} viewer
*/
destroy(viewer) {
this.disable(viewer);
if (state._markers) {
unregisterSpriteCollection('transit', state._markers);
viewer?.scene?.primitives?.remove(state._markers);
state._markers = null;
}
if (state._animatedMarkers) {
unregisterSpriteCollection('transit-motion', state._animatedMarkers);
viewer?.scene?.primitives?.remove(state._animatedMarkers);
state._animatedMarkers = null;
}
parts.rendering.destroyMarkers(viewer);
state._overlayHost.clearSource(TRANSIT_SELECTED_OVERLAY_SOURCE_ID);
parts.height.clear();
unbindStyleEvents();