fix(shortcuts): a shortcut key held with Cmd, Ctrl or Alt runs no shortcut

The application shortcut listener read the key alone, so copying with
Cmd+C or Ctrl+C toggled the CCTV layer and opened the nearest camera,
Cmd+F opened the layers panel and Cmd+1 to 6 changed the visual style.
Chords are now left to the browser. Shift is not a chord, a held key
still repeats, and Escape dismisses search either way.
This commit is contained in:
Said Turksever committed 2026-11-13 01:12:58 +00:00
1 parent 10a788db78
commit 2c4d865ef9
3 files changed
+30 -6

No files matched your search

+16 -3
View File
@@ -117,10 +117,23 @@ test('the supplied search target retains editing even without form markup', () =
assert.deepEqual(f.calls, [['dismissSearch']]);
});
test('shortcut extraction does not change repeat or modifier policy', () => {
test('a held key still repeats its shortcut, and Shift is not a chord', () => {
const f = shortcuts();
f.press('h', new Element(), { repeat: true, ctrlKey: true });
assert.deepEqual(f.calls, [['toggleHud']]);
f.press('h', new Element(), { repeat: true });
f.press('C', new Element(), { shiftKey: true });
assert.deepEqual(f.calls, [['toggleHud'], ['toggleCctv']]);
});
test('browser and system chords on a shortcut key run no shortcut', () => {
const f = shortcuts();
for (const modifier of ['metaKey', 'ctrlKey', 'altKey'])
for (const key of ['1', '6', 'h', 'o', 'v', 'f', 'd', 'c', 'C'])
f.press(key, new Element(), { [modifier]: true });
// Copying (Cmd+C, Ctrl+C) used to turn CCTV on and open the nearest camera.
assert.deepEqual(f.calls, []);
f.press('c');
f.press('Escape', new Element(), { ctrlKey: true });
assert.deepEqual(f.calls, [['toggleCctv'], ['dismissSearch']]);
});
test('destroy synchronously removes shortcuts and a replacement binds once', () => {